urbit / azimuth Goto Github PK

General-purpose PKI on Ethereum

License: MIT License

JavaScript 33.07% Solidity 53.58% hoon 13.36%

azimuth's Introduction

Urbit

Urbit is a personal server stack built from scratch. It has an identity layer (Azimuth), virtual machine (Vere), and operating system (Arvo).

A running Urbit "ship" is designed to operate with other ships peer-to-peer. Urbit is a general-purpose, peer-to-peer computer and network.

This repository contains the Arvo Kernel

For the Runtime, see Vere. For more on the identity layer, see Azimuth. To manage your Urbit identity, use Bridge.

Install

To install and run Urbit, please follow the instructions at urbit.org/getting-started. You'll be on the live network in a few minutes.

Contributing

Contributions of any form are more than welcome! Please take a look at our contributing guidelines for details on our git practices, coding styles, and how we manage issues.

You might also be interested in joining the urbit-dev mailing list.

Release

For details about our release process, see the maintainers guidelines

azimuth's People

Stargazers

Watchers

azimuth's Issues

"Sectors" extension

was super bummed when azimuth didn't take this approach, was gonna wait until I had time to monetize it but this guy is gonna beat me to it

iamdefinitelyahuman/nftoken#2

Remove pointsownedby from azimuth to save gas

Spawning/transferring an azimuth point currently costs tens of USD. Some of that gas[1] goes to keeping the pointsownedby mapping up-to-date. If we imagine all 4 billion points being spawned, that's quite a lot of value. (even just moving all 65k stars onto Layer 2 will cost a good chunk of change.)

It seems that the only use for this mapping is the balanceOf function in the ecliptic's ERC721 interface. I doubt that's called by any contract, or ever really will be. It doesn't seem that useful. It's probably called lots by off-chain clients (token trackers and wallets). I propose that we either (a) abandon the ERC721 interface; or (b) return balance=0, and let those clients just be wrong; or (c) implement balanceOf by iterating through all 4 billion points and counting how many have owners that match the given address. This would be slow, but it's better for off-chain clients to be slow for a cosmetic function than for on-chain contracts to be charged gas for essential functions.

[1] I don't know what proportion, but someone could and should estimate it.

It's difficult to determine the point # from the ERC721 metadata

I was recently interested to look up information about a point I found on OpenSea using the contract interface directly: https://etherscan.io/address/azimuth.eth#readContract and discovered that it would be nearly impossible for someone with less context than myself to determine the point number from the metadata.

Possibilities:

This may not be an important concern for anybody in practice
An easily accessible @p → point number utility may suffice
It could make sense to add this to the metadata, but might be overkill

Tests & deployment broken

This is what we get for not running CI.. 😄 (because #13)

I'm not sure when this happened exactly, but the test suite doesn't pass. Like, more than is described in #13. There are some problems with migrations/2_deploy_contracts.js that will prevent it from running at all -- web3 is used, but never imported nor a web3 object created, and the web3 version pinned in package.json has a different API than the code used in there anyway (e.g. it seems web3.fromAscii should be used in place of web3.utils.fromAscii).

But after fixing that up or checking out c950c6a, the last commit before those changes were made, the test suite doesn't pass. Even checking out v1.2.1, the tests don't pass. I haven't checked back any further yet.

/cc @liam-fitzgerald @Fang-

Unclear Claims comment

Here's an excerpt from Claims.sol:

Most commonly, these are about identity, with a claim's protocol defining the context or platform of the claim, and its dossier proof of its validity.

What is the "context or platform" for the claim? What is is a "dossier" in this usage?

Ecliptic: galaxies should be able to issue planets

In the launch version of Ecliptic, the planets that directly belong to galaxies are inaccessible. This is a niche issue - I (~rolsut-rospub) may be the only person directly affected. However, it's also uncontroversial - no one thinks it should permanently stay like that, it was just a matter of development triage - and may be a good candidate for a first contract upgrade, assuming nothing needs to be fast-tracked past it.

Enabling their use makes the logic of some functions somewhat more complex, so it's not a simple matter of just not disallowing them. However, it's not a huge task, and it's one I am willing to take on. I plan to work with Tlon's Azimuth team on this so we get it right, then I (~rep) will propose it on-chain once it has their endorsement.

Contracts/addresses not in sync with those deployed

Since the deployment of the new 0x33EeCbf908478C10614626A9D304bfe18B78DD73 contract as ecliptic.eth a few days ago, there have been no OpenSea sales of stars/planets, because OpenSea's /assets/urbit-id URL still points at the old 0xa5 contract. They do have a new /assets/azimuth-points-v2 URL that references points via the new contract, but there's no activity there, either. Anyway, that's a different-though-related issue, and I have a ticket (#141974) open with them on it, as well as ticket 265 with Tlon.

The issue for this ticket is that the README doesn't reflect the new Ecliptic address (and possibly others idk), and the new Ecliptic contract isn't present in the /contracts directory. This makes it somewhat tricky for people to track what's happened across an upgrade. It's of course understandable that the most recent Ecliptic contract couldn't be posted here before deployment since it was a security fix, but the ecliptic.eth address shown in the README is at least 2 versions old.

ERC721 compatibility

The Transfer and Approval events don't index their _tokenId parameters. This is why, for example, Etherscan's NFT tracker doesn't record our transfers. This should be a very small change to the Ecliptic, something like this:
philipcmonk@5cdec2c

We should wait to make any proposal (which would need to be voted on by the senate) until a version of #5 of is merged so we can do it according to a process.

Etherscan reports AZP as an ERC-20, not an ERC-721, token.

Etherscan reports azimuth points as ERC-20 tokens.

This might relate to #8 .

Here, for instance, is the address which owns ~zod:

https://etherscan.io/address/0x3B17d097D9dd711e4Ef8517AbBF18B2Ba64381fe#tokentxns

ERC721 compatibility tests don't pass

IIRC this isn't a concern (in that everything works, and we have reasons why the existing tests fail), but it's annoying. What's up with these, and can we fix them? Should we just delete the tests that we know fail?

Update (2020/07/23)

I've changed the title of this issue to reflect that it's only these specific tests that don't pass. They're no longer included in the main test suite, and can be found in test-extras instead.

tests/deployments fail

npm test fails to deploy Azimuth contracts. This is also an issue for bridge.

Not sure if this is truly a gas issue or if that error is a red herring. I do know that there were a few gas-related changes in Shanghai.

Steps to reproduce:

clone this repo
nvm use
npm i -g truffle
npm i
npm run test

➜  azimuth git:(master) ✗ truffle --version
Truffle v5.9.0 (core: 5.9.0)
Ganache v7.8.0
Solidity - pragma (solc-js)
Node v16.18.0
Web3.js v1.10.0

➜  azimuth git:(master) ✗ npm test

> [email protected] test
> npm-run-all test:setup test:truffle test:cleanup --continue-on-error


> [email protected] test:setup
> npm run build && npm run test:ganache


> [email protected] build
> truffle compile


Compiling your contracts...
===========================
> Everything is up to date, there is nothing to compile.

> [email protected] test:ganache
> ganache-cli --gasLimit 6000000 > /dev/null &


> [email protected] test:truffle
> truffle test

Using network 'development'.


Compiling your contracts...
===========================
> Everything is up to date, there is nothing to compile.
Error:  *** Deployment Failed ***

"Azimuth" ran out of gas (using a value you set in your network config or deployment parameters.)
   * Block limit:  6000000 (0x5b8d80)
   * Gas sent:     6000000 (0x5b8d80)

    at /Users/admin/.nvm/versions/node/v16.18.0/lib/node_modules/truffle/build/webpack:/packages/deployer/src/deployment.js:330:1
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at module.exports (/Users/admin/git/dillon/azimuth/migrations/2_deploy_contracts.js:29:19)
Truffle v5.9.0 (core: 5.9.0)
Node v16.18.0

> [email protected] test:cleanup
> pkill -f ganache-cli

ERROR: "test:truffle" exited with 1.

Oversized contracts
I noticed that two contracts are over the 24kib limit: Ecliptic.sol and Azimuth.sol. I'm not sure if this is causing issues but messing with configs a bit I was able to produce this error as well: "Azimuth" -- The contract code couldn't be stored, please check your gas limit... Can't seem to config ganache to allow it, even with --chain.hardfork merge --chain.allowUnlimitedInitCodeSize --chain.allowUnlimitedContractSize

➜  azimuth git:(master) ✗ truffle run contract-size ./contracts
┌──────────────────────────────────────────────────────────────────────┬──────────┐
│                                                                      │          │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ AddressUtils                                                         │ 0.07 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ Azimuth                                                              │ 27.97 K… │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ Censures                                                             │ 4.76 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ ConditionalStarRelease                                               │ 16.12 K… │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ DelegatedSending                                                     │ 7.79 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ Claims                                                               │ 6.17 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ ENS                                                                  │ 0.00 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ ERC165                                                               │ 0.00 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ ENSRegistry                                                          │ 2.37 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ ERC721                                                               │ 0.00 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ ERC721Enumerable                                                     │ 0.00 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ ERC721Basic                                                          │ 0.00 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ ERC721Receiver                                                       │ 0.00 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ ERC721Metadata                                                       │ 0.00 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ Ecliptic                                                             │ 38.64 K… │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ EclipticBase                                                         │ 0.00 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ EclipticResolver                                                     │ 0.69 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ LinearStarRelease                                                    │ 9.92 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ ITreasuryProxy                                                       │ 0.00 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ Migrations                                                           │ 0.74 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ NFTokenReceiverTestMock                                              │ 0.37 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ Naive                                                                │ 0.10 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ Ownable                                                              │ 0.94 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ PlanetSale                                                           │ 3.80 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ Polls                                                                │ 7.48 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ PublicResolver                                                       │ 7.75 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ ReadsAzimuth                                                         │ 0.23 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ ResolverInterface                                                    │ 0.00 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ SafeMath                                                             │ 0.07 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ SafeMath16                                                           │ 0.07 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ SafeMath8                                                            │ 0.07 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ SupportsInterfaceWithLookup                                          │ 0.46 KiB │
├──────────────────────────────────────────────────────────────────────┼──────────┤
│ TakesPoints                                                          │ 0.23 KiB │
└──────────────────────────────────────────────────────────────────────┴──────────┘

Please consider adding a LICENSE

Right now it is not clear whether I am allowed to read this code, or what rights I might be forfeiting by doing so.

Update Truffle

azimuth-solidity is currently using truffle 4.x.x, but there has since been a few 5.x.x releases. Upgrading might resolve the remaining nits highlighted in #13.

(This seems to require more work than simply bumping the version number. I briefly tried and ran into migration errors.)

Document Polls should include URLs

Otherwise how are we to know what we are voting on? Is there assumed to be an out-of-band means to distribute the documents?

E.g. I see that there are already 3 document polls outstanding; where do I find the document that hashes to cb1f81e42b5e75f000f94fc71a3ea70cab4bfc6f236b91e717f1b9516e5596b5 ?

Broken link on azimuth.network

The link to "Etherscan" on the azimuth.network page is broken:

<a href="https://https://etherscan.io/address/azimuth.eth" target="_blank">
            <h5 class="inline underline">Etherscan ↗</h5>
          </a>

Setting proxies takes multiple transactions

People should be re-ticketing often. At the very least, it shouldn't be hard to re-ticket, or to accept and configure a (new) point with a fresh wallet.

To that end, an "accept transfer and set proxies" function might be useful, so that it doesn't take 3-4 separate transactions.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.