Code Monkey home page Code Monkey logo

Comments (7)

philipcmonk avatar philipcmonk commented on August 16, 2024

As far as I'm aware, this is the only part of the code that explicitly disallows spawning them:

require( (uint8(azimuth.getPointSize(prefix)) + 1) ==
uint8(azimuth.getPointSize(_point)) );

What I don't know is whether the rest of the flow assumes things like "a point's children count fits in a uint16" or "a point's sponsor is always one level up" and whether they could be worked around. I suspect it's possible, but that's the first thing to check.

Obviously, anything in Ecliptic is upgradable, anything in Azimuth isn't really, so keep that in mind.

from azimuth.

Fang- avatar Fang- commented on August 16, 2024

For previous discussion, see #2.

When making this change, spawn- and child-related logic needs to be re-checked in all contracts. I'm unsure off the top of my head whether it matters anywhere, but the assumption during development was always "galaxies can spawn max 255 child ships".

if ( size == Azimuth.Size.Galaxy )
{
return 255;

from azimuth.

juped avatar juped commented on August 16, 2024

I read over the contracts (lightly) a while back and the data store (Azimuth contract) has either a 2^32 max or 2^256 max on everything. I don't think that much in Ecliptic besides spawn limits is implicated - some things, like escape logic (can only escape to one class higher) are not actually problems in my view (it's okay if escaping from your nonstandard class of parent is one-way).

I anticipate a lot more effort rechecking all the logic than in actually adding new logic.

from azimuth.

philipcmonk avatar philipcmonk commented on August 16, 2024

That's probably true. Of course, for Urbit to support these there may be changes required in the %jael vane as well. That's easier, though.

from azimuth.

juped avatar juped commented on August 16, 2024

I predate %jael so it's not familiar to me, but I will at least look it over.

from azimuth.

joemfb avatar joemfb commented on August 16, 2024

I suspect %ames is more likely to have an issue with this than %jael. The :dns app also might need some adjustment for this case. Happy to take a look when things settle down a little.

from azimuth.

juped avatar juped commented on August 16, 2024

Historically, it worked fine pre-jaeling of ames; depends on how much has been gutted.

from azimuth.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.