Code Monkey home page Code Monkey logo

implay's People

Contributors

bovirus avatar tsl0922 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

implay's Issues

Ability to use custom keyboard shortcuts

Some options don't have keyboard shortcuts, like Open Url (which i use a lot). so i was thinking that if it was possible to let users add their custom keyboard shortcuts for different options. (Would it be possible to add URL playlist, like having Add Url Option into the playlist)

Also one thing to note: some times the ctrl+v doesn't work when pasting the url (on the Input Url Here prompt) it gets stuck and you can't even close the player.

The AppImage now works well, you don't need to download the libOpenGL.so.0 library separately, thanks for that.

ImPlay portable mode

Hello.
On Windows, is there any way to make ImPlay detect the implay.conf in a directory other than "%APPDATA%\implay"?
Like mpv does with the "portable_config" folder next to mpv.exe, for example. If not, is there a possibility to implement something like this? 😃

Thanks for reading.

Changing font doesn't work

Describe the bug
I am trying to change the font through the settings dialog or implay.conf, but the font does not change.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the settings dialog.
  2. Click on the font tab.
  3. Click the open folder button.
  4. Select a ttf file.
  5. Restart ImPlay.

Expected behavior
The interface font should be changed to the selected ttf.

Actual behavior
The interface font still appears to be the default monospace font.

Environment (please complete the following information):

  • OS: Windows 11
  • Version: 22H2

ImPlay does not read from standard input when given as "-"

Describe the bug
I just discovered the player and would like to use it as the player for the streamlink instead of the default mpv, but the player opens without playing any media. After doing some tests, I noticed that "cat somemediafile | ImPlay -" does not work where in the default mpv it works perfectly. Replacing "-" with "/dev/stdin" makes ImPlay able to play the content.

Expected behavior
I expect "-" to work normally as well as "/dev/stdin" to maintain compatibility with other programs.

Environment (please complete the following information):

  • OS: Linux Mint
  • Version 21.1

[Feat] Add packages to software sources for each platform

Feature Request

  • It is hoped that the installation package can be submitted to the software source of each platform, so that users can install and update it conveniently.

I have submitted the ImPlay under Windows to the Scoop software (package) management platform. After the PR is passed, it can be installed through scoop install implay or scoop install implay-dev.

Bugged resize cursor

With no-border/border=no resize, cursor starts flickering when trying to resize the window

Environment:

  • OS: [Windows 10]
  • Version [22H2]

Use external language file for GUI

Is your feature request related to a problem? Please describe.

Modify source code to use external text language file (editable).

In this way translator can create/modify/test translation without waiting an app rebuild.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

[Feature request]: Support regular glfw3

Hello,
I packaged ImPlay for openSUSE Linux and out of security concerns it's generally considered good practice to rely on distro-supplied shared libraries.
Now fmt, json and nfd are straight replacements, but the glfw3 supplied by ImPlay is patched: is there a way to separate those additional functions from the library so that the app could use the regular library?

intermittent frame drops

Describe the bug
Intermittent frame-drops would happen when rendering OSD.

To Reproduce
Steps to reproduce the behavior:

  1. Run mpv and load any file.
  2. Toggle stat.

Expected behavior
No frame drops.

Screenshots

Environment (please complete the following information):

  • OS: [Windows 10 Pro]
  • Version [22H2]

Additional context
N/A

Player window stutters when moved

When the main window is moved around on the desktop, the "framerate" of the window itself seems lower that any other program, even without being playing anything at all (no open files), other mpv players don't do that, and I don't remember other windows program doing this either (maybe some OpenGL ones that update rarely)

To Reproduce
just run the player and click grab the window and move it around

Expected behavior
smooth window moving like any other program

Environment (please complete the following information):
Windows 11 (21H2)

Additional context
I'm guessing is related to the ability to move the window by clicking anywhere, but other MPV players don't have this issue

[Question] GLFW Wayland Support

After 9a09f57, self-compiled ImPlay started to throw Wayland error spams like this:

GLFW [65544]: Wayland: Window position retrieval not supported

A quick searchthrough led me here:
WerWolv/ImHex#30

It seems that you changed USE_PATCHED_GLFW and started to use upstream library directly, thus leading this issue. I'm not a cpp expert, but may that be somehow related to differences between your upstream and your patched version of GLFW?


Update:
Manually enabling patched GLFW with -DUSE_PATCHED_GLFW=ON seems fine.

OS: Archlinux, Plasma(Wayland)

25276Can not operate Implay.exe

Memory cannot be reported by error, and the program seems to rely on C ++ 6.0 libraries. This construction method is a bit unable to keep up with the times! Look at the next edition, restore it; thank you!

Autofit not working

Describe the bug
I specified autofit in my config but it was not reflected on the player. When opening the player, the player size same as the default. It is supposed to already be changed here like mpv. When loading a video, it also behaved the same. It ignored autofit-larger.

To Reproduce
Steps to reproduce the behavior:

  1. Add these lines to mpv.conf.
autofit-larger=75% # Set max window size.  height/width
autofit-smaller=858x480 # Set min window size.
  1. Open the player. See the size not changing.
  2. Load any video. See video size not changing automatically.

Expected behavior
The player follows autofit-larger and autofit-smaller like mpv. That means when loading video, the player has to be at least larger than 848x480 and cannot exceed the window width 75% of the screen size while keeping the aspect ratio.

Screenshots
If applicable, add screenshots to help explain your problem.
image
image

Environment (please complete the following information):

  • OS: Windows 10 Home
  • Version: 22H2

Auto detect interface theme

Is your feature request related to a problem? Please describe.
Automatically set interface theme based on system preference.

Describe the solution you'd like
If system theme is dark, then interface theme should be dark and vice versa.

Describe alternatives you've considered
None.

Additional context
None.

Single instance mode

Is your feature request related to a problem? Please describe.
When I already have a video open, if I open another video, the new video opens up a new ImPlay window, so I get 2 videos playing at the same time.

Describe the solution you'd like
Opening other videos while already having a video open should open in same player window.

Describe alternatives you've considered
Other players like MPV-Net or PotPlayer or KMPlayer offer this option.

Full screen windows minimizes when mouse click on another monitor

Is your feature request related to a problem? Please describe.
In a multi-monitor setup (OS: Windows 10 21H2), ImPlay's windowed full screen minimizes when mouse is clicked on another monitor. This behavior is a bit inconvenient and different from MPV's.

Describe the solution you'd like
According to glfw/glfw#447, fullscreen can remain maximized when it loses focus by setting the Window Attribute glfwWindowHint(GLFW_AUTO_ICONIFY, GL_FALSE)
The attribute conflicts with the ontop function at windowed mode, so it should only be enabled for fullscreen.

Describe alternatives you've considered
I attempted implementing a fix TauZolver@a970575 that works for my Windows PC, but I do not have machines to test if works for MacOS and Linux platforms.

Additional context
Thanks for the amazing work! ImPlay gives motivation for one to want to drop PotPlayer for good.

Space button to play last video when on idle screen

Is your feature request related to a problem? Please describe.
This is my favorite feature from mpv.net, please add!

Describe the solution you'd like
Space button to play last video when on idle screen

Describe alternatives you've considered
None.

Additional context
None.

Cannot add external subtitles by dragging and dropping

Describe the bug
When dragging in subtitles to a video being played, ImPlay treats the subtitle file as a new video and then tries to play it, with the apparent result that it does not play.

Expected behavior
A subtitle track has been added to the video.

Environment (please complete the following information):

  • OS: Windows 10
  • Version 22H2
  • ImPlay 1.1.1

mouse_leave keybind

Is your feature request related to a problem? Please describe.
Lua scripts such as osc.lua use it.
Hover on the vanilla osc's timeline at the bottom, then off the window. The timeline should hide.

Describe the solution you'd like
mouse_leave and other related keybinds are fired.

Describe alternatives you've considered
No alternatives.

Moon to choose video quality choice

Hello, ImPlay is amazing, the only thing missing is a quick option in the GUI to choose the youtube video quality for example, moonpalyer made by coslyk is also based on mpv and yt-dlp and displays a window when copying and pasting a url address of video streaming so that we can choose the desired video quality, we hope that our beloved ImPlayer will do the same thing soon!

we hope also that ImPlay has integrated automatic updater of yt-dlp, because ImPlay doesn't use the last version of yt-dlp, ImPlay use yt-dlp of 17/02/2023...

https://github.com/coslyk/moonplayer

https://coslyk.github.io/moonplayer.html

libmpv renderer backend

libmpv provides OpenGL renderer API only, but it does not perform best on all platforms:

  • OpenGL is slower than D3D11 on Windows
  • Apple deprecates OpenGL on macOS
  • Does not support gpu-next yet: mpv-player/mpv#10810

Upstream feature requests: D3D11, Vulkan

Luckily, we can use translation layer like ANGLE, which may translate OpenGL ES API calls to a faster hardware-supported APIs to improve performance. Also, ANGLE makes ImPlay work on Virtual Machines that doesn't have a OpenGL 3 driver (example: HyperV vm has D3D driver only). The downside is, it may break HDR: mpv-player/mpv#8530

I've implemented OpenGL ES 2.0 support on the latest main branch, and it's now built in actions (tested the windows version).

NOTE: EGL and GLESv2 dynamic libraries is required to run the GLES2 version of ImPlay, but not needed at build time.

Bluray/DVD menu support

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

AppImage requires libOpenGL.so.0 to run.

The AppImage requires libOpenGL.so.0. Although the problem can be solved by running sudo apt install libopengl0, but i was thinking that if it was possible to make it in a way so that the libOpenGL.so.0 library isn't required anymore, then the AppImage would be totally self-contained.

Sorry if this doesn't make any sense, English isn't my first language.

Instructions for building?

Sorry, but I can't seems to grasp how do you really build your project from source. Is this really for Ubuntu only? I'm on EndeavorOS, Arch-based if that matters. Any directions, please? Thanks in advance!

Huge menu for Mac OS

Describe the bug
The context menu of Mac ver. is much huge.

To Reproduce

Run Implay and open the menu.

Expected behavior
The reasonable rendering size。

Screenshots

截屏2023-02-10 14 30 25

Environment (please complete the following information):

  • OS: [Mac]
  • Version [13.2]

Additional context
N/A

auto update ImPlay

is there a feature to automatically update ImPlay Portable to the latest version on Windows?

Publish on Flathub

Currently, ImPlay is available on Linux for Debian-based distros and as AppImage. It would be good if it's available as flatpak on Flathub, the most popular and recommended "cross-distro" way to publish software for Linux.

Settings - Move Settings menu from Help submenu to main window

Is your feature request related to a problem? Please describe.

I believe that is more common and useful to have "Settings" menu in main menu instead like now under "Hep" menu.

Describe the solution you'd like

Move "Settings" menu from "Help" submenu to main menu.

Describe alternatives you've considered

Additional context

window10下鼠标不隐藏

Describe the bug
window10下鼠标不隐藏

To Reproduce
windows10 工作站新版
同样环境mpv还是正常2秒后隐藏

Expected behavior
like mpv

Screenshots
none

Environment (please complete the following information):
win10 22H2 workstation

Additional context
none

Unclickable osc

Describe the bug
OSC is not clickable.

To Reproduce
Steps to reproduce the behavior:
Load a video and try to click any button on OSC.

Expected behavior
Any button should work as user's expectations.

Screenshots
N/A

Environment (please complete the following information):

  • OS: [e.g. Mac OS]
  • Version [e.g. 13.2]

Additional context
N/A

No border and maximised windows issues

你好,我下载了最新版的implay,并在mpv.conf里写入no-border和border=0,但打开软件依旧会有border;另外,我想一打开视频,就默认显示最大化窗口,请问怎么操作呢?谢谢

implay theme for prgress bar

Is your feature request related to a problem? Please describe.
image
the progress bar is ugly. Please make it like the one shown in the readme.md file

Describe the solution you'd like
Please make the progress bar like the one shown in the readme.md file

Describe alternatives you've considered
nope

Additional context
Add any other context or screenshots about the feature request here.

Choose video and audio quality

Hello, thank you very much for this amazing awesome palyer ! 💯 🥇

Please I have request: videos in youtube and dailymotion and facebbok watch have many quality resolutions, and sometimes our notebook is weak and its graphics card weak or there are many spots, so it will be great to add button in the main interace to choose the video quality worst 144p, or standard video 360p or HD video 720p or 4K...and also choose to playback only the audio streams contained in the youtube video dash in order to save battery and the screen will be off when we sleep while we listen podcast in youtube and it's also useful when listening to the video in the background...thanks a lot !

--fs argument from command line not working properly on Windows

When running ImPlay.exe with mpv arguments from PowerShell, using the --fs argument to playback video in full screen results in the video not expanding to the full screen size. Exiting and coming back to full screen manually allows the video to expand to the full resolution of the monitor. This behavior isn't present on the latest build of mpv and it works as it intended there.

To reproduce:

  1. Open PowerShell.
  2. cd "C:\Program Files\ImPlay"
  3. .\ImPlay.exe av://dshow:video="Integrated Camera" --fs

Windows 11 22621

No Player resize (Static player size)

Is your feature request related to a problem? Please describe.
I open different video files of different resolutions. Concrete example: 1 video at 1080p and 1 video at 2160p
When opening the 1080p file, the window opens up in 1080p. If I open up the video at 2160p, the player window is much larger, occupying the entire screen. Player window should retain the 1080p size when opening 2160p video files (also for smaller sizes).

Describe the solution you'd like
Opening videos will always maintain the set values for the window, like for example setting the window size to 1920x1080 will open any video with the window size of 1920x1080p, regardless if the video is larger or smaller.

Describe alternatives you've considered
Other video players like MPV-Net has this. Also PotPlayer or KMPlayer.

Additional context
If this is possible to do, it is not clear in the documentation and information should be made available on how to implement it.

Keyboard shortcut to play automatically streaming link from clipboard

Hello, I often copy and paste streaming links and I find that using a keyboard shortcut allows us to open and play the links more faster, it will be great to add a shortcut "paste and play link from the clipboard" for example ctrl+v to play automatically the url adress of streaming links , to clarifiy I'm not just talking about paste links but about paste and alos playback and play automatically the links when using a keyboard shortcut ! Thank you very much !!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.