Code Monkey home page Code Monkey logo

Comments (5)

Tschipcraft avatar Tschipcraft commented on July 29, 2024 2

Thanks <3

An option to turn off dynamic lights on a player to player basis is sadly not possible, because the light block used by this data pack is considered a placed light source by the game (the same as e.g. a placed torch). If the player that has it disabled is alone, this may work, until a player that has it enabled is near. Then, both players will see the light emitting from the player that enabled it.

Turning off certain items is possible, but really not user-friendly, since the item displayed by item entities and item frames sadly can't be compared to an item tag list like everything else. I may add a tutorial for this in the wiki at some point.

The enchanted item glow uses a different approach though, and I'm planning on adding options for this as well as for other glowing effects that may not be wanted by all players.

Edit: Options to configure light sources have been implemented as of v1.6. Additionally, turning off certain items is now easier, as I found a way to compare the item displayed by item entities and item frames to the tag lists. A tutorial can be found in the wiki.

from dynamiclights.

Tschipcraft avatar Tschipcraft commented on July 29, 2024 1

Since I wasn't able to add more options and won't be for the next month due to my finals, here is a manual way to disable the glow on enchanted items:

  1. Unzip the data pack
  2. In \data\dynamiclights\predicates\soul_light.json, remove , { "condition": "minecraft:entity_properties", "entity": "this", "predicate": { "equipment": { "mainhand": { "count": { "min": 1 }, "enchantments": [ { "enchantment": "minecraft:fire_aspect", "levels": { "min": 1 } } ] } } } }, { "condition": "minecraft:entity_properties", "entity": "this", "predicate": { "equipment": { "offhand": { "count": { "min": 1 }, "enchantments": [ { "enchantment": "minecraft:fire_aspect", "levels": { "min": 1 } } ] } } } }
  3. In \data\dynamiclights\predicates\redstone_light.json, remove , { "condition": "minecraft:entity_properties", "entity": "this", "predicate": { "equipment": { "mainhand": { "count": { "min": 1 }, "enchantments": [ { "levels": { "min": 1 } } ] } } } }, { "condition": "minecraft:entity_properties", "entity": "this", "predicate": { "equipment": { "offhand": { "count": { "min": 1 }, "enchantments": [ { "levels": { "min": 1 } } ] } } } }, { "condition": "minecraft:entity_properties", "entity": "this", "predicate": { "equipment": { "head": { "count": { "min": 1 }, "enchantments": [ { "levels": { "min": 1 } } ] } } } }, { "condition": "minecraft:entity_properties", "entity": "this", "predicate": { "equipment": { "chest": { "count": { "min": 1 }, "enchantments": [ { "levels": { "min": 1 } } ] } } } }, { "condition": "minecraft:entity_properties", "entity": "this", "predicate": { "equipment": { "legs": { "count": { "min": 1 }, "enchantments": [ { "levels": { "min": 1 } } ] } } } }, { "condition": "minecraft:entity_properties", "entity": "this", "predicate": { "equipment": { "feet": { "count": { "min": 1 }, "enchantments": [ { "levels": { "min": 1 } } ] } } } }
  4. In \data\dynamiclights\functions\sources\item.mcfunction, remove execute as @s[nbt={Item:{tag:{Enchantments:[{}]}}}] if predicate dynamiclights:visible run function dynamiclights:summon_redstone_light
  5. Rezip the data pack if needed

Sorry for taking my sweet time on this, I wanted to implement options for it, got stressed with exams and forgot about it (Got reminded by the E-mail notification I got from your new issue)

from dynamiclights.

onebeastchris avatar onebeastchris commented on July 29, 2024

tysm for your detailed reply! Even a manual way as you described would help, as one can safely assume that this isn't something people would change frequently.

from dynamiclights.

onebeastchris avatar onebeastchris commented on July 29, 2024

Thanks for the guide, just used it & works excellent!

One sidenote - I think that feature effectively reduces the efficiency of hostile mob farms, as in new versions mobs only spawn in light level 0 (which isn't present once a mob has enchanted armor)

from dynamiclights.

Tschipcraft avatar Tschipcraft commented on July 29, 2024

I see, that could become a problem. I'll add that to the settings description when I implement them.

from dynamiclights.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.