tridentsdk / trident Goto Github PK

This week:

Concurrent thread buffers?

• https://github.com/netty/netty/pull/2284/files#diff-9948717743e8f1f0be6f5a7d40fc5a35L21
• https://blogs.oracle.com/jonthecollector/entry/the_real_thing

Producer/Consumer tuned queues?

• https://github.com/JCTools/JCTools/tree/master/jctools-core/src/main/java/org/jctools/queues

Lazy sets?

• http://psy-lob-saw.blogspot.de/2012/12/atomiclazyset-is-performance-win-for.html
• http://mechanical-sympathy.blogspot.co.uk/2011/09/single-writer-principle.html

NIO.2 net handlers?

• http://rox-xmlrpc.sourceforge.net/niotut/
• http://www.ibm.com/developerworks/library/j-nio2-1/

Optimizations?

• https://dev.bukkit.org/bukkit-plugins/nolagg/
• https://dev.bukkit.org/bukkit-plugins/ptweaks-remove-all-server-lag/
• https://dev.bukkit.org/bukkit-plugins/clearlagg/
• https://github.com/PaperMC/Paper
• https://www.spigotmc.org/wiki/about-spigot/

Atomic field updaters?

• http://normanmaurer.me/blog/2013/10/28/Lesser-known-concurrent-classes-Part-1/

Perhaps packets and housekeeping for entities should be kept within a specified range in order to prevent mobs that cannot be seen or that are irrelevant from taking up bandwidth and tick cycles.

Probably some race condition. A player sometimes appears 2-3 blocks below where they should be.

Slots are basically items or stacks of items that hold metadata and are sent over the network (or vice versa) to communicated item data.

Usage:

• Trident/src/main/java/net/tridentsdk/server/net/EntityMetadata.java

  Line 76 in bbb3b16

  // TODO - slots

• Trident/src/main/java/net/tridentsdk/server/net/EntityMetadata.java

  Line 152 in bbb3b16

  // TODO - slots

Configs currently cannot hold comments or integer values (they can only be floating point or double for whatever reason).

Remove the branches that haven't been updated in like 2 months

Lots and lots of work needed here.

• Check threading performance. Contention is a prime slowdown with the use of atomic variables.
• Check the failures that occur with typical generator
• Implement palette index increments for large block varieties
• Check overworld skylight
• Correctly implement atomic byte arrays

Not really an issue, but I didn't know where I had to ask this.

Does this project has an IRC channel where developers can discuss, and Server owners ask questions/suggest things. If not, I can create one if you guys want.

In the future, I assume you will be using some sort of Pathfinding and/or Navigation system. I suggest that you implement a way to either implement or extend a generic Pathfinder class that you can use to create your own Pathfinder logic, then allow the use of an API to give mobs said Pathfinders. Some mock psuedocode is something along the lines of having the Entity contain a Pathfinding/Navigation manager, lets call this a 'Navigator', then calling something like Entity#getNavigatior(), which would then lead to something like Navigator#addPathfinder(), passing in the Pathfinder.
Just a suggestion ;)

As we continue development, this is just a landmark issue for implementing more of the packets in the protocol.

This is the todo list of what still needs to be done for the revamp of TridentSDK, once you start working on one of them, please create a new issue and reference it here.

• World Interactions
  • Player Interactions
  • Block Interactions
• HUD
  • Scoreboard
  • Tablist
  • Chat (TridentSDK/TridentSDK#57 & #53)
  • Titles & Subtitles
  • Boss Bar
• Plugin Engine
  • Plugin Loading
  • Events
  • Commands
• Inventory Menu
  • Chests, Furnaces, etc
• Physics
  • Redstone
  • Gravity
  • Collisions
• Entities
  • Tile Entities
  • Mobs
  • Items

Boss bars are currently being implemented by @nickrobson

We need to go over the API and the implementation details here.

Some/several TODO items are found in the linked file:

• https://github.com/TridentSDK/Trident/blob/bbb3b16a2f014880836391504061e9e786e5e6b6/src/main/java/net/tridentsdk/server/ui/bossbar/DefaultBossBar.java

This is going to be tricky, we can examine the MC server source code and write something extremely similar so that a world would generate the same given the same seed on our server and mojangs, or examine their source to produce a slightly similar implementation that would produce almost indistinguishable worlds. The other option is to create our own world generator that looks only vaguely similar to the official maps and allow users to add their own Maps if they want the real worlds.

Bukkit plugin support
Lite and pro version
Boss Bar Native
World Edit native
Essentials native

Notable examples to implement:

• stop
• kick
• teleport
• say
• help

Enhance the current implementation of sending players chunks.

fc72bf8

Vilsol:
you started crypto before there was crypto

See TridentPlayer#resetTitle()

Titles cannot be fully reset, the subtitle is a remnant artifact even after using the PlayOutTitle#Reset packet. Therefore, 3 packets are sent instead, each to set all the fields to empty/default values.

if (location.getWorld().getName().equals(this.getName()))
throw new IllegalArgumentException("Provided location does not have the same world!");

This will run if the worlds are the same, please change to:

if (!location.getWorld().getName().equals(this.getName()))
throw new IllegalArgumentException("Provided location does not have the same world!");

Make block updates happen in a way similar to MC server, i.e. one block being updated gives all the blocks around it a chance to execute updates, and it propogates like this. Possibly our own implementation that does block updates randomly so that sand will fall etc. Configurable.

Currently players cannot sprint or crouch properly.

Implement and create an API for handling plugin channels that may be created or used by client plugins.

No SDK issue as of yet.

Also need to develop the plugin/command/event API implementations.

Since chat is considered a HUD element, should it belong in that package rather than its own standalone?

The Minecraft client seems to not respond to PlayOutPosLook with a teleportation confirm. We use this to resume login, and that doesn't happen sometimes.

Usually occurs when starting the server after a while without using it. Can be fixed by restarting the server, but whether or not it happens again is random.

I suspect an error is occurring, but since netty swallows a lot of exceptions, I really don't have any clue. On a side note, the client doesn't seem to be disconnected when the a matching teleportation confirm packet is not sent within 30 seconds, so more testing is needed here.

Implement a high-performance, thread-safe Event framework.

See TridentSDK/TridentSDK#65.

Netty seems to have a thing with hiding errors thrown in packet handling classes such as NullPointerExceptions and the like. Unfortunately errors like these are difficult to trace and cause a lot of dumb behavior that should be spotted.

Not sure if this is an issue with exceptionCaught not being implemented in the initialized channel handlers?

I tried to build and start a server but it's not working, nothing is displayed and the processes never ends until we kill it.

Can the server run yet, or are you just doing basic framework? When I compile with maven, it doesn't run. Thanks

Add the ability for players to place blocks and have them stored in the chunk.

Implement the ability to save and load worlds to the world folder.

Create and implement packet classes for updates to the world options. Also add notifications and packet sending for those particular setting updates to the players on the given world (we missed this the last time).

See:

Create a lookup class that would convert an ID to a message, and provide a link in the error message to the website explaining the error and some usual scenarios.

Upon joining, leaving, and then rejoining the server, the server does not send an extra AddPlayer packet for the tablist. This results in the player losing his skin and not having an updated tablist.

We need a way to have chunks be unloaded when they are not used by any entity or player. Upon disconnect, the chunks loaded by a player must be released.

We can do this a multitude of ways, some of which are:

• Manual release
• Weak references
• More?

Please check or at least make a decent attempt at ensuring the classes that are used in a multithreaded context have the proper initialization safety and access safety for accessors that are given to plugins for modification.

Clients running an older version of the game are not kicked from the server, but rather disconnect with a decoding error.

The heightmap needs to be updated after setting blocks in TridentChunk. Perhaps this number should be calculated rather than cached and updated every block update.