Error while running `translations:sync`: ArgumentError: comparison of Pathname with String failed about rails HOT 3 CLOSED

Hi @11mdlow,

Thank you for finding this issue and for the pull request!

My guess is that Pathnames should not be part of I18n.load_path. It seems to be an issue caused by https://github.com/dry-rb/dry-validation because I found another application having a similar problem: AlchemyCMS/alchemy_cms#1464

Maybe they fixed it in newer releases?

However, since it's a small fix that can avoid similar issues, I fixed it here: ed70149

It's the same approach as your pull request but I applied to_s higher in the stack. I also applied a uniq since you said that you noticed 2 similar paths in your project. Better be safe 😄

Could you please try using the master branch in your project and confirm that it works?

If so, I'll release a new version.

from rails.

Hi @MichaelHoste, thanks for the quick response. That seems to have fixed it!

FWIW I suspect rails/i18n is doing something weird during app initialization when it sees a .yml file, because in both instances there is a direct reference to the file in the code. In dry-validation it's here: https://github.com/dry-rb/dry-validation/blob/e740dd270aa386163eda394d62546464903b690c/lib/dry/validation/constants.rb#L19. I think I18n allows Pathname objects, which is probably why it's never been addressed in that gem.

Anyways, thanks for the quick fix!

from rails.

Thank you for your feedback!

Since it seems to work, I released version 1.23 of the gem.

It's not clear from the I18n API if I18n.load_path accepts anything other than a String.
In doubt, using to_s is certainly a best practice when using it 😄

from rails.