Comments (3)
I tend to agree with you that it's not great to add methods to Object
, and we're not proud of it. But it simplifies the localisation process and makes it work regardless of the context, and we like that.
So I would consider to add a disable_object_monkey_patching
option and add a section in the docs to explain it, but I would not agree to make it the default behaviour.
Would it work for you?
Are you willing to create a pull request? I would be able to do it but not before a week or two.
from rails.
i suggested making it a new default only in a new major release because I understand that it would break a lot of (probably all) application. For the moment, having an option to opt-out of monkey patching is already a good step forward.
I'm definitely not comfortable enough with the codebase for making a PR, I just happened to inherit an app using _(...)
everywhere and I when I found out how this voodoo trick was performed I decided to share my opinion with you :)
I'm not in any urgency for a fix neither, I have other , larger, problems to fix in that inherited codebase :)
from rails.
I added the option and documented it, a new gem version will be created tomorrow:
Thank you for the suggestion! :-)
from rails.
Related Issues (20)
- Gettext translations cached after switching locale? HOT 4
- Special characters in translation HOT 2
- Isn't it possible to only use gettext? HOT 2
- Deprecation warning for #has_rdoc (Rubygems) HOT 2
- Empty hash in localization.en.yml
- Strings not get synced
- Unclear how to use custom locales in project HOT 5
- Crash on "rake translation:init" HOT 3
- getText method not translating text as supposed to after install and intialization HOT 7
- Deprecation warning on Rails 6 HOT 4
- Need a suggestion on how to keep the source pluralization clean HOT 2
- Error while running `translations:sync`: ArgumentError: comparison of Pathname with String failed HOT 3
- When disabling gettext in the initialiser gettext directory and files are still created HOT 3
- gettext strings missing after use of case statement in erb HOT 20
- A way to exclude translation keys HOT 3
- Ruby 3.1 compatibility (Psych 4 breaking change) HOT 7
- Match I18n fallbacks in GetText HOT 2
- ignore specific files HOT 4
- Error when starting Pushion Passenger HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rails.