Code Monkey home page Code Monkey logo

Comments (2)

Bit-Rot avatar Bit-Rot commented on August 21, 2024

Gave it a quick look just now. I've pasted some relevant code below.

To summarize, when an ability ends, we call TaskOwnerEnded() on each active task. TaskOwnerEnded() is basically the same logic as EndTask() - both call OnDestroy, but one passes in a value of true, the other false. The base definition of OnDestroy doesn't use this boolean at all (presumably it's for children to use) - and since there's nothing that stands out to me in WaitTargetData's OnDestroy definition, I think @y4ure is correct here, and that WaitTargetData is ending just like any other ability on gameplay ability end.

GameplayAbility.cpp:633 (EndTask())

		// Tell all our tasks that we are finished and they should cleanup
		for (int32 TaskIdx = ActiveTasks.Num() - 1; TaskIdx >= 0 && ActiveTasks.Num() > 0; --TaskIdx)
		{
			UGameplayTask* Task = ActiveTasks[TaskIdx];
			if (Task)
			{
				Task->TaskOwnerEnded();
			}
		}

GameplayTask.cpp:140 (TaskOwnerEnded())

void UGameplayTask::TaskOwnerEnded()
{
	UE_VLOG(GetGameplayTasksComponent(), LogGameplayTasks, Verbose
		, TEXT("%s TaskOwnerEnded called, current State: %s")
		, *GetName(), *GetTaskStateName());

	if (TaskState != EGameplayTaskState::Finished)
	{
		bOwnerFinished = true;
		if (IsPendingKill() == false)
		{
			OnDestroy(true);
		}
		else
		{
			// mark as finished, just to be on the safe side 
			TaskState = EGameplayTaskState::Finished;
		}
	}
}

GameplayTask.cpp:161 (EndTask())

void UGameplayTask::EndTask()
{
	UE_VLOG(GetGameplayTasksComponent(), LogGameplayTasks, Verbose
		, TEXT("%s EndTask called, current State: %s")
		, *GetName(), *GetTaskStateName());

	if (TaskState != EGameplayTaskState::Finished)
	{
		if (IsPendingKill() == false)
		{
			OnDestroy(false);
		}
		else
		{
			// mark as finished, just to be on the safe side 
			TaskState = EGameplayTaskState::Finished;
		}
	}
}

GameplayTask:202 (OnDestroy())

void UGameplayTask::OnDestroy(bool bInOwnerFinished)
{
	ensure(TaskState != EGameplayTaskState::Finished && !IsPendingKill());
	TaskState = EGameplayTaskState::Finished;

	if (UGameplayTasksComponent* TasksPtr = TasksComponent.Get())
	{
		TasksPtr->OnGameplayTaskDeactivated(*this);
	}

	MarkPendingKill();
}

from gasdocumentation.

tranek avatar tranek commented on August 21, 2024

Looks like you guys are correct that this is no longer the case. When I first built this project, the Meteor ability's WaitTargetData AbilityTask would not end when the player was stunned and the solution was to manually end the task on ability end. That no longer seems to be the case. I have updated the project and the README to reflect this.

Thank you two for bringing this up and checking the source!

from gasdocumentation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.