FSET transforms field names to lowercase about tile38 HOT 7 CLOSED

Good catch. Can confirm. 👍

from tile38.

Thanks for looking into this @iwpnd. After looking around a bit more, I am now certain that this issue has deeper roots than I originally anticipated.

Apart from FSET, this issue is also present in NEARBY's WHEREIN. I assume the reason is this function's use of ToLower:

To reproduce:
SET user 1 FIELD TEST 123 POINT 90 90
NEARBY user POINT 90 90 -> Observe the key is found
NEARBY user WHEREIN TEST 1 123 POINT 90 90 -> Observe the key is not found

SET user 2 FIELD test 123 POINT 90 90
NEARBY user WHEREIN TEST 1 123 POINT 90 90 -> Observe the key is found, even though the search term is uppercase while the key's field name is lowercase

The WHERE search option does work correctly. To confirm:
NEARBY user WHERE TEST 123 123 POINT 90 90 -> Observe the correct key (user 1) is found
NEARBY user WHERE test 123 123 POINT 90 90 -> Observe the correct key (user 2) is found

This is related to issue #704. The fixes for both FSET and WHEREIN may be a breaking change for systems that have not noticed this bug, though I still do believe ironing it out is the way to go as the current behavior is inconsistent.

from tile38.

Can also confirm. Let's see whats going on with wherein 👀

update:
yes, whereins are appended with strings.ToLower(name) too, here.

Can I address this @tidwall? It doesn't appear to be intended, considering you can set a field in just about any case. Also this would align the behaviour of WHEREIN and WHERE.

from tile38.

@iwpnd yes please take a look. I don’t recall this being the intended behavior.

from tile38.

#742 and #743 should resolve this now @tidwall

from tile38.

Ok, I'll review asap.

from tile38.

Fixed and merged!
@unendingblue Thanks for reporting!
@iwpnd Thanks for fixing!

from tile38.