Code Monkey home page Code Monkey logo

Comments (6)

Kilowhisky avatar Kilowhisky commented on July 2, 2024

Actually, re-reading the docs... it looks like websockets aren't designed for multiple messages...

I'll refactor to make use of standard HTTP calls I guess...

EDIT: Great, now chrome wants CORS headers to be present....

from tile38.

Kilowhisky avatar Kilowhisky commented on July 2, 2024

So for this app I either need HTTP interface to support CORS or WebSockets to support a two way connection.

Both will require a PR...

What do you think? I can make them.

from tile38.

tidwall avatar tidwall commented on July 2, 2024

I haven't had the chance to take a deep dive into your PR yet. Preflighting seems reasonable, though I wondering about the security ramifications of using Access-Control-Allow-Origin: * by default for directly connecting to a Tile38 instance, particularly from a web browser.

from tile38.

Kilowhisky avatar Kilowhisky commented on July 2, 2024

Web browsers are the only http clients that adhere to CORS (and require it). Because of that I assumed that it just wasn't being used in browsers before since it wouldn't have worked anyways.

The * is a little more lax than I would have liked but building in a whole array of allowed origins would have been quite the work and also only benefited future use cases.

I just figured if it came up in the future, it could be added then. KISS and all that.

from tile38.

Kilowhisky avatar Kilowhisky commented on July 2, 2024

Also, web sockets don't follow CORS so any web browser could already open a socket request to tile38. It's inefficient as hell, but it works.

from tile38.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.