swaprhq / swapr-dapp Goto Github PK

navigation items out of view on mobile

Originally posted by @zamli in #56 (comment)

This mobile navigation issue needs a custom solution.

i propose we do something like this.
https://www.figma.com/proto/L8tamoiv3mTCRaypHLk1us/DXswap?node-id=369%3A688&viewport=1011%2C523%2C1&scaling=min-zoom

we hide the rest of the navigation item and only show swap and pool.

It usually works on Uniswap (but I wouldn't say always) so it must be doing something that is quite difficult.
Only if i choose "Add Liquidity" then manually choose the pair i want, can I see the Liquidity that i have already provided
and then this brings to next problem!

How to Remove Liquidity - have you guys tried that?

I have to:

Take this URL: https://gateway.pinata.cloud/ipfs/QmbkoS133ksbh9uv8ahsZePFKyZnqVLPUtFHxJnQQbHxNS/#/add/ETH/0x022E292b44B5a146F2e8ee36Ff44D3dd863C915c

replace "add" with "remove"

go to that URL
https://gateway.pinata.cloud/ipfs/QmbkoS133ksbh9uv8ahsZePFKyZnqVLPUtFHxJnQQbHxNS/#/remove/ETH/0x022E292b44B5a146F2e8ee36Ff44D3dd863C915c

then I can process a "Remove Liquidity" txn

I have been known to do this on Uniswap too!

so it is not a DXswap specific problem

I believe that @Zett can fix this using Design

Just created the CHA and ANF pool and I cant see the option to manage it in the pools view https://rinkeby.etherscan.io/tx/0xfcf7d2881f58bda92d5fb7f2d9d1189957de5e049034714926ef5431c827b811

-even though i have pool token pairs when i refresh the page i can't see any pair i own
how to recreate a bug
1)Go to the pool where you own pairs

2)Refresh the page and they disappear!

There is some changes from the original Uniswap Navigation.
See attached screenshot and follow the Figma link for the specification(activate comments).

No wallet connected

Wallet connected

Settings Active

Figma Link

Navigation Figma Link

There is color difference on the swap box. Both the top and bottom part looks a bit different.

Make the main bg for swap box #101016 72% opacity

Bottom part: #101016 80% opacity

"view pair" button rounded corners 4px and color BG #3 for the border

• Remove list feature from Uniswap dapp
• Set up DXdao Token List
• Integrate token list with Uniswap SDK
• Update DXswap-dapp with token list

[x]- DXswap Scheme
[x] - DXswap Core
[x] - DXswap Periphery
[x] - Deploy Scripts

• DXswap Scheme 2.0 (with constraints)
• Relayer
• ERC20 Guild

"wich" should be "which"

But maybe even better would be rewording of "The number by which the swap fee is divided to get the protocol fee"

Limit this list to 8 tokens and add a scroll

The issue reported to Augusto via video,
keybase://chat/dx_dao#DXswap/3666

when adding 2nd Amount, 1st amount disappears

See attached screenshots and follow the Figma link for the specification(activate comments).

No wallet connected

Wallet connected

Pre Trade

Figma Link

Swap box Figma Link

Follow the guidelines of figma + the brand portal

https://www.figma.com/file/L8tamoiv3mTCRaypHLk1us/DXswap?node-id=101%3A7308
https://zeroheight.com/966ad5485/p/46c33a-dxswap-theme/b/9692cf

During "Add Liquidity" the extra information shows 0.3% which is incorrect.
This should be removed or dynamically filled in.

I am providing Liquidity to the pair ZEENUS-XEENUS, yet it does not show as a pair in my pools.

Link: https://gateway.pinata.cloud/ipfs/QmThpoPb2oLSevTH2sqw7wyHDJF1gXyvnoUCsjUsGEn8XF/#/pool

Pools:

Proof:

Augusto had some knowledge explain this.

Change colors and style after the Style guideline.

https://zeroheight.com/966ad5485/p/9700ce-dxswap-overview
https://www.figma.com/file/L8tamoiv3mTCRaypHLk1us/DXswap?node-id=48%3A5691

The DXdao will govern different parameters of DXswap, which can be changed through proposals on Alchemy. The following Connectors are needed to let members create and vote via Alchemy.

setSwapFee
Input: TokenPair (address), SwapFee (uint8)

setProtocolFee
Input: ProtocolFee (uint8)

See attached screenshot and follow the Figma link for the specification(activate comments).

No Pooled tokens

Pooled token

Pool card open

Figma Link

Pool Figma Link

I think it would be valuable to allow for much higher swap fees. Say 10% or 20%.
Keep optionality. There are a number of uses cases where high fees can make sense.

Did we remove this function to import a pool?
"Don't see a pool you joined? Import it."
If so, it is still in the hover note.

Note: Oren from DAOstack supporting on this

Always keep the swap box in the vertical center.

Notes: Roie and Oren from DAOstack supporting on this

Create pills as a reusable component.

follow specification on figma: https://www.figma.com/file/L8tamoiv3mTCRaypHLk1us/DXswap?node-id=431%3A598

Note: Oren from DAOstack supporting on this

Note: Nico and Oren working on this

[ ] - DXdao contracts / alchemy
[ ] - Multi-call scheme
[ ] - DXswap relayer
[ ] - DXswap core
[ ] - DXswap periphery
[ ] - DXswap SDK
[ ] - DXswap dapp

Note: Oren from DAOstack will support

Please check figma design for common bases and add the styling

https://www.figma.com/file/L8tamoiv3mTCRaypHLk1us/DXswap?node-id=452%3A853

See attached screenshot and follow the Figma link for the specification(activate comments).

Token picker open

Token picker Search

Figma Link

Token Picker Figma Link

Redesign the modals after figma design and theme

https://www.figma.com/file/L8tamoiv3mTCRaypHLk1us/DXswap?node-id=483%3A5086

I noticed there's a typo in 'Protocol Fee Denominator" tooltip - should be "which" instead of "wich".

I also noticed about half the tooltips end with a period, and about half don't. I know it's pretty insignificant, but we should probably be consistent with that. I suggest we end all tooltips with a period.

levelkdev/dxswap-core#22

"wich" -> "which"