Comments (1)
I think this might be outdated. The LP positions are shown only for tracked token pairs, i.e.:
- Those in which there's a base token (currently WETH, DAI, USDC and USDT)
- Those that are pinned (currently USDC/USDT, DAI/USDT and cDAI/cUSDT)
- User-saved pairs. This list is populated by the user when importing pools, and saved in the browser's local storage (so it is by no means permanent)
The only doubt that I have looking at these screenshots, is why the SPN/CHA position is shown, but maybe at the time there was a different configuration in-code.
Looking at Uniswap, that's how it should work there too.
An improvement that I might suggest is automatically saving a pair in the third category in the bullet list above when a user adds liquidity or creates a new pair. I don't see it as particularly detrimental to performance, and it's for sure nice to let a user immediately see their positions when adding liquidity instead of manually adding them later. Much more straight-forward.
This is not intended to replace the import pool function, since if someone deletes the browser's localStorage
, they'd get right back to not seeing their "exotic" pools. But it's maybe an improvement.
What do you think? @zamli @skyminert @jpkcambridge
from swapr-dapp.
Related Issues (20)
- Error with 0x price estimation
- New link preview image for swapr URL
- Update the content and colors for bridge related info
- If active snapshot, add a red dot on Vote for a CTA
- Add shareable URLs
- Update the image for bridge successful
- useBlockByTimestamp unchecked number field throws error
- Disable Cypress in CI since its failing HOT 1
- Add Uniswap V3 BNB to ecorouter HOT 2
- Integrate BSC in Uniswap v3
- Fix Bridge fee and gas decimal places
- Updates to Swapr after DXdao dissolution
- Buying ETH on mainnet with Uniswap returns WETH instead HOT 1
- QuoteNotFound error when swapping with COWswap
- Connext disappears from bridge list
- Add default tokens on BSC
- Add Arbitrum to common and output token
- Add Stackly to Swapr
- New token list design
- Remove DXD from common tokens list
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swapr-dapp.