steinbergmedia / vst3_cmake Goto Github PK

I tried to build audiohost.exe on Windows10 64bit machine, but it failed due to LIBJACK_FOUND was not set.
My environment is Windows10 Professional, Version 1909, Build 18363.1316.

At first, I installed Jack using installer downloaded from here.
Then I executed the below cmake command in build directory,
but LIBJACK_FOUND was not set was shown despite of Jack libraries installed.

$ cmake -DSMTG_ENABLE_USE_OF_JACK=ON -DSMTG_JACK_SDK_PATH="C:\Program Files\JACK2" ..
...
-- Could NOT find LIBJACK (missing: LIBJACK_LIBRARY)
-- LIBJACK_FOUND is not set. If you need it, please install Jack Audio from http://www.jackaudio.org!
-- LIBJACK_FOUND is not set.
...

I found the reason was that wrong library path was set in SMTG_FindJack.cmake.

The above lines set LOCAL_JACK_LIB as "${SMTG_JACK_SDK_PATH}/lib/win64" on 64bit build,
but current Jack installer for windows try to install 64bit libraries to

• C:\Program Files\JACK2\lib

It also set LOCAL_JACK_LIB as ${SMTG_JACK_SDK_PATH}/lib/win32 on 32bit build,
but Jack installer for windows installs 32bit libraries to

• C:\Program FIles\JACK2\lib32 on 64bit windows machine (in my environment, and guessed from 64bit installer code)
• C:\Program Files\JACK2\lib on 32bit windows machine (guessed from 32bit installer code)

So finally I fixed this issue by replacing
set(LOCAL_JACK_LIB ${SMTG_JACK_SDK_PATH}/lib/win64) to
set(LOCAL_JACK_LIB "${SMTG_JACK_SDK_PATH}/lib").

Hi.

After upgraded to vstsdk370_30_07_2020_build_115, validator doesn't run after building plugin. This issue occurred on following environment:

• Windows 10 Home, Version 1903, Build 18362.959
• Linux, Fedora 32

I used git to upgrade vst3sdk.

cd vst3sdk
git pull --recurse-submodules

On cmake, SMTG_RUN_VST_VALIDATOR is turned on.

>cmake -LA
# ...
SMTG_RUN_VST_VALIDATOR:BOOL=ON

I'm using smtg_add_vst3plugin in my CMakeLists.txt. When I removed first if(TARGET validator) condition in smtg_run_vst_validator (link to code) as following, validator starts running again.

# In `modules/AddVST3Library.cmake`.

function(smtg_run_vst_validator target) # Line 9.
    # if(TARGET validator)
        add_dependencies(${target} validator)
        if(SMTG_WIN)
            set(TARGET_PATH $<TARGET_FILE:${target}>)
            add_custom_command(TARGET ${target} 
                POST_BUILD COMMAND 
                    $<TARGET_FILE:validator> 
                    "${TARGET_PATH}" 
                    WORKING_DIRECTORY "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}"
                )
        else()
            get_target_property(PLUGIN_PACKAGE_PATH ${target} SMTG_PLUGIN_PACKAGE_PATH)
            add_custom_command(TARGET ${target} 
                POST_BUILD COMMAND 
                    $<TARGET_FILE:validator> 
                    $<$<CONFIG:Debug>:${PLUGIN_PACKAGE_PATH}>
                    $<$<CONFIG:Release>:${PLUGIN_PACKAGE_PATH}> 
                    WORKING_DIRECTORY "${CMAKE_RUNTIME_OUTPUT_DIRECTORY}"
            )
        endif()
    # endif()
endfunction()

Hi.
After building a project, the final VST3 bundle is installed (creating a symlink) to the %USERPROFILE%\AppData\Local\Programs\Common\VST3\ folder on Windows 64bit.
But if that folder does not exist, the post-build fails.
Could the modules/SMTG_SetupVST3LibraryDefaultPath.cmake be modified so it creates the missing folders automatically?

Thanks.