Code Monkey home page Code Monkey logo

scriptor's Introduction

Pat Hallbick

they / them - née Patrick Emery

A data scientist and software engineer, experienced with web design and versed in systems development. Currently working on numerous video game mods and hobby projects related to streaming.

Not currently open to contract work.

scriptor's People

Contributors

cyberneticsquid avatar kasualix avatar kingalexey212 avatar ssblur avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

scriptor's Issues

[bug] spellbook recipe not working

Mod Version (e.g. Fabric 0.3.4):

What you expect to happen:
Being able to craft spellbooks

What actually happens:
no matter the configuration in the crafting table ( no matter if it's with a signed, unsigned or plain book) nothing happens
I was trying to make a copy of the magelight spell.
image

[bug] NPE and crash on the server related to using and identifying a book

Mod Version (e.g. Fabric 0.3.4): scriptor-0.3.4-forge.jar

What you expect to happen:
No errors from the mod

What actually happens:
There's a NPE on the server from the mod:

java.lang.NullPointerException: Cannot read field "key" because the return value of "com.ssblur.scriptor.helpers.DictionarySavedData.parseWord(String)" is null
        at TRANSFORMER/scriptor@0.3.4/com.ssblur.scriptor.helpers.DictionarySavedData.parse(DictionarySavedData.java:391)
        at TRANSFORMER/scriptor@0.3.4/com.ssblur.scriptor.item.Spellbook.m_7203_(Spellbook.java:72)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.world.item.ItemStack.m_41682_(ItemStack.java:266)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.level.ServerPlayerGameMode.m_6261_(ServerPlayerGameMode.java:286)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.network.ServerGamePacketListenerImpl.m_5760_(ServerGamePacketListenerImpl.java:1089)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.network.protocol.game.ServerboundUseItemPacket.m_5797_(ServerboundUseItemPacket.java:29)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.network.protocol.game.ServerboundUseItemPacket.m_5797_(ServerboundUseItemPacket.java:7)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.network.protocol.PacketUtils.m_131356_(PacketUtils.java:22)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.TickTask.run(TickTask.java:18)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.util.thread.BlockableEventLoop.m_6367_(BlockableEventLoop.java:157)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.util.thread.ReentrantBlockableEventLoop.m_6367_(ReentrantBlockableEventLoop.java:23)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m_6367_(MinecraftServer.java:763)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m_6367_(MinecraftServer.java:157)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.util.thread.BlockableEventLoop.m_7245_(BlockableEventLoop.java:131)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m_129961_(MinecraftServer.java:746)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m_7245_(MinecraftServer.java:740)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.util.thread.BlockableEventLoop.m_18701_(BlockableEventLoop.java:140)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m_130012_(MinecraftServer.java:726)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:658)
        at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:244)

The exception occurs when trying to use one of the found books. It occurs in 100% of the cases using the book.
It looks like an evolution of #17
It doesn't crash the server when using the book -- there's simply no effect.
But it does crash the server when I try to use the identify scroll on the book.
The crash log:
crash-2023-04-13_23.54.16-server.txt

Unable to join LAN server

Forge version: 49.0.19
Minecraft version: 1.20.4
The mod load fine on the host computer but anyone who tries to join the LAN gets this code.
Error code after attempt on joining.:
Internal Exception: io.netty.handler.codec.DecoderException: Not a compound tag: 168296449

All mods are the same, (The only mod on the server is this mod and its dependency) I have tried to reinstall the forge version, mods, and other recommendations from the internet that is related to this code. Nothing worked.

Log file
latest.log

[bug] Crashing on a dedicated server

Mod Version (e.g. Fabric 0.3.4): scriptor-0.4.2-forge.jar

What you expect to happen: No crash on dedicated server

What actually happens: The mod crashes the dedicated server on startup. Apparently it requests some client-side renderer-related stuff.

The crashlog is attached.

crash-2023-04-29_21.31.06-fml.txt

[bug] Scriptor

I get this error using scriptor for 1.19.2

[03:02:08] [Server thread/WARN]: ========================================================== [03:02:08] [Server thread/INFO]: <Zennx3> jahsdja [03:02:32] [Server thread/WARN]: ========================================================== [03:02:32] [Server thread/WARN]: The below error did NOT cause a crash, this is debug info! [03:02:32] [Server thread/ERROR]: Error: java.lang.NullPointerException: Cannot read field "gender" because the return value of "com.ssblur.scriptor.helpers.DictionarySavedData.parseWord(String)" is null at com.ssblur.scriptor.helpers.DictionarySavedData.parse(DictionarySavedData.java:403) ~[scriptor-0.4.5-fabric.jar:?] at com.ssblur.scriptor.events.SpellChatEvents.received(SpellChatEvents.java:25) ~[scriptor-0.4.5-fabric.jar:?] at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732) ~[?:?] at dev.architectury.event.EventFactory.invokeMethod(EventFactory.java:53) ~[architectury-6.5.85-fabric.jar:?] at dev.architectury.event.EventFactory$2.handleInvocation(EventFactory.java:81) ~[architectury-6.5.85-fabric.jar:?] at com.google.common.reflect.AbstractInvocationHandler.invoke(AbstractInvocationHandler.java:89) ~[guava-31.0.1-jre.jar:?] at jdk.proxy2.$Proxy174.received(Unknown Source) ~[?:?] at dev.architectury.event.fabric.EventHandlerImpl.lambda$registerCommon$25(EventHandlerImpl.java:93) ~[architectury-6.5.85-fabric.jar:?] at net.fabricmc.fabric.api.message.v1.ServerMessageEvents.lambda$static$0(ServerMessageEvents.java:46) ~[fabric-message-api-v1-5.0.7+93d8cb8290-b624de5b4dfd5388.jar:?] at net.minecraft.class_3324.handler$dck000$fabric-message-api-v1$onSendChatMessage(class_3324.java:8029) ~[server-intermediary.jar:?] at net.minecraft.class_3324.method_43673(class_3324.java) ~[server-intermediary.jar:?] at net.minecraft.class_3244.method_44155(class_3244.java:1444) ~[server-intermediary.jar:?] at net.minecraft.class_3244.method_45064(class_3244.java:1302) ~[server-intermediary.jar:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718) ~[?:?] at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?] at net.minecraft.class_3738.run(class_3738.java:18) ~[server-intermediary.jar:?] at net.minecraft.class_1255.method_18859(class_1255.java:157) ~[server-intermediary.jar:?] at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:776) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:159) ~[server-intermediary.jar:?] at net.minecraft.class_1255.method_16075(class_1255.java:131) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:758) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:752) ~[server-intermediary.jar:?] at net.minecraft.class_1255.method_5383(class_1255.java:116) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:736) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:669) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257) ~[server-intermediary.jar:?] at java.lang.Thread.run(Thread.java:840) [?:?]

Adding
scriptor_dictionary.zip

[bug] Spell Scrolls Appearing With Spellbook

Mod Version (e.g. Fabric 0.3.4): The latest version as of now, 0.3.5-FABRIC

What you expect to happen: Separate loot?
A brief description of what you think should happen. Basically, I imagine that identify scrolls should be relatively rare and that they don't spawn with every spellbook.

What actually happens: I always find an Identify Scroll alongside any Spell.
What actually happens, in detail. If you can, include steps here on how to reproduce the issue. Currently, in seemingly any chest I open, if there is a spellbook in it, there is also an identify scroll. As for how to reproduce the issue...IDK just load a world? I am using other mods, but I don't think any of them should be modifying loot tables, so I believe this problem lies in this mod.

[bug] Few bugs in 1.0.6

Mod Version (e.g. Fabric 0.3.4):

Minecraft 1.20.4
Fabric 0.15.3
Fabric API 0.91.3
Java 20.0.2
Scriptor 1.0.6

BUGS:

  1. Chalk sometimes don't render when placed on the ground. Though it gets fixed and renders after a restart, the issue still sometimes occurs when trying to place new ones.
    render

  2. This next issue occur when trying to interact with a failed, nested-like Chalk Circle. This was discovered by a friend during a LAN session earlier when he attempted to create a nested-like Chalk Circle similar to the picture below. When he tried to interact with it, the spell failed, resulting in a massive lag spike, bombarding sounds and huge amount of particles.
    lag
    particles

  3. In fabric, you can make the patchouli_book loot table load only if Patchouli is installed by adding fabric:load_conditions to the patchouli_book loot table. This ensures that the loot table will only load if Patchouli is installed in your game, thereby eliminating the error in the logs: [16:40:38] [Worker-ResourceReload-10/ERROR]: Couldn't parse element loot_tables:scriptor:patchouli_book - Unknown registry key in ResourceKey[minecraft:root / minecraft:item]: patchouli:guide_book. The advancement still works tho without the loot table being loaded when Patchouli is not installed.

{
  "type": "advancement_reward",
  "pools": [
    {
      "rolls": 1,
      "entries": [
        {
          "type": "item",
          "name": "patchouli:guide_book",
          "functions": [
            {
              "function": "set_nbt",
              "tag": "{\"patchouli:book\": \"scriptor:scriptor_guide\"}"
            }
          ]
        }
      ]
    }
  ],
  "fabric:load_conditions": [
    {
      "condition": "fabric:registry_contains",
      "values": [
        "patchouli:guide_book"
      ]
    }
  ]
}

[bug] enhancing weapon spells do not work

Mod Version (e.g. Fabric 0.3.4):
Forge 43.2.0

What you expect to happen:
The Sword or Bow is enchanted for any duration of time, with the aspect defined in the spellbook e.g. lightning in the case of the Charge weapon spell provided by the mod.

What actually happens:
The spell provided by the mod is to strong for a book as it simply fizzels out, however a self made spell that used fire as aspect would not exceed the book limit. That spell was still unable to enchant any item. An attemt with a simpler Lightning aspect has not been made. The game is modded. A list of the additional mods will be provided.

One may be able to reproduce the bug by using any spell book with the item/enchanting target on an item in the inventory.

Mod list:

Animal Feeding Trough ver 1.0.3+1.19.2-forge
AppleSkin ver 2.4.2+mc1.19
Architectury ver 6.3.69
ChickenChunks ver 2.9.4.97
CodeChicken Lib ver 4.3.0.470
Comforts ver 6.0.3+1.19.2
Create ver 0.5.0.h
Create Enchantment Industry ver 1.1.12
Create Ore Excavation ver 0.3.2
Create: Steam 'n Rails ver 1.19.2-1.1.1
Giacomo's bookshelves Mod ver 1.3.3
Just Enough Items ver 11.4.0.287
Map Atlases ver 3.0.1
Moonlight Library ver 1.19.2-2.1.14
Scriptor ver 0.3.5
Storage Drawers ver 11.1.2
Supplementaries ver 1.19.2-2.2.26
Terralith ver 1.0

scriptor_dictionary.zip

[bug] Rune visual invisible with shader

Version details:
Minecraft 1.20.1
Scriptor mod 0.6.6 for Fabric

I'm reasonably certain that this is just going to be closed as a "can't do anything about it" incompatibility issue but, the placed runes are invisible while using ComplementaryReimagined shader via Iris. Don't know if it happens with other shaders or not, but I know that I can only see the rune effect if I turn the shaders off.

Don't get me wrong, it makes for some AWESOME invisible traps xD but it isn't the best for making it look good.

[bug] Custom colors not synced from server

Mod Version (e.g. Fabric 0.3.4): 0.6.2 (all)

What you expect to happen:
Colors should be visible on clients when loading into a server with a custom color datapack.

What actually happens:
Clients can only see colors from their own datapack, and only if loading into singleplayer first.

[enhancement] allow more config/attribute control over spell cooldowns

Would it be possible to allow players to change how cooldowns work in the config? If so, having the ability to make only spells of the same type share cooldowns, making cooldown for the spell you used longer then the others, and things of the like would be really helpful for modpack creators. Also maybe add some kind of attribute/status effect that lowers spell cooldowns? Might be worth considering

Spells problems

So I was messing around with your wonderful mod (fabric 1.19.2 mod version 0.3.4) and few spells seem not to work (or they have extra steps I have to take that are hard to understand/reveal), for example Immolate, Charge Weapons and Great Smite may work but I just have no clue what they supposed to do (there was also self damage spell but I figured what I'd did, why does it even exist), or how to make them work, on the other hand Break Block and Healing Hands doesn't work at all (unless Healing Hands work only on other players then nvm),
Besides that I have to admit that spell writing is ridiculous, it's annoying but once you get hang of it it's duable, still not my favourite way to create spells but for sure most original.
I hope in the future there will be improvements to that system (I would love to hear what do you plan to implement), of course more awesome spells, and maybe some other magical components like staffs, robes, runes n such (a way to have spell beacons via let's say lectern seems vanilla+ and would be great addition).

[book text is displayed properly only in the right hand]

scriptor-0.6.6-1.21.1-sgd-fabric:

i expected to see text in the book

the text is displayed in air. im holding book in the left hand as a main hand, but text is still at right side, floating. it also happens when i hold it in the right hand, as in the screenshots.
2023-11-01_19 03 05
2023-11-01_19 07 48

Spell "Immolate" Throws Error

The spell "Immolate" throws an error when I attempt to cast it.

[19:11:39] [Server thread/INFO]: [STDERR]: java.lang.ArrayIndexOutOfBoundsException: Index 4 out of bounds for length 4 [19:11:39] [Server thread/INFO]: [STDERR]: at com.ssblur.scriptor.helpers.DictionarySavedData.parse(DictionarySavedData.java:407) [19:11:39] [Server thread/INFO]: [STDERR]: at com.ssblur.scriptor.item.Spellbook.method_7836(Spellbook.java:44) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.class_1799.method_7913(class_1799.java:276) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.class_3225.method_14256(class_3225.java:290) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.class_3244.method_12065(class_3244.java:1182) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.class_2886.method_12550(class_2886.java:29) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.class_2886.method_11054(class_2886.java:7) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.class_2600.method_11072(class_2600.java:22) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.class_3738.run(class_3738.java:18) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.class_1255.method_18859(class_1255.java:157) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.class_4093.method_18859(class_4093.java:23) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:776) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:159) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.class_1255.method_16075(class_1255.java:131) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:758) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:752) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.class_1255.method_18857(class_1255.java:140) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:737) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:669) [19:11:39] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257) [19:11:39] [Server thread/INFO]: [STDERR]: at java.base/java.lang.Thread.run(Thread.java:833)

[bug] Spells not casting 1.0.4-1.20.4

Mod Version (e.g. Fabric 0.3.4): Fabric 1.0.4-1.20.4

What you expect to happen:
Spell should render directly and cast as expected.

What actually happens:
Crafted spells render with quotes and do not cast as expected.
image

[bug] Dedicated server crash

Mod Version (e.g. Fabric 0.3.4):
Forge 0.3.5 for forge 1.19.2 43.2.4

What you expect to happen:
A brief description of what you think should happen.
No crash

What actually happens:
What actually happens, in detail. If you can, include steps here on how to reproduce the issue.

Crash on occasion: See attached crash report, it seemed to occur after a player unlocked a new spell sometimes... it seems very hard to pin down the exact cause but it may be an issue that rarely occurs in an dedicated server environment. If there's any other info I can provide please do tell, and I'll let you know if we run into it again.

crash-2023-04-25_01.39.33-server.txt

[bug] Chat validation error

Mod Version (Fabric 0.4.3):

What you expect to happen:
Chat message casts the spell normally.

What actually happens:
Chat message breaks something and kicks me out of the world with the message "Chat message validation failure".

2023-05-21_14 28 05

scriptor_dictionary.zip

[bug] mod throws java.lang.reflect.InvocationTargetException error on startup

Mod Version (e.g. Fabric 0.3.4): Forge 44.1.23

What you expect to happen:
Minecraft loads to the main screen without any issue

What actually happens:
A screen pops up saying that Scriptor failed to load, giving this reason: java.lang.reflect.InvocationTargetException
To reproduce:

  1. Install Forge 44.1.23
  2. (Maybe what is causing the issue) Install Optifine and GeckoLib and possibly cave noise mod as well as Scriptor for 1.19.3.
  3. Start Minecraft

[bug] Few bugs and errors (1.20.4)

Mod Version (e.g. Fabric 0.3.4):

Minecraft 1.20.4
Fabric 0.15.3
Fabric API 0.91.3
Java 20.0.2
Scriptor 1.0.4

ISSUES:

  1. Parsing errors loading custom advancements shows up in the logs upon loading a world.

  2. A Warning shows up in the log saying missing textures [20:35:50] [Worker-ResourceReload-3/WARN]: Missing textures in model scriptor:light#: minecraft:textures/atlas/blocks.png:scriptor:entity/empty_circle

  3. Missing break particles for chalk circles, runes and magic light
    2023-12-31_20 55 26

  4. You can place chalk circles on chalk circles (also with runes), unless this is intentional. Additionally chalks stays in the air or float when there is no block below it, the chalk should break if there is no block below it.
    2023-12-31_20 56 58

  5. Apparently, you can place chalk down without looking at the block, I can't explain it so heres a video:

chalk.mp4

[bug] crash at launch in 1.20.4 Forge

Mod Version:
Forge version 1.20.4-forge49.0.13 (current latest available forge version for 1.20.4)
with the mods:
Scriptor-0.6.6-1.21.1 (current latest release version on Modrinth)
Architectury-11.0.9 (current latest release version on Modrinth)
Patchouli-1.20.1-84-FORGE (current latest release version on Modrinth)

What you expect to happen:
I expect the game to launch and reach the main menu without errors

What actually happens:
When launching the game I am presented with this error:
Scriptor (scriptor) has failed to load correctly
java.lang.NoClassDefFoundError:
net/minecraft/advancements/critereon/AbstractCritereonTriggerInstance

Crash.txt Below:
crash-2024-01-03_03.49.56-fml.txt

[bug] Repair Item spell seems to have an incredibly low cap

Mod Version (e.g. Fabric 0.3.4):
Fabric 0.6.6-1.21.1

What you expect to happen:
Crafted a spell using combination of "Target self + Target target's inventory + Target 1st valid inventory slot + repair/heal + increased power + must be full health" i.e. a slight amendment to the inbuilt "Repair" spellbook.
It should be repeatedly usable to be able to repair my items up to max durability again.

What actually happens:
Item heals once, for a small amount. Any subsequent uses seem to cause the item to "pulse" to show that it's being affected correctly, but the durability just doesn't shift at all. Unless I'm misunderstanding that there is some arbitrary soft-cap on the amount of repair an item can receive, I should be able to keep using the spell to repair the item up but after the initial use it just doesn't seem to add any more durability to the item.

[bug] Bring from first full slot in inventory not working

Mod Version (e.g. Fabric 0.3.4): v0.6.6-1.21.1

What you expect to happen:

"It will teleport an item from the first filled slot in a target inventory to the caster
Target inventories are like chests, furnaces, horses, mules, etc.
If there is no valid inventory, it will fall back to a normal bring spell, so it can also be used to teleport mobs to the caster" - the creator of the mod ssblur

What actually happens:
What actually happens, in detail. If you can, include steps here on how to reproduce the issue.

nothing .-. suprisingly it does cast but it just doesn't move any items

[Suggestion] Spell Obfuscation

Basically, I was wondering if it would be possible to create spells but then somehow lock them, so that others cannot view the formula contained within. So, they can use the book but cannot decipher the spell. I can see this being a bit difficult with the spellbooks, but perhaps there could be some kind of limited-use item that cast the spell but whose formula you couldn't read? Obviously, this isn't really useful for Singleplayer, but it would be a nice feature for Multiplayer.

[Suggestion] Describe the mod's capabilities more on mod page

The Modrinth page for this mod doesn't exactly tell what the spells in it are capable of doing - interesting mechanics are all well and good but one doesn't know what niches it could occupy.

Would it be reasonable to list somewhere what the spells may do?

Entity tick crash [bug]

Fabric 0.6.2:

What you expect to happen:
Game dosn't crashing.

What actually happens:
I was in my base just messing around. I had a scriptor book i crafted myself in my inventory, but wasn't using it. I had been testing runes. I tried to test a heal spell, so I tried to hurt myself by using lava. I'm not very good at it. I died. I have a mod that makes your items go in a chest when u dye. So, i went to recover my things, and the world just got currupted. Every time i entered, a few seconds passed and I end up crashing. I used a command that killed all entities except for player, item frames, and armor stands, but that didn't help.
I'm not able to reproduce the thing rigth now. In the crash report, it pointed the fail to:
-- Block entity being ticked --
Details:
Name: scriptor:casting_lectern // com.ssblur.scriptor.blockentity.CastingLecternBlockEntity
Block: Block{scriptor:casting_lectern}[facing=north]
Block location: World: (17,62,270), Section: (at 1,14,14 in 1,3,16; chunk contains blocks 16,-64,256 to 31,319,271), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511)
Block: Block{scriptor:casting_lectern}[facing=north]
Block location: World: (17,62,270), Section: (at 1,14,14 in 1,3,16; chunk contains blocks 16,-64,256 to 31,319,271), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511)
I will try to check what was the casting lectern doing when I recover a
crash-2023-08-12_15.56.52-server.txt
backup from the world. I attach the first crash repport.

[bug] Casting Lecterns cast projectile spells off centre in 1.20.4 Forge

Mod Version:
Scriptor-1.0.6-1.20.4

What you expect to happen:
i expect the lectern to fire the spell down the center of the block as in previous versions

What actually happens:
the spell fires off center from the back of the lectern.
in the images below the lectern fires the default fireball spell from the right side of the back of the lectern and you can see it hugging the wall. In the first image I have put down a anvil to show that it is not a graphical error, as the spell will hug the wall and pass through the gap in the anvil's hitbox to hit the wall behind it.
image_2024-01-03_065440185

image_2024-01-03_065326472

[enhancement] Cast enchants.

Enchantments are kind of magic, so I think it would be cool if you'll be able to apply vanilla enchantments on items using spells.

Error on server startup

Error's out on server start

[00:47:27] [main/INFO]: Loading Minecraft 1.19.2 with Fabric Loader 0.14.17
[00:47:27] [main/INFO]: Loading 43 mods:
	- architectury 6.5.69
	- fabric-api 0.75.1+1.19.2
	   |-- fabric-api-base 0.4.15+8f4e8eb390
	   |-- fabric-api-lookup-api-v1 1.6.14+93d8cb8290
	   |-- fabric-biome-api-v1 9.1.0+82db024a90
	   |-- fabric-block-api-v1 1.0.2+e415d50e90
	   |-- fabric-blockrenderlayer-v1 1.1.25+cafc6e8e90
	   |-- fabric-client-tags-api-v1 1.0.5+b35fea8390
	   |-- fabric-command-api-v1 1.2.16+f71b366f90
	   |-- fabric-command-api-v2 2.2.1+413cbbc790
	   |-- fabric-commands-v0 0.2.33+df3654b390
	   |-- fabric-containers-v0 0.1.41+df3654b390
	   |-- fabric-content-registries-v0 3.5.1+7c6cd14d90
	   |-- fabric-convention-tags-v1 1.2.2+27265b3490
	   |-- fabric-crash-report-info-v1 0.2.8+aeb40ebe90
	   |-- fabric-data-generation-api-v1 5.3.7+413cbbc790
	   |-- fabric-dimensions-v1 2.1.35+0d0f210290
	   |-- fabric-entity-events-v1 1.5.4+9244241690
	   |-- fabric-events-interaction-v0 0.4.34+562bff6e90
	   |-- fabric-events-lifecycle-v0 0.2.35+df3654b390
	   |-- fabric-game-rule-api-v1 1.0.24+b6b6abb490
	   |-- fabric-item-api-v1 1.6.5+dce4603e90
	   |-- fabric-item-groups-v0 0.3.38+9244241690
	   |-- fabric-key-binding-api-v1 1.0.25+5c4fce2890
	   |-- fabric-keybindings-v0 0.2.23+df3654b390
	   |-- fabric-lifecycle-events-v1 2.2.4+1b46dc7890
	   |-- fabric-loot-api-v2 1.1.12+83a8659290
	   |-- fabric-loot-tables-v1 1.1.15+9e7660c690
	   |-- fabric-message-api-v1 5.0.7+93d8cb8290
	   |-- fabric-mining-level-api-v1 2.1.23+33fbc73890
	   |-- fabric-models-v0 0.3.21+c6af733c90
	   |-- fabric-networking-api-v1 1.2.11+10eb22f490
	   |-- fabric-networking-v0 0.3.28+df3654b390
	   |-- fabric-object-builder-api-v1 4.2.1+d8ef690890
	   |-- fabric-particles-v1 1.0.14+4d0d570390
	   |-- fabric-recipe-api-v1 1.0.1+413cbbc790
	   |-- fabric-registry-sync-v0 0.9.32+9244241690
	   |-- fabric-renderer-api-v1 1.2.1+1adbf27790
	   |-- fabric-renderer-indigo 0.8.0+1adbf27790
	   |-- fabric-renderer-registries-v1 3.2.24+df3654b390
	   |-- fabric-rendering-data-attachment-v1 0.3.19+6e0787e690
	   |-- fabric-rendering-fluids-v1 3.0.11+4d0d570390
	   |-- fabric-rendering-v0 1.1.27+df3654b390
	   |-- fabric-rendering-v1 1.12.1+d8ef690890
	   |-- fabric-resource-conditions-api-v1 2.1.2+aae9039d90
	   |-- fabric-resource-loader-v0 0.8.3+251d254a90
	   |-- fabric-screen-api-v1 1.0.32+4d0d570390
	   |-- fabric-screen-handler-api-v1 1.3.7+1cc24b1b90
	   |-- fabric-sound-api-v1 1.0.2+c4f28df590
	   |-- fabric-textures-v0 1.0.24+aeb40ebe90
	   |-- fabric-transfer-api-v1 2.1.6+413cbbc790
	   \-- fabric-transitive-access-wideners-v1 1.3.3+08b73de490
	- fabricloader 0.14.17
	- java 17
	- minecraft 1.19.2
	- scriptor 0.2.12
[00:47:27] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=file:/F:/Downloads/Server%20Files/libraries/net/fabricmc/sponge-mixin/0.12.4+mixin.0.8.5/sponge-mixin-0.12.4+mixin.0.8.5.jar Service=Knot/Fabric Env=SERVER
[00:47:27] [main/INFO]: Compatibility level set to JAVA_16
[00:47:27] [main/INFO]: Compatibility level set to JAVA_17
[00:47:31] [main/INFO]: Building unoptimized datafixer
[00:47:32] [main/ERROR]: Failed to start the minecraft server
java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'scriptor'!
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51) ~[fabric-loader-0.14.17.jar:?]
	at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33) ~[fabric-loader-0.14.17.jar:?]
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49) ~[fabric-loader-0.14.17.jar:?]
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35) ~[fabric-loader-0.14.17.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.Hooks.startServer(Hooks.java:62) ~[fabric-loader-0.14.17.jar:?]
	at net.minecraft.server.Main.main(Main.java:101) [server-intermediary.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:462) [fabric-loader-0.14.17.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.14.17.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotServer.main(KnotServer.java:23) [fabric-loader-0.14.17.jar:?]
	at net.fabricmc.loader.impl.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:69) [fabric-loader-0.14.17.jar:?]
Caused by: java.lang.NoClassDefFoundError: net/minecraft/class_5614
	at com.ssblur.scriptor.blockentity.ScriptorBlockEntities.registerRenderers(ScriptorBlockEntities.java:30) ~[scriptor-0.2.12.jar:?]
	at com.ssblur.scriptor.blockentity.ScriptorBlockEntities.register(ScriptorBlockEntities.java:26) ~[scriptor-0.2.12.jar:?]
	at com.ssblur.scriptor.ScriptorMod.init(ScriptorMod.java:37) ~[scriptor-0.2.12.jar:?]
	at com.ssblur.scriptor.fabriclike.ScriptorModFabricLike.init(ScriptorModFabricLike.java:7) ~[scriptor-0.2.12.jar:?]
	at com.ssblur.scriptor.fabric.ScriptorModFabric.onInitialize(ScriptorModFabric.java:9) ~[scriptor-0.2.12.jar:?]
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47) ~[fabric-loader-0.14.17.jar:?]
	... 7 more
Caused by: java.lang.ClassNotFoundException: net.minecraft.class_5614
	at jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) ~[?:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:226) ~[fabric-loader-0.14.17.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:112) ~[fabric-loader-0.14.17.jar:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
	at com.ssblur.scriptor.blockentity.ScriptorBlockEntities.registerRenderers(ScriptorBlockEntities.java:30) ~[scriptor-0.2.12.jar:?]
	at com.ssblur.scriptor.blockentity.ScriptorBlockEntities.register(ScriptorBlockEntities.java:26) ~[scriptor-0.2.12.jar:?]
	at com.ssblur.scriptor.ScriptorMod.init(ScriptorMod.java:37) ~[scriptor-0.2.12.jar:?]
	at com.ssblur.scriptor.fabriclike.ScriptorModFabricLike.init(ScriptorModFabricLike.java:7) ~[scriptor-0.2.12.jar:?]
	at com.ssblur.scriptor.fabric.ScriptorModFabric.onInitialize(ScriptorModFabric.java:9) ~[scriptor-0.2.12.jar:?]
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47) ~[fabric-loader-0.14.17.jar:?]
	... 7 more

[enhancement] Visual Overhaul?

The visual effects do leave things to be desired, the mechanics are well and good, but simple particle effects from base minecraft can be unattractive for those used to modded effects, so maybe some more flashiness would be a welcome addition to this mod, and make it have the same attraction as things like ars nouveau. just a suggestion

[bug] Binders do not work in 1.19.3

Mod Version (e.g. Fabric 0.3.4): Forge 0.5.0

What you expect to happen:
Putting a spell book in a crafting table with a mundane leather binder crafts a normal written book and putting a written book in a crafting table with a spellbook binder creates a spellbook.

What actually happens:
Both recipes do nothing.
To reproduce, either:

  1. Get a spellbook from a tome.
  2. Try to craft a spellbook with the mundane leather binder
    or
  3. Write a spell in a book and quill
  4. Sign the book and quill
  5. Try to craft the book and quill with a spellbook binder

I'm really sorry if this is just me being dumb again. Love the mod by the way.

Null Pointer Exception on Server

When new chunks are generating, this error will occasionally be thrown and will sometimes stall out/crash the server. Let me know if you need additional details.

[12.03 19:33:32] [Server] java.lang.NullPointerExceptionCannot read field "key" because "wordData" is null
[12.03 19:33:32] [Server] at TRANSFORMER/[email protected]/com.ssblur.scriptor.helpers.DictionarySavedData.parse(DictionarySavedData.java:404)
[12.03 19:33:32] [Server] at TRANSFORMER/[email protected]/com.ssblur.scriptor.events.SpellChatEvents.received(SpellChatEvents.java:23)
[12.03 19:33:32] [Server] at TRANSFORMER/[email protected]/dev.architectury.event.forge.EventHandlerImplCommon.event(EventHandlerImplCommon.java:160)
[12.03 19:33:32] [Server] at TRANSFORMER/[email protected]/dev.architectury.event.forge.__EventHandlerImplCommon_event_Submitted.invoke(.dynamic)
[12.03 19:33:32] [Server] at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:73)
[12.03 19:33:32] [Server] at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:315)
[12.03 19:33:32] [Server] at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:296)
[12.03 19:33:32] [Server] at TRANSFORMER/[email protected]/net.minecraftforge.common.ForgeHooks.onServerChatSubmittedEvent(ForgeHooks.java:463)
[12.03 19:33:32] [Server] at TRANSFORMER/[email protected]/net.minecraftforge.common.ForgeHooks$1.lambda$decorate$0(ForgeHooks.java:476)
[12.03 19:33:32] [Server] at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768)
[12.03 19:33:32] [Server] at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1760)
[12.03 19:33:32] [Server] at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
[12.03 19:33:32] [Server] at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
[12.03 19:33:32] [Server] at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
[12.03 19:33:32] [Server] at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
[12.03 19:33:32] [Server] at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.