sraaphorst / raytracer-cpp Goto Github PK

Note that there is some ghastliness in how the Intersections are created in Shape::localIntersection, since they need a shared_ptr to this. We could inherit from std::enabled_shared_from_this, and then use make_shared_from_this(), but then we need to have a shared_ptr to this stored somewhere as a prerequisite to doing so.

Instead, we should be using a factory to create Shape subclasses that manages the pointers.

See pg. 145.

See page 173 of book. Water, for example, should not cast a shadow.

See pg. 145.

See page 144: this allows proper checkering on spheres.

Right now, you have to do:

auto pattern = std::make_shared<PatternType>(params);
auto material = std::make_shared<Material>(pattern);

This could all be one much easier step as this is how it is always used:

auto material = PatternType::createPattern(params);

As per pg 184.

Right now, if World is const, we can still change its internal Shape objects. This should not be allowed.

Lots of methods are missing noexcept. Add it.

See pg. 146.

See pg. 145.