Code Monkey home page Code Monkey logo

Comments (6)

martinlippert avatar martinlippert commented on May 5, 2024

@kdvolder can you have a look and in case you can reproduce this, fix it on the Eclipse side?

from eclipse-integration-commons.

kdvolder avatar kdvolder commented on May 5, 2024

This is actually by design rather than a 'bug'. The long lines are taken as a signal that the file is probably something like minified .js rather than a 'real' source file that you actually want to search. I added this heuristic a long time ago because it bothered me a great deal to see matches in files like that.

So... can I reproduce this... Yes!

Can we fix this? We could remove the heuristic or make it optional, or make the number of the cut-of configurable somehow. Removing it would probably have the annoying side effect that matches in these kinds of minified files would start showing up which is not desirable.

Best is probably to make this configurable.

from eclipse-integration-commons.

petrf22 avatar petrf22 commented on May 5, 2024

from eclipse-integration-commons.

kdvolder avatar kdvolder commented on May 5, 2024

I think it is worth doing something to address this issue. But it needs a bit of thought exactly what should be done. I don't think just disabling the heuristic is the answer.

Should also mention that since we are in the process of contributing the quicksearch to Eclipse, this issue should probably be raised as bug report with Eclipse bugzilla to fix it in the future.

There's little point in trying to fix the STS version at this point.

from eclipse-integration-commons.

kdvolder avatar kdvolder commented on May 5, 2024

Actually, I just realized that this issue is in fact already addressed a really long time ago:

https://jira.spring.io/browse/STS-4033

There's a preference in the Quicksearch preference page to change the lenght at which this heuristic is triggered. So all that you really have to do is make it larger.

from eclipse-integration-commons.

petrf22 avatar petrf22 commented on May 5, 2024

Thank you for your time and information.

from eclipse-integration-commons.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.