When ExplorerScript files are compiled, sometimes the app crashes with a segmentation fault at the end.

This is probably due to the save thread unsafely accessing some parts of the file manager.

    search_down = not self.builder.get_object('sr_search_setting_search_backward2s').get_active()  #backward2s < backwards

Breaks "find and replace" @theCapypara ;-)

To make it easier for teams to share ExplorerScript files, a compile all option should be added that compiles all ExplorerScript files which are not up-to-date with the game

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #hack-discussion.

Make a new ABI interface for melonds if none exists, a Python lib and then interfaces in the debugger to be able to switch between Desmume and MelonDS

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #general.

You have to re-open the debugger currently

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #hack-discussion.

If the next search result is far away / if the document is big, clicking the icon for the next result stops midway through

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #skytemple.

It happens when opening one or both of the scripts.

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #skytemple-tester.

I suppose the flag to proceed to next floor is forced set to 0 when the checkbox isn't ticked?

Sentry Issue: SKYTEMPLE-K

SsbCompilerError: The number of parameters for back_SetBackEffect must be 1, is 2.
  File "skytemple_ssb_debugger\model\script_file_context\ssb_file.py", line 172, in save_thread
  File "skytemple_ssb_debugger\model\ssb_files\file_manager.py", line 101, in save_from_explorerscript
  File "skytemple_files\script\ssb\script_compiler.py", line 132, in compile_explorerscript
  File "skytemple_files\script\ssb\script_compiler.py", line 290, in compile_structured

See https://cdn.discordapp.com/attachments/712341699292037121/801643110265389066/unknown.png

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #skytemple.

Hi again,

Issue comes when i try to open scripts in skytemple. The application just close and the Illegal instruction (core dumped) pop in the terminal.
I've tried to do python -m skytemple_ssb_debugger.main to get more info. But nothing more happen.

Sorry not to be able to provide more info :/

Currently skytemple_files.threadsafe.synchronized_now requires erdewit/nest_asyncio to wait for the next job in the event loop to finish.

This is kinda an ugly hack, because asyncio doesn't support nested loops by default. There are some issues with this solution on Python 3.6 and on Windows.

We should check if we could replace this with a combination of asyncio.all_tasks and asyncio.wait.

asyncio.all_tasks is only available with Python 3.7, so there should be some backwards compatibility with Python 3.6 in place.

would it be possible to scale the emulator differently in skytemple?

Beep, boop, I'm a bot! This issue was created by @Scyrous in #rom-hacking-support.

Selecting Emulator -> Screenshot... in the SkyTemple debugger will not save the image unless the user adds their own ".png" extension to the file.

• Check what exactly DebugPrint2 was meant to be and fix up the offsets
• Support hooking into the copy of DebugPrint0 and into DebugPrintTrace

If a word contains an _, the completion things a word has ended and starts the suggestions new.
This should be changed, so that _ is not considered the end of a word.

That message doesn't disappear when the script file in question is unloaded in some cases

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #scripting-help.

This version uses an older Desmume upstream build that still works under Mac.

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #skytemple.

Need to be white

Sentry Issue: SKYTEMPLE-1S8

AssertionError: 
  File "skytemple_ssb_debugger\controller\main.py", line 332, in do_poll_emulator
  File "skytemple_ssb_debugger\controller\debugger.py", line 139, in hook__breaking_point

https://textbox.skytemple.org

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #rom-hacking-support.

Rewrite the emulator integration so that:

• it's faster: Goal is to reduce the overhead of the hook functions to the absolute bare minimum by avoiding the Python GIL however much possible and delaying processing hooks, so they don't block the emulator
• it's stabler and actually thread safe: By delaying book execution and letting them be processed by the main thread instead of the emulator thread, get rid of any current thread synchronization issues

To achieve this, the interfacing code between the debugger and the emulator should be rewritten in Rust and use a queuing mechanism to send and receive events to/from the main thread to the emulator thread.

Sometimes the search 'lags' and you have to hit the arrow buttons multiple times to jump to the next match (though only in unionall?) and dragging and dropping script text duplicates it instead of moving it

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #skytemple-tester.

https://cdn.discordapp.com/attachments/712341699292037121/806924386359312424/unknown.png

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #skytemple.

Originally reported at: https://discord.com/channels/710190644152369162/712341699292037121/955919539307159633

While trying to load a new scene from the debugger, this error pops up and disallows savestates. When trying to close SkyTemple, it also hangs indefinitely.
For context, I had only added three new scenes and one new script (this particular one was the first new scene added). This error did not happen immediately, as it only started failing sometime after adding two new scenes.

Refuse to save with undefined control sequences? Should probably be optional -> be able to turn that off

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #skytemple.

On the current 1.6 pre-release line the undo/redo functionality in the Script Engine Debugger no longer works.

See title.

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #rom-hacking-support.

I encountered an issue while using the emulator's debugger. I paused the emulator and then loaded my save state. However, I noticed that even though the "pause" button was still pressed and the debugger was indicating that "The game is paused," I could still use the emulator. This is different from the past versions where I had to press the unpause button to resume the emulator's functionality. This has been encountered in Skytemple's latest build.

(I apologize if the video's quality is not the best.)

Eg:

ERROR:skytemple_ssb_debugger.model.script_file_context.ssb_file:After save: Build temporary text marks for opcodes...
ERROR:skytemple_ssb_debugger.model.script_file_context.ssb_file:After save: Triggering callback...

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #skytemple.

To quote UsernameFodder:

I was randomly skimming through your latest dev stream VOD while procrastinating, and I noticed the chatter about the stairs item in PSMD. Is live RAM editing a current/future possibility in the debugger? Idk if End has mentioned this to you but there's this specific byte (actually two of them, *dungeon_ptr + 0x6 and *dungeon_ptr + 0x8) you can set that'll automatically advance you to the next floor at the end of the turn. Maybe that'd be useful for doing test runs? You could also use this in conjunction with the

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #skytemple.

git repo? Macro browser?

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #scripting-help.

Attempting to use the screenshot feature in the debugger successfully saves an image, but it results in a blank, transparent 256x384 image.

See title

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #rom-hacking-support.

There's a question mark after the first sentence, it should be a period.

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #scripting-help.

Add an option to search all scripts. Currently one can only search a single opened script at a time. This option would be useful for cases when one wants to replace all appearances of a certain term, which are generally inconvenient to look for (such as all appearances of a vanilla character's name in cutscene dialogue, when users want to change the species of that character - we've had many cases of users wanting to do that).

No content

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #beta-tester.

Originally reported at: https://discord.com/channels/710190644152369162/712341699292037121/1109113298357583892

Trying to copy or paste text from the debugger script window causes a crash (full crash that closes the whole program, no errors are logged).

from the logs it seems the saving thread is accessing parts of Gtk resources.

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #skytemple.

The new version of SkyTemple crashes whenever I try to auto proceed to next floor, and sometimes when I reload a savestate and get the "x script was changed" message, the emulator crashes but not SkyTemple as a whole. Not sure if there's any correlation. My last version was pre-1.0 so that could be something within the last few builds

Beep, boop, I'm a bot! This issue was created by @MaxSchersey in #beta-tester.

Since the release of SkyTemple 1.4, multiple people have reported that debug flags and the option to skip floors no longer work. See

• https://discord.com/channels/710190644152369162/712341699292037121/1038639020923703306
• https://discord.com/channels/710190644152369162/712341699292037121/1039210689035776101
• https://discord.com/channels/710190644152369162/1039959017751068772/1039959017751068772

https://explorerscript.readthedocs.io/en/latest/language_spec.html

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #skytemple-tester.

Sentry Issue: SKYTEMPLE-5V

AttributeError: 'NoneType' object has no attribute 'get_children'
  File "skytemple_ssb_debugger\controller\script_editor.py", line 663, in on_text_buffer_modified
  File "skytemple_ssb_debugger\controller\editor_notebook.py", line 242, in on_ssb_editor_modified

Write the save file to the project directory instead of the current working directory

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #skytemple.

The spellchecker breaks with any new lines inserted

Beep, boop, I'm a bot! This issue was created by @Parakoopa in #skytemple.