sixlabors / core Goto Github PK

I just created a pull request, I hope I did it correctly, my PR was based on the PR template for ImageSharp. This because this repo does not contain a PR template or any other contribution guidelines.

Mayhaps interesting to add guidelines (or copy from ImageSharp) to encourage other people to contribute.

Hello All,

I'm currently building an application that's targeting a few different framework versions, including .net 4.5.2. (we're stuck with this for a little while on that project).

We are getting this odd build issue when targetting version beta0005 of SixLabors.ImageSharp, which references SicLabors.Core version beta0006.

The issue is that when running under .net 4.5.2 (this may happen elsewhere too), we get the following error:
Exception has been thrown by the target of an invocation. There was an error trying to auto-sign the label file. The type initializer for 'SixLabors.ImageSharp.Configuration' threw an exception. Could not load file or assembly 'System.Buffers, Version=4.0.2.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)

The version being loaded of System.Buffers is 4.0.3.0 and not 4.0.2.0, which is why things fail. If we copy 4.0.2.0 back in, everything seems to work just fine again.

I reverted back to beta4 (which uses beta5 of core), and things are working again, everything is pointing back to the right versions.

Any idea why this is happening?

Thanks!

currently we have
public bool Contains(int x, int y) => this.X <= x && x < this.Right && this.Y <= y && y < this.Bottom;

should read
public bool Contains(int x, int y) => this.X <= x && x <= this.Right && this.Y <= y && y <= this.Bottom;

On Rectangle and RectangleF we should have an intersection method that returns the region where both rectangles overlap.

Hi,

What about using the System.Drawing.Primitives package ?

Adding any netstandard1.x package to a project only using netstandard2.0 refs tends to introduce some weird NuGet relationship hell which may output a large amount of unnecessary warnings upstream to all referencing projects.

Please just add the additional netstandard2.0 target.
Or maybe you just should change netcoreapp2.0 to netstandard2.0? It's a library, not an app. Even 100% of the ASP.NET Core 2.1 libs just target netstandard2.0.

Exception: Could not load file or assembly 'SixLabors.Core, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
I don't know why it is saying that.
I tried reinstalling the package, but that didn't help.