Code Monkey home page Code Monkey logo

Comments (5)

tocsoft avatar tocsoft commented on May 21, 2024

Actually I think the issue is that the Right & Bottom values are off by one

At the moment if the you have Rect @ 0,0 10x10 the Bottom & right are currently 10 when infact they should be 9.

from core.

KingKnecht avatar KingKnecht commented on May 21, 2024

Is that true? if I have 0,0 and 1x1 the bottom and right should be "0" ? I think "<=" is correct.

from core.

tocsoft avatar tocsoft commented on May 21, 2024

I think they are both wrong but the fact the bottom & right are off by one makes the contains return the correct value.

from core.

JimBobSquarePants avatar JimBobSquarePants commented on May 21, 2024

Looks correct to me.

We have

public bool Contains(int x, int y) => this.X <= x && x < this.Right && this.Y <= y && y < this.Bottom;

System.Drawing.Primitives has

public bool Contains(int x, int y) => X <= x && x < X + Width && Y <= y && y < Y + Height;

Our Right and Bottom properties match

        /// <summary>
        /// Gets the x-coordinate of the right edge of this <see cref="Rectangle"/>.
        /// </summary>
        public int Right
        {
            [MethodImpl(MethodImplOptions.AggressiveInlining)]
            get
            {
                return unchecked(this.X + this.Width);
            }
        }

        /// <summary>
        /// Gets the y-coordinate of the bottom edge of this <see cref="Rectangle"/>.
        /// </summary>
        public int Bottom
        {
            [MethodImpl(MethodImplOptions.AggressiveInlining)]
            get
            {
                return unchecked(this.Y + this.Height);
            }
        }

from core.

JimBobSquarePants avatar JimBobSquarePants commented on May 21, 2024

I'm closing this. I've double checked it against the Sytem.Drawing.Primitives.Rectangle and we match

from core.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.