Code Monkey home page Code Monkey logo

accessible_hamburger's People

Contributors

scottaohara avatar

Stargazers

avatar avatar avatar avatar

Watchers

avatar avatar

accessible_hamburger's Issues

accessible_hamburger

May I ask you a question about accessible_hamburger?

I am writing CSS for a hamburger menu that is valid for Google Accelerated Mobile Pages (AMP). Here is my JS Fiddle.
https://jsfiddle.net/jaygray/eu3r5qdk/2/

AMP does not allow the CSS 'input' and 'label' elements. Therefore your earlier effort:
http://www.scottohara.me/article/morph-button-updated.html
won't work with Google AMP.

However, this version has promise:
https://github.com/scottaohara/accessible_hamburger
as it does not use those CSS elements.

As you can see in my JS Fiddle, I have not been able to trigger the links and open the URLs. Using 'accessible hamburger' I am able to. And my JS Fiddle is a valid AMP document.

Google AMP does not allow JavaScript (except the AMP JavaScript). So this declaration:
<html amp lang="en" class="no-js">

must be:
<html amp lang="en">

And there may be other small changes so that accessible_hamburger works correctly for AMP.

Would you be willing to help me modify my CSS-only hamburger menu approach based on accessible_hamburger? I can help you negotiate AMP (I have written AMP valid HTML and can short-cut your learning curve). You then could present an AMP-valid structure. In return, I would have a solution for my applications.

Let me know if you have the time and interest to do this.

/jay

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.