Code Monkey home page Code Monkey logo

Comments (2)

scottaohara avatar scottaohara commented on May 28, 2024

Hey there,

So, the way I understand what you're asking me, is that you want to use this for the no-js solution, as a CSS only powered hamburger menu, because AMA doesn't allow you to write any additional JavaScript?

I mean. Based on how I understand what you're asking. To me the solution to your issue would be to update the CSS to replace all instances of the .no-js class with html[amp]

The CSS only solution loses a lot of the accessibility hooks, and is meant to be used as a means to provide some similar functionality when JavaScript is not available. But I just wanted to throw out that a CSS only solution (even my old morph menu article that you referenced), aren't meant to be a final solution, but only part of one, or in the case of the morph menu, to just showcase what could be done with CSS, but not necessarily meant as a recommendation to do so in a live production setting.

from accessible_hamburger.

gigster99 avatar gigster99 commented on May 28, 2024

Thanks for the ringback. AMP is the new kid-on-the-block and publishers, like my firm, are aligning our HTML content with the new requirements. Except for specific Google JS, all other JS is banned. Therefore, more control needs to move back to CSS-only. Clearly, some control is lost. So we need to re-compose our menus. Previously, we used bootstrap.js - but can't do that any more. Hence the interest in your CSS-only solution, and specifically the version that also does not use input and label (also banned in AMP).

So, my request was to generalize your CSS-only approach for AMP where the starting point might be the merger of my Fiddle JS and your accessible_hamburger. My hope was that you would adapt your hamburger to my Fiddle.

You might want to offer different configurations. One might float, as yours does now. Another might be fixed, together with a logo, in a nav bar.

The point being, the AMP market needs a general purpose solution and none currently exists. I've got most of the code but can't close the gap that you have - namely, triggering the links. But I'm not a good CSS programmer and would rather work with someone who is - like you - to package a versatile, working solution. I can point to partial solutions from which I've learned. But someone with better skills than mine needs to pull them together.

Wadda ya think?

from accessible_hamburger.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.