schultzcole / fvtt-skill-customization-5e Goto Github PK

HI
i'm using the form on tidy5e but when i put the bonus or malus on the tab and then close it, this change doesn't stay.
Is there a solution?
Thank you
Dalkan

PS: sorry for my bad English

When I add a bonus into a skill for Skill Customization for 5e (+10 for example for a Stealth check under Pass without a trace) this bonus is not applied to the Better Rolls roll. I don't know whether this is a BR or a SC problem. (I'm submitting the same issue over there...)

In a game I am running I changed Charisma to Creativity and Cha to Cre. This has resulted in the game defaulting things like Deception to Str and despite my players changing it each game it keeps flipping it back.

Amazing mod, does exactly what it says on the tin. Two things that'd be really cool in a settings menu:

1. Revert to Default Skill on Roll - This setting would cause whatever changes the user made to revert after a roll. So if a user were to change Acrobatics to Str and roll it, it would change back to Dex after.
2. Disable Formula Field - This is the feature I'm more after, but being able to turn off the little field next to each skill where you can add in a formula or static bonus would be great, as I've got loads of mods that handle that, and it just stretches the sheet.

The first of those seems like a whole thing. The second doesn't, but either would be great to see (especially the second). Thanks so much for the mod.

Passive Perception and Investigation should get +5 with the observant feat, but the skill calculation override that skill customization does doesn't take that into account.

I like using Better Rolls, would you be able to support it?

@Will.I.Am#7000 requested the ability to add custom skills:

https://discord.com/channels/170995199584108546/722559135371231352/725331001785450547

He was not particular if it was global or per-character, and envisioned using it for tool proficiencies. There could be other uses also, as this is a pretty flexible concept.

Hi there,

I'm using Tidy5eSheet in conjunction with Skill Customization for D&D5e and there are Proficiencies missing on the sheet. For comparison here the standard sheet:

and then your sheet:

Dark and Light Theme have the problem in common. And as you can see - Stealth for example is missing. If I deactivate Skill customization, Stealth shows up on the TidySheet. So something is not quite right. Please have a look into it. Until then, I will use the standard sheets.

It is possible to add the ability to add skills with customized labels, setting the mod to use (DEX, STR, etc.)?

For example the "Swimming" skill to understand with some roll if someone is drowning or not.

Writing this mostly because there is a small issue with alignment with Tidy5e when using 3.0.0, currently on Foundry v9.

3.0.0 + Tidy5e:

3.0.0 Standalone:

2.3.0 (used to test whether or not the alignment issue was version specific) + Tidy5e:

I'll try to solve this myself within the CSS, however I'm not sure when I'll have the time to poke around with that and felt it more efficient to bring this up here just in case you might happen to get to it first.

When enabling this in version.0.7.5 I get this from the console

Foundry VTT | Error thrown in hooked function
_call @ foundry.js:2428
callAll @ foundry.js:2386
callOriginalFunction @ Patches.js:59
(anonymous) @ Debug.js:33
_getControlButtons @ foundry.js:20034
SceneControls @ foundry.js:19487
initializeUI @ foundry.js:6563
setupGame @ foundry.js:6474
async function (async)
setupGame @ foundry.js:6468
_initializeGameView @ foundry.js:7227
initialize @ foundry.js:6404
async function (async)
initialize @ foundry.js:6396
window.addEventListener.once @ foundry.js:7359
async function (async)
window.addEventListener.once @ foundry.js:7358
foundry.js:2429 TypeError: Cannot read property 'simplefog' of null
at controls.js:23
at Function._call (foundry.js:2426)
at Function.callAll [as __furnace_original_callAll] (foundry.js:2386)
at Function.callOriginalFunction (Patches.js:59)
at Function. (Debug.js:33)
at SceneControls._getControlButtons (foundry.js:20034)
at new SceneControls (foundry.js:19487)
at Game.initializeUI (foundry.js:6563)
at Game.setupGame (foundry.js:6474)
at async Game._initializeGameView (foundry.js:7227)
_call @ foundry.js:2429
callAll @ foundry.js:2386
callOriginalFunction @ Patches.js:59
(anonymous) @ Debug.js:33
_getControlButtons @ foundry.js:20034
SceneControls @ foundry.js:19487
initializeUI @ foundry.js:6563
setupGame @ foundry.js:6474
async function (async)
setupGame @ foundry.js:6468
_initializeGameView @ foundry.js:7227
initialize @ foundry.js:6404
async function (async)
initialize @ foundry.js:6396
window.addEventListener.once @ foundry.js:7359
async function (async)
window.addEventListener.once @ foundry.js:7358
foundry.js:2428 Foundry VTT | Error thrown in hooked function
_call @ foundry.js:2428
call @ foundry.js:2411
callOriginalFunction @ Patches.js:59
(anonymous) @ Debug.js:42
_render @ foundry.js:4472
async function (async)
_render @ foundry.js:4434
render @ foundry.js:4404
initializeUI @ foundry.js:6574
setupGame @ foundry.js:6474
async function (async)
setupGame @ foundry.js:6468
_initializeGameView @ foundry.js:7227
initialize @ foundry.js:6404
async function (async)
initialize @ foundry.js:6396
window.addEventListener.once @ foundry.js:7359
async function (async)
window.addEventListener.once @ foundry.js:7358
foundry.js:2429 TypeError: Cannot read property 'simplefog' of null
at controls.js:117
at Function._call (foundry.js:2426)
at Function.call [as __furnace_original_call] (foundry.js:2411)
at Function.callOriginalFunction (Patches.js:59)
at Function. (Debug.js:42)
at SceneControls._render (foundry.js:4472)
_call @ foundry.js:2429
call @ foundry.js:2411
callOriginalFunction @ Patches.js:59
(anonymous) @ Debug.js:42
_render @ foundry.js:4472
async function (async)
_render @ foundry.js:4434
render @ foundry.js:4404
initializeUI @ foundry.js:6574
setupGame @ foundry.js:6474
async function (async)
setupGame @ foundry.js:6468
_initializeGameView @ foundry.js:7227
initialize @ foundry.js:6404
async function (async)
initialize @ foundry.js:6396
window.addEventListener.once @ foundry.js:7359
async function (async)
window.addEventListener.once @ foundry.js:7358

Any chance we can get a 0.8.x update for this Module?

Do you intend to update to the latest version of Foundry v10?

The rollSkill() function in the 5e system actually returns a roll object(), which is used by modules as Midi (allegedly) and will be used by BetterRolls in a later version. However the rollSkill() overwrite you do does not return anything. If you add a return statement to https://github.com/schultzcole/FVTT-Skill-Customization-5e/blob/master/skl-customization.js#L60 it should (didn't test it) maintain compatibility by ensuring the type signature is compatible with vanilla 5e.

I started looking into it after @Sky-Captain-13 asked about compatibility with dice roll modifiers (like 1d4) in the discord.

The ability to add new skills would be a nice feature.

My idea would be to add a + at the bottom of the skills where you can add a skill, name it, and set the ability score it uses.

Using the system customizer from TheRipper, it is possible to add new skills and stats. Would be nice if the drop down populated with the new stats.

When BetterRollsFor5e is enabled, dice bonuses to skills don't work (flat bonuses still work though).

If I disable Better Rolls, then the dice bonuses start working.

Foundry 0.7.7
Better Rolls 1.2.0
Skill Customizations 2.1.0

When ever I have libWrapper enabled it shows that there is a conflict between “Tools Proficiencies for DnD 5e” and “Skill Customization for D&D 5e”. If both are enabled I can not open a character sheet from the menu or a token. If I disable one of them the character sheet opens fine. Posting this on the other module site.