Code Monkey home page Code Monkey logo

Comments (9)

Sappharad avatar Sappharad commented on June 23, 2024 1

@philjmaier
Command line is just the official mp3gain/aacgain app compiled for macOS. I don’t modify that. That type of request would go upstream to the original project, but they haven’t updated in years. It’s unlikely unless someone else does it.

from mp3gainosx.

Sappharad avatar Sappharad commented on June 23, 2024

Thanks. Maybe I'll add a file limit of 600 if I can't find an issue. It's difficult to test with that many files because I don't want to process all of my files since I wouldn't be able to test with them fresh again unless I copied them all.

from mp3gainosx.

Sappharad avatar Sappharad commented on June 23, 2024

Looking over the code again; The inefficiency with large lists was unfortunately intentional. It's using the "old way" of rendering a table which was deprecated in macOS 10.11 in favor of a new approach that is more efficient. But I still support macOS 10.7 or later, so if I want to fix this properly I'll have to drop support for macOS versions older than 10.11.

I definitely think it's reasonable to drop support for 10.7 to 10.10 now, but I should probably do one more release that supports 10.7 before that happens to address the AACGain issue that deletes files.

No ETA on these improvements. At the moment it's not too critical because you can work around it by using fewer files or using the command-line build that I have available on the website.

from mp3gainosx.

jri avatar jri commented on June 23, 2024

OK, thank you for checking!

from mp3gainosx.

philjmaier avatar philjmaier commented on June 23, 2024

I'm glad you did this port, however I do have the same issue. I'm on OSX 10.14.6 (18G95).

I'm using this at the command line:
find . -name *.m* -exec /Applications/aacgain -r -c -d 4.0 -p {} \;

Works good but was wondering if there was a way to run multiple threads like you can in the gui. Would be way more efficient than doing a single song at a time.

Thanks.

from mp3gainosx.

philjmaier avatar philjmaier commented on June 23, 2024

Me again. The two features that would be nice to add to command line are: multithreading, and recursing through directories. Great work though..

Again, thanks.

from mp3gainosx.

philjmaier avatar philjmaier commented on June 23, 2024

Looking at installing GNU Parallel (FINK) and multithreading it that way.
http://pdb.finkproject.org/pdb/package.php/parallel

from mp3gainosx.

Sappharad avatar Sappharad commented on June 23, 2024

Looking at installing GNU Parallel (FINK) and multithreading it that way.
http://pdb.finkproject.org/pdb/package.php/parallel

There are definitely a number of different solutions. You can do it with vanilla bash, which is the default terminal in macOS unless you've changed it or upgraded to Catalina which changed the default.

https://stackoverflow.com/questions/5238103/how-to-start-multiple-processes-in-bash

The multi-threaded versions of MP3Gain Express actually work this way. It's just launching multiple instances of the command line application and communicating with it directly to get the progress.

from mp3gainosx.

Sappharad avatar Sappharad commented on June 23, 2024

2.3.1 was released today. It fixes the critical bug with AACGain that caused it to delete incompatible files. It will be the last release that supports macOS 10.7 - 10.10.

Now that it's out and we have a final "good release" for 10.7, I'll look at this for the next release. No time estimate yet, this depends on when I get around to looking at it again.

from mp3gainosx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.