Code Monkey home page Code Monkey logo

Comments (2)

Sappharad avatar Sappharad commented on July 30, 2024

Oops. Someone tried to report this with the beta but didn't provided detailed enough information to reproduce and I thought it was a fluke.

When I introduced album gain, I had to add the list of files on to the commands that I send to mp3gain. But I was already adding on the 'first' file for track gain, so as a result the list of files actually contained the first track twice. So what was actually happening is that the first file had gain applied twice. So if it was supposed to get -3dB gain, it would apply -3dB then apply another -3dB right after that thinking it was modifying the next file.

This is fixed in ff043ed and will be corrected in version 2.0.1 releasing shortly.

As it turns out, the way I handle Album gain is also not the best either. mp3gain doesn't provide track volume information or processing status when running in album mode. And because it has to process all album tracks as a single track, I can't process multiple files at the same time to make it faster. I attempted to solve all of these problems by processing twice for album mode - once to get the track information and a second time to actually apply it. I figured that because it had already processed in track mode and knew the volume for each track that it could then immediately use that to reprocess as album without making you wait very long. Unfortunately, Album mode doesn't actually use the volume data from track mode so it has to re-process all of the files completely again. I will probably not change this behavior though, because then I won't have the original track-specifc volume information to display in the window and I don't want to modify mp3gain + aacgain to give me what I need.

from mp3gainosx.

Sappharad avatar Sappharad commented on July 30, 2024

2.0.1 is now released with the fix for this problem.

from mp3gainosx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.