[Issue] Application wants to do first run setup after updating to higher version about stardew-valley-mod-manager HOT 6 CLOSED

Evaluation:
The code when the application is as follows:

            Application.EnableVisualStyles();
            Application.SetCompatibleTextRenderingDefault(false);

            if(Properties.Settings.Default.SetupComplete == "TRUE")
            {
                Application.Run(new MainPage());
                //Application.Run(new FirstRunSetup());
            }
            else
            {
                Application.Run(new FirstRunSetup());
            }

Currently the application contains an internal setting "SetupComplete" which is set to FALSE by default. Once the user has completed the last stage of the setup process, this setting is set to TRUE.

The application checks whether the value for this setting is TRUE or FALSE

If the value returned is TRUE then the application assumes that the first time setup has been completed already and launches straight into the main page of the mod manager. If the user hasn't completed the setup, it returns FALSE and launches into the first time setup.

from stardew-valley-mod-manager.

Proposed Change::
It seems that for some reason the value is either not being fetched or the value is being reset when the update is applied. For this reason I am proposing that the Program.cs code be changed to the following:

            Application.EnableVisualStyles();
            Application.SetCompatibleTextRenderingDefault(false);

            if(Properties.Settings.Default.SetupComplete == "TRUE")
            {
                Application.Run(new MainPage());
                //Application.Run(new FirstRunSetup());
            }
            else
            {
                //First Run Setup hasn't been completed.
                if (Properties.Settings.Default.StardewDir == string.Empty)
                {
                    Application.Run(new FirstRunSetup());
                }
                else
                {
                    Application.Run(new MainPage());
                }
            }

This adds the extra fail safe that even if the first run setting isn't retrieved or returns the incorrect value, that the application will still see that an existing SDV directory exists and still run to the main dashboard. It will only launch into first run setup if:

1. There isn't an SDV Directory saved in the settings. AND
2. The first run setup setting is FALSE

Will move through to testing once this change has been made.

from stardew-valley-mod-manager.

Update
Issue not resolved. Looks like the application isn't carrying any settings over when program is updated. This is not usual or intended behaviour. Going to start looking at possible reasons for this.

from stardew-valley-mod-manager.

Issue Resolved:
The issue was that the assembly version information was being updated. The file version information being updated is fine but the product version information signifies a major increase in product version and resets the settings. Have reverted to share the same version number as found in 202202 as to avoid disruptions.

from stardew-valley-mod-manager.

Issue seems to be back with v220302 (in that it occurs when updating it to 220303 which is the development branch)
Unsure of why as we haven't changed the assembly product version.

from stardew-valley-mod-manager.

Issue was a false flag. Was working off of a different copy of the application (generated through debug build) rather than one obtained via install.

from stardew-valley-mod-manager.