Code Monkey home page Code Monkey logo

Comments (3)

whyoleg avatar whyoleg commented on June 11, 2024

Hey!

Thx for the report, though it's hard to understand what is the issue on current moment.
Can you please add frame logging on client or server side (via rsocket-java/rsocket-kotlin functionality) and post frame logs here (or via link to gist)?
As for rsocket-kotlin (on client side) you will need to add loggerFactory = PrintLogger.withLevel(LoggingLevel.DEBUG) to connector configuration.
f.e. if you are using ktor-client integration:

install(RSocketSupport) {
  connector {
    loggerFactory = PrintLogger.withLevel(LoggingLevel.DEBUG)
  }
}

Also, do you have some custom client / server configuration regarding fragmentation, like maxFragmentSize in rsocket-kotlin?

from rsocket-kotlin.

kumaraish avatar kumaraish commented on June 11, 2024

You are so correct !! I had maxFragmentSize = 1024 set in rsocket-kotlin
If I remove that, that error is gone...

I had copied it right from the //create ktor client example on https://github.com/rsocket/rsocket-kotlin

Is using maxFragmentSize = 1024 an issue?

from rsocket-kotlin.

whyoleg avatar whyoleg commented on June 11, 2024

Good to hear that it solves issue on your side!
Overall using maxFragmentSize should not cause any issues, but overall - stick with defaults unless needed :)
Example in README just shows what is possible to configure, may be we need to cleanup it a bit to make it more robust.

Though, you report confirms that there is a bug somewhere in fragmentation logic inside rsocket-kotlin regarding handling of request stream/channel frames (likely because of additional initialRequest field, that could be handled differently).
I believe rsocket-java implementation is correct, so I think that I will setup some cross-implementation testing in future (at least for fragmentation use case).

from rsocket-kotlin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.