Comments (9)
Looks like the same issue as #211. So I think it's ktor side
As for workaround is to provide CoroutineExceptionHandler
to server instance via scope
or parentCoroutineContext
which goes directly into applicationEngineEnvironment
from rsocket-kotlin.
related: #226
May be it will be possible to fix it in rsocket-kotlin
in similar way during refactoring of transports
from rsocket-kotlin.
@whyoleg thank you for your quick response!
That is also what we have been trying, but no success yet. Maybe we are doing something stupid since the handler never gets called.
We tried with the applicationEngingeEnviroment like this:
private val handler = CoroutineExceptionHandler { coroutineContext, throwable ->
println("CALLED")
when (throwable) {
is kotlinx.coroutines.channels.ClosedReceiveChannelException -> Unit
else -> throw throwable
}
}
fun applicationEngine(): NettyApplicationEngine {
val port = config.deployment("port", "80").toInt()
val host = config.deployment("host", "0.0.0.0")
return embeddedServer(
Netty,
applicationEngineEnvironment {
module {
mount()
printRoutes()
}
connector {
this.port = port
this.host = host
}
this.parentCoroutineContext = this.parentCoroutineContext + handler
}) {
}
}
We also tried passing a scope with a handler to the RSocketRequestHandler(EmptyCoroutineContext+handler)
and it still does not get called.
from rsocket-kotlin.
From what I've checked, looks like it's not possible to add exception handler for websocket session... Need to create an issue on ktor side for this (?).
Still it's possible to hide this exception on rsocket side, but I'm not sure, what is the best thing now as in that way it will be not possible to distinguish between just close and connection failure.
I need more time to investigate, if POC of new transport API will have this possibility...
from rsocket-kotlin.
will be fixed on ktor side here: https://youtrack.jetbrains.com/issue/KTOR-5016/Channel-was-closed-exception-in-WebSocket-during-normal-use
from rsocket-kotlin.
We did some digging, for the moment adding a simple try/catch
at
Maybe there is a way to propagate it and notify that the rSocket was closed (since this is very common when dealing with mobile and web clients)?
Maybe you can point us in the right direction and we make a PR?
from rsocket-kotlin.
Change should be a little bigger. We need to make receive result nullable and handle it where it's called. This will affect all transport implementations and not only websocket. Also handling of error error in send should be there: if send is called while receive is in process (as those operations can be performed in parallel). I will try to prepare a quicfix(and new patch release)this weekend, until new transport API will be available.
from rsocket-kotlin.
Thank you! If there is something we can help with let us know.
from rsocket-kotlin.
Sorry for the delay. Focus switched on new transport API. I've tried to create a quick fix, but it's really degrade stability and expected behavior of current transport implementation and I need to investigate more time that I expected. At the same time I still think, that this specific issue should be fixed on ktor side. I will try to ensure that it will be fixed in ktor 2.2.0 if ktor team will not do it.
from rsocket-kotlin.
Related Issues (20)
- New Kotlin Multiplatform memory model HOT 6
- Kotlin/Js compilation failed with missing dependency error. HOT 2
- Android app crashes after network error using TCP transport HOT 12
- Get Connection State HOT 2
- Incomplete async stack traces HOT 1
- JobCancellationException after client closes connection HOT 6
- Server: Request-Stream requests counter can overflow when client is misbehaving
- Task ':compileKotlinMetadata' fails on '0.15.0-SNAPSHOT's HOT 4
- 513[ApplicationError] Message: Destination '' does not support REQUEST_STREAM HOT 5
- TcpClientTransport: Supress ClosedReceiveChannelException when server disconnects HOT 2
- RSocket Client (ktor-websocket CIO) closes a connection after 5 seconds HOT 5
- Drop support for JS/Legacy
- Forward request information to Acceptor#accept (to get the client ip) HOT 1
- I didn't find rsocket-transport-nodejs-tcp example HOT 3
- build-kotlinx-atomicfu is never used HOT 1
- metadata not properly encoded when sending requestStream with BearerAuthMetadata(jwt) HOT 3
- Migrate to coroutines 1.7 HOT 1
- Add Kotlin/WASM support HOT 2
- Critical compatibility issue in Kotlin implementation due to MIME type serialization mismatch
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rsocket-kotlin.