Comments (2)
For the moment I went for another route on the client, since I need just Connected
and Disconnected
and use the retry feature I just created a StateFlow(Disconnected) and:
- Each time the Acceptor handler finishes state goes to Connected
- Each time the shouldRetry callback is called state goes to Disconnected
from rsocket-kotlin.
Hey, thanks for an idea!
As for Client side:
We already have something similar internally to support reconnect feature. There are 3 states there: Connecting, Connected and Failed. Im all for providing some public API for it, but we also need to think about resume
feature, that will come soon, and as so provide more info about state (f.e. Resuming, Resume Failed and may be something else).
As for Server side:
On current moment, with reconnect
feature only, server can know only that client disconnected, this is already there, you can call ConnectionAcceptorContext.requester.coroutineContext.job.invokeOnCompletion { callback }
. But with resume
this can be improved, so server will know, that client may resume in near future.
I like the proposal, but on current moment I'm in progress with polishing (and breaking :) ) Public API and implementing new features like resume and lease, so I'm not sure, that it's not the best time to add such a feature.
But!
For Client side, this can be implemented externally for now.
You can look at https://github.com/rsocket/rsocket-kotlin/blob/master/rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/internal/ReconnectableRSocket.kt. This file have full logic for reconnect implementation, and if you need state preserved, you can just copy it and change return type from RSocket
to ReconnectableRSocket
with exposed state as some sealed class! Don't forget then not to use out-of-the-box reconnect
feature.
from rsocket-kotlin.
Related Issues (20)
- New Kotlin Multiplatform memory model HOT 6
- Kotlin/Js compilation failed with missing dependency error. HOT 2
- Android app crashes after network error using TCP transport HOT 12
- Incomplete async stack traces HOT 1
- JobCancellationException after client closes connection HOT 6
- Server: Request-Stream requests counter can overflow when client is misbehaving
- Task ':compileKotlinMetadata' fails on '0.15.0-SNAPSHOT's HOT 4
- 513[ApplicationError] Message: Destination '' does not support REQUEST_STREAM HOT 5
- TcpClientTransport: Supress ClosedReceiveChannelException when server disconnects HOT 2
- RSocket Client (ktor-websocket CIO) closes a connection after 5 seconds HOT 5
- Handle client disconnect in server HOT 9
- Drop support for JS/Legacy
- Forward request information to Acceptor#accept (to get the client ip) HOT 1
- I didn't find rsocket-transport-nodejs-tcp example HOT 3
- build-kotlinx-atomicfu is never used HOT 1
- metadata not properly encoded when sending requestStream with BearerAuthMetadata(jwt) HOT 3
- Migrate to coroutines 1.7 HOT 1
- Add Kotlin/WASM support HOT 2
- Critical compatibility issue in Kotlin implementation due to MIME type serialization mismatch
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rsocket-kotlin.