Making field property accessible after definition about graphql-ruby HOT 3 CLOSED

Is there interest in storing this to an instance variable and exposing a getter?

👍 that'd be great! Maybe you could update the default resolve proc to check for a property? (or maybe that's a waste of time at runtime?)

from graphql-ruby.

At first I didn't want to have the proc do the check, but then property would make more sense as a attr_reader only (since the original property would be hardwired to the proc). But that complicates other things, like when DefinitionConfig#to_instance using public_send to set the attributes on the Field.

So I'm going to have the proc do the check. I don't think performance would be affected much, especially on ruby 2.x.

from graphql-ruby.

Hmm, after making the changes, I realized I could've re-created the resolver proc when property is reassigned, instead of checking inside the proc. Not sure it's worth the effort to change it though.

from graphql-ruby.