Describe the bug Hi! I found a bug regarding the au

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

authorized? for GraphQL::Schema::EnumValue is not working about graphql-ruby HOT 2 OPEN

vitaliiorlov commented on June 13, 2024

authorized? for GraphQL::Schema::EnumValue is not working

from graphql-ruby.

Comments (2)

rmosolgo commented on June 13, 2024

Hey, thanks for reporting this. Did you find this documented somewhere? I didn't find it in the documentation and I don't see it addressed in the relevant spec (https://github.com/rmosolgo/graphql-ruby/blob/master/spec/graphql/authorization_spec.rb), so I think it was just never dreamed of!

But we could definitely add it. My first thought on a place to add it would be to hook in here:

graphql-ruby/lib/graphql/execution/interpreter/runtime.rb

Lines 570 to 572 in 18f3ded

    
           when "SCALAR", "ENUM" 
        
             r = begin 
        
               current_type.coerce_result(value, context)

and here:

graphql-ruby/lib/graphql/schema/argument.rb

Lines 264 to 268 in 18f3ded

    
           coerced_value = begin 
        
             type.coerce_input(value, context) 
        
           rescue StandardError => err 
        
             context.schema.handle_or_reraise(context, err) 
        
           end

Which go here:

graphql-ruby/lib/graphql/schema/enum.rb

Lines 143 to 166 in 18f3ded

    
           def coerce_result(value, ctx) 
        
             warden = ctx.warden 
        
             all_values = warden ? warden.enum_values(self) : values.each_value 
        
             enum_value = all_values.find { |val| val.value == value } 
        
             if enum_value 
        
               enum_value.graphql_name 
        
             else 
        
               raise self::UnresolvedValueError.new(enum: self, value: value, context: ctx) 
        
             end 
        
           end 
        
           def coerce_input(value_name, ctx) 
        
             all_values = ctx.warden ? ctx.warden.enum_values(self) : values.each_value 
        
             if v = all_values.find { |val| val.graphql_name == value_name } 
        
               v.value 
        
             elsif v = all_values.find { |val| val.value == value_name } 
        
               # this is for matching default values, which are "inputs", but they're 
        
               # the Ruby value, not the GraphQL string. 
        
               v.value 
        
             else 
        
               nil 
        
             end 
        
           end

I think if those two methods (coerce_input and coerce_result) included enum_value.authorized? checks, it would implement this feature.

Feel free to give it a try if you're interested, otherwise I'll keep this open and try to take a crack at it when I find time!

from graphql-ruby.

vitaliiorlov commented on June 13, 2024

@rmosolgo thank you for looking into this.

Did you find this documented somewhere? I didn't find it in the documentation...

No, there is no documentation regarding this. I just looked around the source code and found that the enum value also has those methods (visible? and authorized?). So, I have such a case in my project where I would like to have such a feature, but tried to work with that and found out that visible? is working correctly, but authorized? does not. This is a short story about how I created this bug because, in the gem's source code, I've seen such a method and anticipated it should work then.

from graphql-ruby.

Recommend Projects

authorized? for GraphQL::Schema::EnumValue is not working about graphql-ruby HOT 2 OPEN

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	when "SCALAR", "ENUM"
	r = begin
	current_type.coerce_result(value, context)

	coerced_value = begin
	type.coerce_input(value, context)
	rescue StandardError => err
	context.schema.handle_or_reraise(context, err)
	end

	def coerce_result(value, ctx)
	warden = ctx.warden
	all_values = warden ? warden.enum_values(self) : values.each_value
	enum_value = all_values.find { \|val\| val.value == value }
	if enum_value
	enum_value.graphql_name
	else
	raise self::UnresolvedValueError.new(enum: self, value: value, context: ctx)
	end
	end

	def coerce_input(value_name, ctx)
	all_values = ctx.warden ? ctx.warden.enum_values(self) : values.each_value

	if v = all_values.find { \|val\| val.graphql_name == value_name }
	v.value
	elsif v = all_values.find { \|val\| val.value == value_name }
	# this is for matching default values, which are "inputs", but they're
	# the Ruby value, not the GraphQL string.
	v.value
	else
	nil
	end
	end