Code Monkey home page Code Monkey logo

Comments (1)

rmosolgo avatar rmosolgo commented on June 1, 2024 1

Hey, thanks for the detailed report. I agree it should somehow behave differently if a custom value is configured.

This behavior is happening because connection fields get special handling for complexity, coming from here:

graphql-ruby/lib/graphql/schema/field.rb

Line 463 in 33bc196

elsif connection?

I think this is where it should check for a defined complexity value:

graphql-ruby/lib/graphql/schema/field.rb

Lines 501 to 502 in 33bc196

# Add 1 for _this_ field
1 + (max_possible_page_size * items_complexity) + metadata_complexity + nodes_edges_complexity

And for reference, here's the "normal" behavior which does check for a defined value:

graphql-ruby/lib/graphql/schema/field.rb

Lines 505 to 520 in 33bc196

defined_complexity = complexity
case defined_complexity
when Proc
arguments = query.arguments_for(nodes.first, self)
if arguments.is_a?(GraphQL::ExecutionError)
return child_complexity
elsif arguments.respond_to?(:keyword_arguments)
arguments = arguments.keyword_arguments
end
defined_complexity.call(query.context, arguments, child_complexity)
when Numeric
defined_complexity + child_complexity
else
raise("Invalid complexity: #{defined_complexity.inspect} on #{path} (#{inspect})")
end

from graphql-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.