Example does not work about ansible-gitlab-runner HOT 7 CLOSED

liked the idea ;p

from ansible-gitlab-runner.

Like how it is now right?

from ansible-gitlab-runner.

Yes exactly! Thanks

from ansible-gitlab-runner.

Hey,
I just ran into the same problem because I wrote my host vars by hand and didn't defined the docker_image line. Debugging was quite cumbersome because I had to get rid of the no_log to see the actual error message and debug the problem :/

Why not set a sane default for docker_image like alpine, instead of "" which will break the task? From what I saw, this change would require just two lines changed.

from ansible-gitlab-runner.

In the example it is set to "alpine" is that not what you are referring to?

from ansible-gitlab-runner.

No, I'm referring to the actual register_runner.yml task. In line 44 we have

    --docker-image '{{ gitlab_runner.docker_image|default("") }}'

Which results in an empty --docker-image flag for the register which will then fail because it's an required parameter. And because of the no_log this is hard to debug because you don`t get any output.

My idea was to change this default("") part in the task itself and insert alpine over there. This would make the playbook more robust and it would also run fine if one doesn"t define a docker_image in its vars

from ansible-gitlab-runner.

Awesome. Thanks for the quick fix :)

from ansible-gitlab-runner.