Code Monkey home page Code Monkey logo

Comments (13)

Grokzen avatar Grokzen commented on June 11, 2024 4

I would like to add a +1 for this needs to be supported sooner rather then later. Gitlab 17.0 is slated to be released on 2024-05-16 according to their own page here https://about.gitlab.com/upcoming-releases/

It would also be to assume that 17.0 would roll out on the SaaS site gitlab.com soon after that and then this feature would stop working in this ansible module and ppl who register runners with this module probably would have to revert back to something that @ykslol mentions in previous comments and just run that set of code as a bash script or something

from ansible-gitlab-runner.

guenhter avatar guenhter commented on June 11, 2024 3

In our company we have this on our Radar and want to implement this in the next weeks

from ansible-gitlab-runner.

guenhter avatar guenhter commented on June 11, 2024

Duplicate of #269

from ansible-gitlab-runner.

osksa avatar osksa commented on June 11, 2024

Duplicate of #269

Yes, but that issues is closed. I also want the feature @ykslol proposes, so I think it would be nice to have an open issue on it? (Or reopen #269 )

from ansible-gitlab-runner.

ykslol avatar ykslol commented on June 11, 2024

@osksa i think it is no matter which task should be opened.
I think i could to post all info, which i posted here, in old task, when it be reopened. And then we could continue our discussion there.

Offtopic - may be required other issue started
Today i registered runner by hands via binary. In new version of this role i think we need to make deprecation for repo installation. This features were added in installation via binary:
From gitlab-docs:

# Download the binary for your system
sudo curl -L --output /usr/local/bin/gitlab-runner https://gitlab-runner-downloads.s3.amazonaws.com/latest/binaries/gitlab-runner-linux-amd64

# Give it permission to execute
sudo chmod +x /usr/local/bin/gitlab-runner

# Create a GitLab Runner user
sudo useradd --comment 'GitLab Runner' --create-home gitlab-runner --shell /bin/bash

# Install and run as a service
sudo gitlab-runner install --user=gitlab-runner --working-directory=/home/gitlab-runner
sudo gitlab-runner start

Really simple - no repo installation any more.
Just download, install via builtin runner command and register it with parameters which u need.

With new workflow of gitlab registration - runners management will be much more easy. And this role logic will be simpler

from ansible-gitlab-runner.

riemers avatar riemers commented on June 11, 2024

sudo curl -L --output /usr/local/bin/gitlab-runner https://gitlab-runner-downloads.s3.amazonaws.com/latest/binaries/gitlab-runner-linux-amd64

I am pretty sure a lot of organisations will start to freak out on things like this. Placing binary files directly from the internet. I am not saying i have something better at the moment, i think we as community need to come up with something solid. Using 'latest' is maybe also not the best approach for some too.

from ansible-gitlab-runner.

riemers avatar riemers commented on June 11, 2024

Then its just 'company work' right? 😎

from ansible-gitlab-runner.

guenhter avatar guenhter commented on June 11, 2024

:)

from ansible-gitlab-runner.

github-actions avatar github-actions commented on June 11, 2024

Seems this message did not get a lot of love. This does not mean it was not seen but time wise might not have made it to proper attention. This is just the clean up action ;)

from ansible-gitlab-runner.

riemers avatar riemers commented on June 11, 2024

maybe need to change those bot things a bit..

from ansible-gitlab-runner.

gardar avatar gardar commented on June 11, 2024

Rather than using curl, how about using the community.general.gitlab_runner module? It can be used for registering the runner using both the old and new registration methods and it returns a token which can be written to the runner config.

from ansible-gitlab-runner.

guenhter avatar guenhter commented on June 11, 2024

This is a great idea!

from ansible-gitlab-runner.

github-actions avatar github-actions commented on June 11, 2024

Seems this message did not get a lot of love. This does not mean it was not seen but time wise might not have made it to proper attention. This is just the clean up action ;)

from ansible-gitlab-runner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.