environment REQUEST_URI not set about rack-test HOT 9 CLOSED

+1. Also bumped into it.

As a workaround (somewhat weird though), it is possible to pass env hash (with REQUEST_URI in it) as third argument to get/post/put/etc.

I'd also suggest that the lack of REQUEST_URI support (or any other standard rack feature) should be documented. Just to reduce global wtfs per minute.

from rack-test.

I just ran into this issue, too.

from rack-test.

Hmm... not sure about this one. From what I can tell, REQUEST_URI is not part of the Rack spec. (http://rack.rubyforge.org/doc/files/SPEC.html)

Can you guys give specific examples of what you ran into?

from rack-test.

I know it's been less than a month since I commented about it, but I can't remember the details of the issue. I wonder now, though, if what I was really running into was the Rails 3 move from using REQUEST_URI to PATH_INFO and I wrongly blamed rack-test.

If I can dig up a simple repro case, I'll post it.

from rack-test.

Non standard - my bad. But it is still there, in request.env ! Which is how I am guessing myself (and possibly others) ended up relying on it.

Perhaps, a clarification line about rack-test keeping strictly to the spec (as opposed to rack itself) could save some developers some time.

from rack-test.

Hi Artem,

Yes, my understanding is that it is often present but can vary by web server. Therefore, it's unsafe and PATH_INFO and SCRIPT_NAME should be preferred instead.

As for the clarification, a quick search of the latest Rack source shows only one reference to env["REQUREST_URI"] which is in the SCGI handler (which, I imagine, is barely used), so it seems as though Rack doesn't use it itself anymore.

-Bryan

from rack-test.

@brynary Nevertheless, REQUEST_URI is what is used by ActionController::Request in Rails 2. For those of us that would like to test our rails 2.x apps, this would still be a very welcome addition.

https://github.com/rails/rails/blob/v2.3.14/actionpack/lib/action_controller/request.rb#L367-371

I'd be happy to submit a PR if you're willing to accept it.

from rack-test.

For a framework that elects to use REQUEST_URI (e.g. Rails 2) it would be appropriate for the framework to handle ensuring REQUEST_URI gets set. Rack-Test intends to be extensible in this way -- if there's a way that could be easier, let me know.

Therefore, I'd recommend either a patch or monkey-patch to Rails 2.

from rack-test.

I've been bitten by this for 2 days. See this gist for how things go horribly wrong in things like RSpec request specs:

https://gist.github.com/f361516ee8686637ee23

from rack-test.