Rack::Test::UploadedFile#test_0007_finalizes on garbage collection fails on sparc about rack-test HOT 3 CLOSED

Due to CRuby's conservative GC, you can never be sure that an object would be finalized, because there might be something on the C stack that looks like a reference to it.

However, CRuby can probably use the same approach that JRuby uses (create 50 objects and GC after each), since that should statistically make it unlikely that all instances will not be GCed.

Can you try the following patch and let me know if it makes the tests pass?:

diff --git a/spec/rack/test/uploaded_file_spec.rb b/spec/rack/test/uploaded_file_spec.rb
index 2cb56ac..67bfbc5 100644
--- a/spec/rack/test/uploaded_file_spec.rb
+++ b/spec/rack/test/uploaded_file_spec.rb
@@ -69,8 +69,10 @@ describe Rack::Test::UploadedFile do
         System.gc
       end
     else
-      c.new(file_path)
-      GC.start
+      50.times do |_i|
+        c.new(file_path)
+        GC.start
+      end
     end
 
     # Due to CRuby's conservative garbage collection, you can never guarantee

from rack-test.

Due to CRuby's conservative GC, you can never be sure that an object would be finalized, because there might be something on the C stack that looks like a reference to it.

However, CRuby can probably use the same approach that JRuby uses (create 50 objects and GC after each), since that should statistically make it unlikely that all instances will not be GCed.

Can you try the following patch and let me know if it makes the tests pass?:

diff --git a/spec/rack/test/uploaded_file_spec.rb b/spec/rack/test/uploaded_file_spec.rb
index 2cb56ac..67bfbc5 100644
--- a/spec/rack/test/uploaded_file_spec.rb
+++ b/spec/rack/test/uploaded_file_spec.rb
@@ -69,8 +69,10 @@ describe Rack::Test::UploadedFile do
         System.gc
       end
     else
-      c.new(file_path)
-      GC.start
+      50.times do |_i|
+        c.new(file_path)
+        GC.start
+      end
     end
 
     # Due to CRuby's conservative garbage collection, you can never guarantee

That does the trick! 👍 Thank you!!

from rack-test.

OK, I pushed a commit for that. Thanks for the report!

from rack-test.