quittle / a11y-ally Goto Github PK

This is because they don't support theming well. I could either raise the minSdk or fix the theming issues caused by the earlier versions

When a subset of Apps to Inspect are selected, use the ActivityManager to recommend enabling A11y Ally. Example usage: https://stackoverflow.com/a/22303460/1554990

This needs to be carefully done to not drain the battery constantly checking the foreground app. It also doesn't solve the problem of how to get it running in the first place. This seems like something that would be perfect for a broadcast receiver.

Text that is too small may be difficult to read for all users

The touchable parts are too small and hard to hit. They should match the edges of the button, not just the text and switch itself

Scrolling through the list hard. A search box would save a lot of time

Black out all elements with no accessibility text. It would call out better than highlighting errors the inability to reason about an app if you can't see what a button is

It's difficult to find the commit that built a release when debugging from Google Play. Travis should tag the commit with the version code or version name to make it easy to find

Currently, all violations are penalty log. All the issues should be addressed and marked penalty death to avoid future regressions.

This will enable resource removal when not referenced. This is safe so long as references are not found via reflection or string look up.

https://developer.android.com/studio/build/shrink-code#strict-reference-checks

When creating a ButtonSwitch, specifying either android:padding or app:layoutPadding results in double the vertical space created compared to horizontal.

Only one should be on at a time but multiple can be, which is confusing.

Programmatically trigger a "screenshot" of what the screen reader sees snapshot comparison

Within the app, it needs to be more obvious what the highlighting means for learning how the app works

It might integrate well but it has a fairly limited set of checks and doesn't seem to be actively updated

https://github.com/google/Accessibility-Test-Framework-for-Android

As a developer, you don't want to set up the configuration in the app manually before starting the recording, so most of the configuration should be available to be set in the data field of the intent

Background Tint is a feature of newer android models. Instead, the drawable should be tinted in another way that is supported so that you don't get a boring, grey gradient on older devices.

It's not immediately obvious what you should do when you start the app or how to use. Create one of those panel-based tutorials to show the steps to get started and use the app.

In order to ensure the UI displayed in the Play Store is up to date, automating the generation of screenshots would be very helpful.

fastlane has a support library for generating them: https://docs.fastlane.tools/getting-started/android/screenshots.

If organized that way, developers could extend the functionality and checks for custom use cases

It might also clean up the implementation code within the app itself to be more aligned with swapping styles and features to detect

Rather than using transitions to return to the original state of the activity (because you can't trivially reverse a transition), it instead sets the state to be not in list mode and calls Activity.recreate() to restart it in the previous state.

It can be a little slow and looks odd but does the job. It also is more prone to issues if there were to be more state to maintain.

rootInActiveWindow is not guarded when accessed on here when it is lower. It has resulted in customer experienced SecurityExceptions.

This should include considerations made by the app and future design patterns that protect user data as part of surfacing accessibility app data

There are a few sources, such as Google's official Android recommendation of a minimum size of 48dp

Both for debugging and for feature discovery, the format and contents should be documented

Replace the big exclamation point button with icons and text that indicate what is wrong and add text indicating how to fix the problem. Maybe add a pulse animation to draw the eye to it.

Make it clearer that the big check is a toggle button.

I have a Google Pixel 2 with Android 11, Security-Update 5th October 2020.

Since the update to version 0.0.0.158 of the app. The permission for the Accessibility Service does not work any more

to reproduce to the following:

• Install the App from the Play Store
• Open it
• Tap on "Yeah"
• Pick an app to analyze
• Tap on" Next"
• Tap on "Accessibility Service, Fix it"
• Activate the Accessibility Service for A11y Ally
• go back to the App

On my device A11y Ally does not recognize the permission for the Accessibility Service, it shows still the "fix it" button

Is the new version of A11y Ally not compatible with my old Version of Android 11?

After running all day with the service disabled via preferences, but on as far as the OS was concerned, the overlay suddenly appeared again overnight. The preferences we're disabled still and required toggling on and off again to hide it

It misses

• Usage Hints
• Accessibility Actions Menu

This would allow catching of focus-jacking bugs do detect unfocusable elements

As a user, I might not like the default highlighting or settings, i.e. color contrast ratio, min font size. It would be better if the cards opened into mini settings cards that expanded and flipped to allow enabling and changing of these values. They could even allow setting off the indicator styling

An overlay that displays the touch target areas and possibly other stat- checking info. It could display data like font and background color as well as computed values like contrast ratio

It isn't obvious how to use the app or what it supports just from the play store listing

When in portrait mode, the overlay shows all issues as being the width of the navbar over from where they should be.

Currently the :connectedReleaseAndroidTest target doesn't run and potentially misses crashes in the release app due to proguarding or other optimizations applied. An initial investigation showed the following changes need to be made

build.gradle

android {
    buildTypes {
        release {
            testProguardFile file('config/proguard-test-rules.pro')
        }
    }
    testBuildType 'release'
}

config/proguard-test-rules.pro
Example configuration that may be incorrect to use

# Possibly required to find the renamed classes
-applymapping ../build/outputs/mapping/release/mapping.txt

# XML Pull Parsing might be brought in by an instrumentation test dependency, causing warnings
-ignorewarnings

When Linear Navigation Overlay is enabled and a subset of Apps to Inspect are selected, GET ME OUT OF HERE does not, in fact, get you out of there. You will be stuck in that mode until you can kill the service. A quick, sledgehammer solution is to restart the device.

1. Fix the issue and release an update
2. Add integration tests that verify the fix

As a developer, I only care about accessibility issues of my app or handful of apps

Text and background color is not provided to accessibility services so doing a pixel-level check would be required

Both tools appear to do the same thing. Explain why A11y Ally is better and different