praxisnetau / silverstripe-module-starter Goto Github PK

Hi,
Btw: If you're writing SilverStripe admin module, you might want to add the @silverstripe module and implement its features in webpack.config.js

This makes it real easy to use SilverStripe components and other stuff in your React modules. Found out this week, working on my first SilverStrip Admin module try-out :-).

Martine

Hi,
Maybe document a few extra comments on how to build a brandnew repo for the newly created module? Because it basically still starts out as your repo :-)

Here's how I did it - might not be the best way, so please have a look, comments are welcome.

I started by creating an empty repo on Github

1. adapted Licence and Readme
2. uncommented node_modules and mapfiles in .gitignore
3. removed setup.php and setup.json (and yarn.lock :))
4. removed .git
5. did a git init
6. git remote add origin https://github.com/Martimiz/my-repo
7. did the initial commit
8. pushed to origin/master

If you agree I will gladly make a pulll

Martine

Hi,
First of all many many thanks for setting up this supernice and much needed module!!!

I've run into a couple of small config issues that I'll address in one topic, if you don't mind :)

yarn

yarn.lock should probably be added to .gitignore I think

package.json:

running yarn install fails with:

The engine "node" is incompatible with this module. Expected version "^4.2.0".

That's because I'm using v8.6.0 and in package.json you have

"engines": {
"node": "^4.2.0"
},

Could that just be removed, you think?

webpack

running yarn build fails with:

[copy-webpack-plugin] WARNING - unable to locate 'mymodule/admin/client/src/images/icons'...

That directory isn't actually created, but referenced in webpack.config.js #127:

  if (src === PATHS.ADMIN.SRC) {
    common.push(
      new CopyWebpackPlugin([
        { from: path.resolve(src, 'images/icons'), to: 'images/icons' }
      ])
    );
  }

Should this be removed or should there be an actual icons folder. And is it supposed to contain icons?

Cheers, Martine