Comments (2)
Hi @Martimiz !
Thanks for submitting this issue, I'll go through each of your points:
yarn.lock should probably be added to .gitignore I think
Actually, the lock file should explicitly be added to version control. This ensures that everyone has the same dependencies installed from the get go. You can always delete the lock file yourself and customise the package.json
to install the versions of your choice.
running yarn install fails with "The engine "node" is incompatible with this module. Expected version "^4.2.0".
Hmm, it works fine for me with v8.4.0. Something else must be going wrong I think, because the version check "^4.2.0" should definitely work for your version of node. That said, I could probably bump the version requirement up to "^6.x" in line with SilverStripe's current requirements.
...should there be an actual icons folder. And is it supposed to contain icons?
Ah, when I committed to version control, my icons folder was empty, hence the structure was not added to the repo. I should make a note about that or perhaps add a "dummy" file in there. In the mean time, if you create images/icons/
under your admin/client/src/
folder, the error will disappear.
from silverstripe-module-starter.
Hi @colintucker, this module is really helpful for getting into the whole new front-end SilverStripe ecosystem, thanks!
Just to confirm; using node v8.11.1 indeed throws an 'incompatible version' error upon 'yarn install'.
Also for a version constraint of "^6.x" (which would only allow any v6 point release but not v8 I think?)
The SilverStripe 'webpack bundles' repo uses ">= 6.x" (any 6.x version or higher, which I can confirm works with 8.x) https://github.com/silverstripe/webpack-config
from silverstripe-module-starter.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from silverstripe-module-starter.