`SpriteIcon`s are unnecessary expensive about osu-framework HOT 7 CLOSED

Can you show demonstrable performance gains in real usages, not in the "spam every font awesome icon that exists" test scene?

I'm not necessarily rejecting this but using the absolute worst case to argue that this gives "significant" perf gains seems like a stretch.

from osu-framework.

Probably bad wording from my side, that's for sure, but I've never said that this will be a game changer or anything.
I understand that since this won't have a huge impact on the game it's automatically low-priority, but if it can be improved - why not?

from osu-framework.

Again, not rejecting this. Just wanting to find out how real the perf gains are to properly prioritise fixing this.

from osu-framework.

This is probably the best it's gonna get.

master	proposal

from osu-framework.

Performance gain is nice, but why aren't the icons sized the same on both? It's not just proportional upscaling, they're clearly stretched on the second screenshot.

from osu-framework.

Performance gain is nice, but why aren't the icons sized the same on both? It's not just proportional upscaling, they're clearly stretched on the second screenshot.

As said in the OP

(ignore icons aspect ratios for now, didn't want to spend much time in case this is not-needed/not an huge issue)

FillMode.Fit math isn't there yet

from osu-framework.

Please don't use screenshots of frame rates at single frames to compare performance. At very least, show a frame graph with full history showing sustained benefits.

Or better, make a test scene and don't include the whole of song select in the background. Or use the framework icon test scene.

from osu-framework.