Comments (3)
smoogipoo
commented on September 22, 2024
I don't remember/don't think there's a particular reason why it's a separate pass.
from osu-framework.
EVAST9919
commented on September 22, 2024
Okay, there's a reason for that: that's to ensure all the updates/invalidations/whatever have taken place.
With my approach there are cases in which, for example, ScreenSpaceDrawQuad is one frame outdated (content in ScrollContainer) and as such IsMaskedAway isn't "realtime". This has something to do with invalidation/validation timings and I'm not going into that rabbit hole.
Simpler example:
- child computes
IsMaskedAway - parent moves the drawable in
UpdateAfterChildren() IsMaskedAwaymay no longer be valid
Closing as not as simple (may be even not possible) to implement as initially thought.
from osu-framework.
EVAST9919
commented on September 22, 2024
Hmm, it seems like it's possible to put masking calculations into GenerateDrawNodeSubTree with similar benefits, still investigating.
I'll probably just open a pr when it's ready.
from osu-framework.
Related Issues (20)
- Periodic AccessViolation somewhere in BASS HOT 1
- Allow custom clear color for the window background HOT 5
- Crash on startup with Wayland fractional scaling
- Implement `CADisplayLink` on macOS for potentially better frame timing HOT 1
- Consider using `WS_EX_NOREDIRECTIONBITMAP` HOT 1
- Flickering on fullscreen Vulkan (AMD gpu, Windows)
- SDL3: Segfault on wayland backend HOT 5
- System.AccessViolationException when reloading `TestSceneTextureUploadPerformance` on vulkan HOT 1
- Platforms other than Windows crash when last windowed mode is borderless in latest master HOT 1
- AddFont() Method can't find my font. HOT 5
- Border smoothness is lost on Android devices HOT 1
- Vulkan renderer causes the game to crash after getting to results screen HOT 2
- Fixing windows ink tablet events on SDL3 HOT 1
- Hard crash on Android due to conflicting linux and android SDL3 libs HOT 1
- README file list outdated .NET SDK version HOT 1
- Multiline text box? HOT 1
- Vscode SampleGame prelaunch tasks typoed
- Double clicking dropdowns with `AlwaysShowSearchBar` set to false gets absorbed by transparent textbox HOT 2
- High output latency on GPUs with triple buffering VSync forced HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osu-framework.