Comments (2)
RusseII
commented on May 27, 2024
https://blog.openzeppelin.com/workshop-recap-secure-development-workshop-1/ this explains some of the risks we need to protect against.
from v1-core.
Namaskar-1F64F
commented on May 27, 2024
https://github.com/compound-finance/open-oracle/blob/master/contracts/Uniswap/UniswapAnchoredView.sol
https://github.com/aave/protocol-v2/blob/master/contracts/adapters/BaseUniswapAdapter.sol
When accepting a transfer, look at the balance before ad the balance after.
if the balance is less after - revert (either overflow or some wrong amount)
if the balance is more after - great, but return balanceAfter - balanceBefore as how much was actually deposited.
from v1-core.
Related Issues (20)
- Mainnet runthrough HOT 2
- update BondBeforeGracePeriodAndPaid error naming
- Revert on a sweep to a token with 0 balance
- Deploy to Mainnet HOT 1
- Use internal _burn methods and add role tests HOT 1
- Study spearbit changes for possible regression issues HOT 1
- Should we be using paymentBalance more places? HOT 1
- Create architecture diagram for explaining our system
- Volt Code Review Takeaways HOT 7
- Fix failing tests without .env
- Setup ImmuneFi bug bounty
- Deploy Contracts with Multisig
- Improve tests HOT 1
- Improve Resiliency HOT 2
- Mainnet Deployment HOT 2
- Look into OTC
- Create Testnet USDC Faucet HOT 3
- Improve documentation with e2e examples
- Create Events Bot HOT 1
- Feature request to enable fully trustless credit default insurance products
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from v1-core.