Volt Code Review Takeaways about v1-core HOT 7 CLOSED

to expand on the assert test for GRACE_PERIOD, all state variables that get set in a constructor or during initialization need to be tested for correctness

from v1-core.

@ElliotFriedman Did you look into the factory by chance? I forget the context there.

I think it was whether or not using a clone factory with the overhead of each call made sense.

Or maybe it was if it was possible at all. I think @RusseII might have run into trouble deploying at all with the size of our contracts + imports.

from v1-core.

Or maybe it was if it was possible at all. I think @RusseII might have run into trouble deploying at all with the size of our contracts + imports.

I think the issue was if we did not use the clone factory then the contract size was too large for us to deploy. I think @ElliotFriedman had some issue like this in the past and was going to see if it was possible to deploy the bondFactory + bond code separately to reduce contract size with a regular factory?

from v1-core.

It really should be possible. Try running hardhat contract size on your contracts in their current state, then try doing another run of the contract size after you remove the creation of a new bond token in the factory. The factory bytecode should be smaller after you remove the creation of the new token.

from v1-core.

@Namaskar-1F64F ready to close this?

from v1-core.

It really should be possible. Try running hardhat contract size on your contracts in their current state, then try doing another run of the contract size after you remove the creation of a new bond token in the factory. The factory bytecode should be smaller after you remove the creation of the new token.

After removing the bond and the instantiation,

- import "./Bond.sol";

- tokenImplementation = address(new Bond());
+ tokenImplementation = address(0x0);

using hh size-contracts

from v1-core.

Nice!

from v1-core.