Comments (1)
- #290 - this adds safety checks to our initializer. The new behavior of the contract after this change is that if maxSupply/_convertibleRatio/_collateralRatio are too high - then the
createBond
method will fail. Reverting at the createBond step is good. - #282 naming change - no possible regression issues.
- #288 - This breaks
convert
andredeem
for non-owners. Fixed with #292, additionally we have decided not to accept this suggestion - #262 - This upgrades the OZ contracts and adds an internal function call to the implementation contract constructor to prevent it from being initialized. This change should be investigated further for regression. I looked through the OZ upgrade from 4.5->4.6 and didn't seem to be any changes except to
Initializable
. Additionally I studied the_disabledInitializes
method and no possible side affects that I could think of. This method is in the constructor, so it had zero affect on the proxy contracts, only affects the implementation contract - #283 this removes a zero assignment from
collateralTokensRequired
. Solidity docs explicitly say that [The default value fro the uint types is 0
] (https://docs.soliditylang.org/en/latest/control-structures.html#default-value) - #285 this does not change any smart contract behavior - it only changes the value that is emitted from the pay method. However, it's weird that it's calling balanceOf manually instead of using our
paymentBalance()
method #296 - #287 - This is changing the behavior in sweep which could potentially add issues when trying to sweep tokens. It adds an additional check, that uses the previous logic for calculating sweepingTokenBalance to check if there are actually tokens to transfer. I investigated if we have tests making sure that we have an example where . Overall as well - this is a lower-risk method for us as it exists purely as a utility incase of transfer mistakes or airdrops. Unexpected reverts in this method would not affect the proper functioning of our contracts, it would only prevent sweeping of tokens sent to the contract by mistake. @RusseII to investigate this method further and think of ways that a malicious actor may be able to sweep tokens from the address when they are not supposed to. Created #301
from v1-core.
Related Issues (20)
- Mainnet runthrough HOT 2
- update BondBeforeGracePeriodAndPaid error naming
- Revert on a sweep to a token with 0 balance
- Deploy to Mainnet HOT 1
- Use internal _burn methods and add role tests HOT 1
- Should we be using paymentBalance more places? HOT 1
- Create architecture diagram for explaining our system
- Volt Code Review Takeaways HOT 7
- Fix failing tests without .env
- Setup ImmuneFi bug bounty
- Deploy Contracts with Multisig
- Improve tests HOT 1
- Improve Resiliency HOT 2
- Mainnet Deployment HOT 2
- Look into OTC
- Create Testnet USDC Faucet HOT 3
- Improve documentation with e2e examples
- Create Events Bot HOT 1
- Feature request to enable fully trustless credit default insurance products
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from v1-core.