polkadot-js / extension Goto Github PK

As introduced in polkadot-js/api#1152 (this also enables v2 transaction support)

Goal:

Make it easy to tweak.

Actions:

• Hamburger
• tweak of icon theme (currently default to polkadot)

For the future (once we actually have something):

• tweak of type, i.e. inject accounts, inject provider + accounts
• network selection

... more?

On Chrome web3Enable doesn't resolve. Tested with substrate-front-end

cc @riusricardo

The devDependency @polkadot/ts was updated from 0.1.58 to 0.1.59.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@polkadot/ts is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I use @polkadot-js/extension-inject, but sometimes I have the following problems.

https://polkadot.js.org/apps/#/accounts

Because window.injectedWeb3 is empty when DAPP is used.

Code injected by Extension

You can use CustomEvent to notify @polkadot/extension-dapp win.injectedWeb3 that it has been injected

I have 2 problematic work-flows:

1. create new account

• Click create a new account
• Copy the seed given to me in clipboard to paste it in my password manager later on.
• I am asked for a password, I need my password manager
  --> the extension looses focus and when getting back to it, clicking to create a new account displays a new seed

2. import account from mnemonic

• Click to import account
• Paste seed from the clipboard (copied from password manager before starting the process)
• Password is asked
  --> I'm screwed because I can't click away from the extension to use my password manager otherwise it'll loose focus and start from scratch

Both of these problems can be worked around by using pen an paper to manually copy the mnemonic and keep the clipboard for the password.

Metamask is bypassing these problem by first asking for a password at first launch before anything and then using it to encrypt any account keypair. Creating a new account doesn't ask for a password.

There have been updates to the babel7 monorepo:

• • The devDependency @babel/core was updated from 7.5.4 to 7.5.5.

• The peerDependency @babel/runtime was updated from 7.5.4 to 7.5.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Goal:

Allow the user to approve any access to the accounts & signer.

Background:

Currently accounts.get() will returns the accounts listed.

Actions:

• When the site requesting the accounts has not been approved yet, prompt the user to approve.
• If approved, all accounts are returned
• When disabled, the accounts are not approved

So 2 things -

• can either reject on the calls (via error) if not approved
• or have an explicit enable() call that injects

Since everything is call-based, we can just manage it on this level. (And much easier for dapp developers to integrate)

When using the extension to auth (only first auth - no longer happens during the session) into a polkadot-enabled site like claim.kusama.network, the extension defaults to asking for camera access without the user triggering any QR scanning functionality manually.

• Steps to reproduce: it always happens, as long as the extension is unlocked but not authenticated in the site.
• Browser in which this was tested: Brave beta, 0.70
• Example site: https://claim.kusama.network

What happens:

• camera access is requested

What should happen:

• camera access request should be exclusively manual

There have been updates to the babel7 monorepo:

• • The devDependency @babel/core was updated from 7.5.4 to 7.5.5.

• The peerDependency @babel/runtime was updated from 7.5.4 to 7.5.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

https://github.com/polkadot-js/extension/blob/master/packages/extension/manifest.json#L7

Related to cleanups on #104

There have been updates to the babel7 monorepo:

• • The devDependency @babel/core was updated from 7.5.5 to 7.6.0.

• The dependency @babel/runtime was updated from 7.5.5 to 7.6.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

As per polkadot-js/common#435

There have been updates to the babel7 monorepo:

• • The devDependency @babel/core was updated from 7.4.5 to 7.5.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

There have been updates to the babel7 monorepo:

• • The devDependency @babel/core was updated from 7.5.0 to 7.5.4.

• The peerDependency @babel/runtime was updated from 7.5.3 to 7.5.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The dependency @types/react-router was updated from 5.0.3 to 5.0.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/react-router is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

There have been updates to the babel7 monorepo:

• • The devDependency @babel/core was updated from 7.4.5 to 7.5.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

We'll need to make some space for more settings such as

• Manage Dapp authorization
• Select which accounts are visible
• Select Networks (to inject or to create accounts for)
• Add accounts with a JSON
• Add accounts with Parity Signer

We end up a little like in the situation of Fether, so my ideas are very much biased, however I think it worked well. Here's a bad drawing of what I thought about:

• global account selector showing accounts from the keyring associated with the network
• eyes to make an account visible or not (and make account have lower opacity)
• a + that contains all the account related menus
• a hamburger menu that contains all the general menus.
• a new page where users can manage their network name and address (would appear then in the general network menu)

I want to be able to sign transactions via my Trezor.

Currently we display the name of the sending chain (when known), however is all cases we always display the binary data - use metadata to break it down, as available

There have been updates to the babel7 monorepo:

• • The devDependency @babel/core was updated from 7.4.4 to 7.4.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency file-loader was updated from 4.1.0 to 4.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

file-loader is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

V0.2.1 published on the Firefox store

When connecting to Polkadot.js the popup doesn't appear to sign the authorization. (did it manually)

Upon sending a Tx, the Tx fails with the following message:

makeExtrinsicCall: error: Type error for parameter createData (Property "focused" is unsupported by Firefox) for windows.create.

Opening the extension asks for a password but the Tx has already failed.

There have been updates to the babel7 monorepo:

• • The devDependency @babel/core was updated from 7.6.0 to 7.6.2.

• The dependency @babel/runtime was updated from 7.6.0 to 7.6.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the babel7 group definition.

babel7 is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

The devDependency @polkadot/dev-react was updated from 0.31.0-beta.8 to 0.31.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@polkadot/dev-react is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

code:
import createType from "@polkadot/types/codec/createType";
....
createType("ExtrinsicPayload", request, { version: request.version})

request:

error:

Currently, if authorize.tab rejects, enable will reject. However, when receiving requests, the extension background script doesn't check if the webpage is authorized.

So even though the unauthorized webpage cannot use window.injectedWeb3, it can still do the following and access e.g. the accounts list or ask to sign extrinsics:

window.addEventListener('message', ({ data, source }) => { console.log('Received accounts list from unauthorized webpage', data); })
window.postMessage({ id: 1337, message: 'accounts.list', origin: 'page' }, '*');

Hello. Where could I see the roadmap for your extension?

Thank :)

OS: Mac OS Mojave 10.14.6
Brave Browser: Version 0.68.132 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Chrome Browser: Version 76.0.3809.132 (Official Build) (64-bit)
Polkadot{.js} extension: 0.10.1

Whenever I try to "Set Session Key" on https://polkadot.js.org/apps/#/staking/actions, the polkadot.js extension gets hanged/stuck. It opens a blank window and clicking on the extension also opens a blank window. Tried this multiple times on brave browser as well as chrome, same problem every time.

Console output after pression on "Set Session key"

Part of #15

The devDependency @polkadot/ts was updated from 0.1.72 to 0.1.73.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@polkadot/ts is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Goal:

Make the extension work on other browsers, FF & Safari

Actions:

Hook the chrome.* calls into proxies (either own or with packages such as extenzionizer)

on https://polkadot.js.org/apps/#/accounts (+ extension in master), Alexander, Firefox

how to reproduce:

• make a Tx from an extension account
• the popup to sign the Tx appears while the Tx fails at the same time

Uknown response: {"id":"1563097809584.3","error":"Unable to retrieve keypair '5G22HUM9unfvvAav61HUQUwCXrsvom1XYoT2KkXaA5vBmffm'","origin":"content"}

Hi,

Is there a way to export an account? I'm fine with pulling it out of a db or using an API if it is not possible via the UI.

The devDependency @polkadot/ts was updated from 0.1.60 to 0.1.61.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@polkadot/ts is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Goal:

Make the restoration process 100% aligned with what is done elsewhere.

Background:

At this point it always creates sr25519 and has no derivation path.

Actions:

Add both. These are slightly more advanced, so "hide" behind somewhere where it is not just completely ignored the whole time and making things more difficult, however somewhere where it is easy to actually do.

It allows for signing of any data

https://github.com/polkadot-js/apps/blob/master/packages/ui-api/src/Injected.tsx#L9

i.e. the dapp can simply do

import attachWeb3, { hasWeb3 } from '@polkadot/extension-dapp`;

const injectedPromise = attachWeb3(... dapp name...);

// the promise, on resolving will have the flattened object with allowed providers

Please can we have an "expand view" button, which opens the extension in a new tab.

Like Metamask has.

And also enable on the compat layer, i.e. with SingleSource

• First available hardware device (general hardware support asked for in #143)

Integration not generally available as of yet, but dev builds are available for the first milestone - not perfect, but is at a point where it can be integrated and tested

cc @jleni

The eval information is needed for the wasm/webpack combo I believe - https://github.com/polkadot-js/extension/blob/master/packages/extension/manifest.json#L29

See if there are any tweaks we can do to at the very least get rid of the unsafe-eval in there

I started playing with the polkadot.js extension in my chrome browser on my custom chain accessing through substrate UI, It gave me this error -
t.signer.sign is not a function.

It was a simple transaction to transfer the balance from an extension account to chain account. While the same transaction was easily performed by using Polkadot UI. Either the extension is not fully supportable on the substrate UI or something else.

Any popup on Firefox (welcome message, signing) opens a window with scrollbars.

Removing the height and width to the body css fixes it, not sure that's the best idea (and haven't tested on Chrome yet)

Yarn build gives me the following:

yarn build                    
yarn run v1.16.0
$ NODE_ENV=production polkadot-dev-build-ts
$ /home/thib/paritytech/polkadot-js/extension/node_modules/.bin/polkadot-dev-clean-build

*** Cleaning build directory ./build

*** Cleaning build directory packages/extension/build

*** Cleaning build directory packages/extension-dapp/build

*** Cleaning build directory packages/extension-ui/build
Version 3.4.5
extension-ui/src/Popup/Signing/Details.tsx:43:38 - error TS2339: Property 'sectionName' does not exist on type 'Method'.

43         <td className='data'>{method.sectionName}.{method.methodName}</td>
                                        ~~~~~~~~~~~

extension-ui/src/Popup/Signing/Details.tsx:43:59 - error TS2339: Property 'methodName' does not exist on type 'Method'.

43         <td className='data'>{method.sectionName}.{method.methodName}</td>
                                                             ~~~~~~~~~~

extension-ui/src/messaging.ts:9:23 - error TS7016: Could not find a declaration file for module 'extensionizer'. '/home/thib/paritytech/polkadot-js/extension/node_modules/extensionizer/index.js' implicitly has an 'any' type.
  Try `npm install @types/extensionizer` if it exists or add a new declaration (.d.ts) file containing `declare module 'extensionizer';`

9 import extension from 'extensionizer';
                        ~~~~~~~~~~~~~~~

extension-ui/src/messaging.ts:27:29 - error TS7006: Parameter 'data' implicitly has an 'any' type.

27 port.onMessage.addListener((data) => {
                               ~~~~

extension/src/background/handlers/Extension.ts:11:10 - error TS2305: Module '"../../../../../node_modules/@polkadot/types"' has no exported member 'SignaturePayloadRaw'.

11 import { SignaturePayloadRaw } from '@polkadot/types';
            ~~~~~~~~~~~~~~~~~~~

extension/src/background/handlers/Extension.ts:43:45 - error TS2339: Property 'meta' does not exist on type 'KeyringPair'.

43     keyring.saveAccountMeta(pair, { ...pair.meta, name });
                                               ~~~~

extension/src/background/handlers/Extension.ts:120:16 - error TS2322: Type '() => string' is not assignable to type 'string'.

120       address: keyring.createFromUri(seed, {}, type).address,
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  extension/src/background/handlers/Extension.ts:120:16
    120       address: keyring.createFromUri(seed, {}, type).address,
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Did you mean to call this expression?

extension/src/background/handlers/Extension.ts:130:16 - error TS2322: Type '() => string' is not assignable to type 'string'.

130       address: keyring.createFromUri(seed, {}, type).address,
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  extension/src/background/handlers/Extension.ts:130:16
    130       address: keyring.createFromUri(seed, {}, type).address,
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Did you mean to call this expression?

extension/src/background/handlers/State.ts:7:23 - error TS7016: Could not find a declaration file for module 'extensionizer'. '/home/thib/paritytech/polkadot-js/extension/node_modules/extensionizer/index.js' implicitly has an 'any' type.
  Try `npm install @types/extensionizer` if it exists or add a new declaration (.d.ts) file containing `declare module 'extensionizer';`

7 import extension from 'extensionizer';
                        ~~~~~~~~~~~~~~~

extension/src/background/index.ts:5:23 - error TS7016: Could not find a declaration file for module 'extensionizer'. '/home/thib/paritytech/polkadot-js/extension/node_modules/extensionizer/index.js' implicitly has an 'any' type.
  Try `npm install @types/extensionizer` if it exists or add a new declaration (.d.ts) file containing `declare module 'extensionizer';`

5 import extension from 'extensionizer';
                        ~~~~~~~~~~~~~~~

extension/src/background/index.ts:9:19 - error TS2305: Module '"../../../../node_modules/@polkadot/ui-keyring"' has no exported member 'ExtensionStore'.

9 import keyring, { ExtensionStore } from '@polkadot/ui-keyring';
                    ~~~~~~~~~~~~~~

extension/src/background/index.ts:20:42 - error TS7006: Parameter 'port' implicitly has an 'any' type.

20 extension.runtime.onConnect.addListener((port) => {
                                            ~~~~

extension/src/background/index.ts:25:31 - error TS7006: Parameter 'data' implicitly has an 'any' type.

25   port.onMessage.addListener((data) => handlers(data, port));
                                 ~~~~

extension/src/content.ts:5:23 - error TS7016: Could not find a declaration file for module 'extensionizer'. '/home/thib/paritytech/polkadot-js/extension/node_modules/extensionizer/index.js' implicitly has an 'any' type.
  Try `npm install @types/extensionizer` if it exists or add a new declaration (.d.ts) file containing `declare module 'extensionizer';`

5 import extension from 'extensionizer';
                        ~~~~~~~~~~~~~~~

extension/src/content.ts:13:29 - error TS7006: Parameter 'data' implicitly has an 'any' type.

13 port.onMessage.addListener((data) => {
                               ~~~~


Found 15 errors.

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Goal:

The user should be able to check access on a per site basis and either approve/reject these.

Actions:

• storage permissions to storage
• page where the user to reject or approve based on sites that requested access

Similar to #10

Goal:

Allow the user better control over the accounts injected.

Background:

Currently all available accounts are injected into the page. Permissions per site are to be set via #9 - but we would like to extend this with account control.

Actions:

Allow the user to select the visible accounts on a global level and allow adjustments thereof on a per-site basis. So by default the defaults will be injected, however per site the accounts can be limited or overridden.