Clicking on the title bar section in the activity bar for a maximized window (with pixel-saver) should show the same context menu that would be shown when right-clicking on the title bar of a maximized window (without pixel-saver). Instead, Gnomes normal context menu, which only offers a "Quit" option, is shown.

After checking out to 1.7 as the installation instructions say, the "3.20" is being removed from metadata.json.

I think tag 1.7 should point to 3633968

I ran into an issue with launching spotify with pixel-saver enabled. Calling win.get_compositor_private() in line 207 of decoration.js for this window always returns nil. This gets pixel-saver stuck in an infinite loop of calling onWindowAdded, using 100% CPU.

There should probably be some sort of max retries there. Simply disabling the callback to onWindowAdded() with return false; after the if (!win.get_compositor_private()) { call is a workaround, but probably not the right solution.

Thanks!

First: THANK YOU for this antidote to Gnome's obsession with taking up all a user's vertical screen space.

I've just installed under Gnome 3.10 (as part of Ubuntu Gnome 14.04 Trusty) from the master branch (the 1.2 branch was greyed out in tweak tool saying incompatible version), and it works fine except that I get a duplicated close button

Screenshot:

(Could this be because I have overridden gnome's buttons options to provide them all on the left?)

Non-maximized:

Maximized:

So, title-bar doesn't dissapears, while additional buttons in activity bar are showed.

Ubuntu 13.10
Shell version: 3.8.4
Extension version: 2 (from metadata.json), installed from https://extensions.gnome.org

I tried with gdm and Lightdm with no success.
Maybe that's somehow related with my 2-monitor configuration.

Also, I've found following comment in decoration.js:

 * **Caveat**: doesn't work with Ubuntu's Ambiance and Radiance window themes -
 * my guess is they don't respect or implement this property.

I made the installation process described here, and ist not working on my gnome 3.20.

When fullscreen, the three buttons do not show, only the close button shows up and all the other buttons are missing. Running Gnome 3.16.4 on Ubuntu

(At least for me) the only change necessary to get this to work with 3.20 is to add it to the version list in metadata.json.

If I fullscreen a window with the Super-Up shortcut or by double clicking the title bar, the activity bar is properly updated (showing the full window title).
But if I fullscreen a window by dragging its title bar to the top, the activity bar still shows the default application name.

It looks like it could be a bug in GNOME (version 3.18.2 from Fedora 23). window.get_maximized() in Util.getWindow() does think that the upper window is not maximized at this point. I guess it means that the signal is sent too early when the fullscreen is made by dragging with the mouse.
But I'll let you diagnose (in case I missed something) and decide if that is to be reported upstream (if you do, could you post the GNOME bug report here too please?).

Fullscreen by dragging to the top of the screen with mouse (wrong):

Fullscreen by Super+Up or double clicking on the title bar (correct):

Thanks.

Not working in gnome 3.16, just editing metadata is not enough.

By default, some apps start maximized. E.g. firefox. This is what happens : http://puu.sh/83f79.png

The decoration bar is displayed (but it shouldn't), but so are the pixel-saver buttons. If I reduce the window and the maximize it back, it works fine. Sometimes changing the focus to another window fixes it too.

Also, when the decoration bar is displayed, the buttons don't work.

Hi,
im using debian jessie with gnome 3.14 and this extension is working great except that it is not working with the editor kate.
If i activate logging i get the following output:

Gjs-Message: JS LOG: [pixel-saver]: Override title Untitled – Kate
Gjs-Message: JS LOG: [pixel-saver]: Could not find XID for window with title Untitled – Kate
Gjs-Message: JS LOG: [pixel-saver]: Could not find XID for window with title Untitled – Kate
Gjs-Message: JS LOG: [pixel-saver]: Could not find XID for window with title Untitled – Kate
Gjs-Message: JS LOG: [pixel-saver]: Finding XID for window Untitled – Kate failed

The error catched at line 47 of the file decoration.js is:
Error: Failed to convert UTF-8 string to JS string: Ungültige Bytefolge in Konvertierungseingabe

other kde applications (i ve tested kile or okular) got their titlebar removed.
Thanks

edit: i ve solved the issue... kde applications need a seperate language pack installed... in my case kde-l10n-de

Here is another cleanup issue.

(gnome-shell:4344): Clutter-WARNING **: Attempting to remove actor of type 'StLabel' from group of class 'ShellGenericContainer', but the container is not the actor's parent.

Steps to reproduce:

• Disable Pixel Saver

This warning is caused by https://github.com/deadalnix/pixel-saver/blob/master/pixel-saver%40deadalnix.me/app_menu.js#L241

Safeguarding fixes it:

if (Main.uiGroup.contains(tooltip)) {
    Main.uiGroup.remove_actor(tooltip);
}

Is there a way not to show window buttons in the panel all the time? I've quickly gone through other issues on here and saw the mention of configuration options, but I don't see them anywhere.
Using Ubuntu 16.04, Gnome 3.20, and the newest version of this extension available here.

Thanks

Bug: Right-clicking on the close button in the activity bar closes the window. At the very least, it should do nothing.

Enhancement: Instead of doing nothing when the activity bars close button gets rightclicked, the same menu that gets shown when the "normal" close button (in the window title bar) gets rightclicked could be shown.

(Gnome offers the following actions by default for maximized windows: Minimize, Unmaximize, Move, Resize (disabled), Always on top (disabled), Always on Visible Workspace, Move to Workspace Up, Move to Workspace Down).

Currently this applies to all displays, or no displays. I would appreciate an option to only have this happen on the user's primary display. I'm not familiar with gnome extensions so apologies if there are any technical hurdles in the way of this.

Steps to reproduce:

• Disable Pixel Saver
• Start new application that is currently not running (I used Meld 3.12.1)
• Maximize window of new application
• Enable Pixel Saver
  -> the title bar of the new application should be hidden - works fine
• Disable Pixel Saver
  -> the title bar of the new application should be visible, but it stays hidden!

The problem seems to be that if no maximized state can be found, this information is not cached and therefore the next invocation does not return the (cached) original state, but instead determines the state again. But if the maximized state has been set by Pixel Saver, it is stored and returned which means that the original state cannot be restored upon deactivation.

Not a big deal, but still warrants a fix.

When this extension is used in combination with hidetopbar, tabbed windows may cause the whole interface to be unreactive to any mouse action. More details can be found in issue mlutfy/hidetopbar#88.

It would be great to have an option to remove window decorations even for unmaximized windows. I previously achieved this through the metacity configuration, but this approach is not applicable in recent versions of gnome-shell that use gtk.css.

Love this extension - almost perfect for me, works better on my machine than Maximus ( which often left a black bar where title bar should be on my Fedora 21 /Gnome 3.14 install).
There are basically 2 minor issues I have:
1 Is it possible to get unmaximize button in Pixel Saver? I can cope by using keyboard shortcuts , but it would come really handy to have it.

2 When I toggle the apps, the buttons for the maximized one does not always disapear. And going the other way - the do not always apear when I toggle from other app to a maxmized one.
In this second instance when I click the top bar Pixel Saver buttons show up.

Are any workarounds for those? With those resolved Pixel Saver would be simply perfect :).

When a window is maximized in the current workspace*, the "close" button (and possibly other buttons as well, not tested) shows up in the titlebar, even if the active window is another one.

For example, in the screenshot below, the active window is an unmaximized terminal instance, but a close button is still shown, because the firefox browser on the same workspace is maximized. If the browser is unmaximized, the close button disappears.

Even more "disturbing": if I press the "close" button, the title quickly changes to the Firefox one, and Firefox is closed, instead of the terminal.

I see this on GNOME Shell 3.18.1 on Debian testing with version 10 of this extension. It happens with or without a secondary screen attached.

Note that this also happens if a maximized window is present on a secondary screen when workspaces are only enabled on the primary screen

Exist any way to move the control windows buttons to the right of the panel, some like this:

Hi!
Using latest version with Gnome 3.14 when i right click something like a folder in Nautilus or to get the menu in Firefox to display the source code i always get a cross to replace my cursor, then i have to right click again to get the property dialog or the source code. Also the window that opens sometimes doesn't display nice.
Tell me how can i give you a log to work on this issue.

Hello,

It would be awesome to have a tag or a dedicated branch for old versions of gnome.

Currently I'm using Gnome 3.10 and to make this extension work perfectly I should checkout the commit 4fb6409

Anyways, good job, I love your extension ;)

When window is maximized, title is shown on Activy bar, but when it's stacked left|right the App name is shown:

The better is to rewrite Activity Titke also when stacked, since the title bar is hidden.

Using pixel-saver in Gnome 3.18, while it seems to works gnome-tweak-tool shows that the extension didn't load correctly. Using LookingGlass to investigate this issue returns the error in the title.

Hello, I'm the author of the StatusTitleBar extension, both extensions serve a similar purpose, so I propose we reuse code instead of duplicating it.

The ideal solution would be to have some sort of package manager for gnome shell extensions, but that doesn't seem possible right now, so I'm thinking on 2 possible solutions:

1. I can continue to develop the status titlebar app menu only, and you can continue developing decorations.

2. We merge our work and keep a single project with similar funcionality.

This is only a proposition, checkout the StatusTitleBar repository (https://github.com/emerinohdz/StatusTitleBar), I have integrated Gulp task manager and also the extension is developed in a more OO way.

Which is really weird, considering 1.3 used to work fine, and other apps also run fine.
Any ideas ?

Edit: I recompiled atom 1.3.2, just to make sure. It does work properly with 1.3.2, but not with 1.5+.

I would like to please place a feature request to not integrate the buttons from the window decorations into the Gnome's top bar, while doing the wonderful stuff that PixelSaver currently does? :)

It looks somewhat out of place there and upsets my delicate balance of buttons on the top panes. Is there maybe a hack of some sort to do this in current version?

The title bar changes normally when switching windows between different apps, but fails to do so when switching windows of the same app (for example multiple Terminal windows, switch using `alt+``).

I've replaced this line (#193) in app_menu.js:

focusCallbackID = Shell.WindowTracker.get_default().connect('notify::focus-app', onFocusChange);

with

focusCallbackID = global.display.connect('notify::focus-window', onFocusChange);

This seems to have fixed this issue but I'm not sure if it affects any other functionality or whether it's the best way to do it.

The activity bar window close button doesn't get shown for windows maximized to half of the screen with the Win+Left / Win+Right hotkeys.

Hey,

I know there's a ticket for gnome 3.16 compatibility, but 3.18 is out and it doesn't work either D;

First, I'd like to thank you, deadalnix. Since my previous solution with Status Title Bar and a metacity theme hack broke with 3.16, I've been on the lookout for something that actually worked, and this one does.

So, since this extension uses xprop, it only works on X windows. Since I use Wayland, GTK3 applications do not shed their titlebar when maximized. This is generally not dramatic because most of them have an action bar anyway, but Evolution still uses a simple title bar. It would be great if I could remove its titlebar as well.

In decoration.js the notify:n-workspaces'event is registered with global.screen, but cleanup is wrongly performed against global.window_manager.

gnome-session[1829]: (gnome-shell:7240): Gjs-WARNING **: JS ERROR: TypeError: appMenu._label.setText is not a function
gnome-session[1829]: updateAppMenu@/home/andrew/.local/share/gnome-shell/extensions/[email protected]/app_menu.js:40

This breaks window titles
Wrapping it in a try/catch to silence the error and fixes titles, don't know enough about gnome-shell to debug myself

My desktop is running on debian 8, I clone the 1.5 release and checkout to 1.5, but every time a new window created, the cursor change to crosshair and all windows get stuck :(
but when I comment the 50th line( which is let act = win.get_compositor_private(); ) of decoration.js , the bug disappeared! I guess this function has some bugs, can you fix it?
Sorry about my chinglish :)

A screenshot on Fedora 21 with Gnome 3.14.2:

A screenshot on Fedora 22 with Gnome 3.16.2:

As you can see, only the program's name is shown in the top bar in Gnome 3.16.2, while the window's title is shown in Gnome 3.14.2.

The version of Pixel Saver I'm using is the one found on https://extensions.gnome.org/extension/723/pixel-saver/.

I'm using Debian Stable and would appreciate if the extension would be compatible with this older release out-of-the-box. The breaking changes are fairly minimal and I would propose that instead of dropping the old code, some version checking conditions could be used instead to guard the code for the different releases.

There are already some places were a similar, but IMHO weaker, approach is taken, like

try {
    // Gnome 3.16
    wmCallbackIDs.push(global.window_manager.connect('maximize', updateVisibility));
    wmCallbackIDs.push(global.window_manager.connect('unmaximize', updateVisibility));
} catch (e) {
    // Gnome 3.18
    wmCallbackIDs.push(global.window_manager.connect('size-change', updateVisibility));
}

I would suggest to instead use something like

if (Version.since(3, 18)) {
    wmCallbackIDs.push(global.window_manager.connect('size-change', updateVisibility));
} else {
    wmCallbackIDs.push(global.window_manager.connect('maximize', updateVisibility));
    wmCallbackIDs.push(global.window_manager.connect('unmaximize', updateVisibility));
}

If you could agree with this proposal, I would be willing to create a PR with the necessary changes. Thanks.

I would like to configure where the buttons are displayed. I personally would prefer them after the system menu, not before it. I saw the code that sets the position of the buttons, and I think you could add a setting to let the user choose either an automatic position (as it is now), or a custom left or right aligned position.

Another thing is that they only show up when a window is maximized. If a non-maximized window is focused, they will perform an action on the maximized window, not on the focused window. This is a bit tricky, since the focused application name is displayed in the top bar, but the buttons act on the other window.

My suggestion is to keep the behaviour from the original window-buttons extension: always keep them visible (this will also prevent things moving all the time in the top bar) and tie them to the currently focused window. If there are no opened windows, they could be shown as disabled (or at least should do nothing).

Displaying the appmenu tooltip is broken on at least 3.18.

(gnome-shell:4344): Gjs-WARNING **: JS ERROR: TypeError: label is undefined

Changing https://github.com/deadalnix/pixel-saver/blob/master/pixel-saver%40deadalnix.me/app_menu.js#L114

from

let label = appMenu._label._label;

to

let label = appMenu._label;

does the trick on Gnome 3.18

How about a tooltip with the full window title on mouseover on the the activity bar?
Could be usefull especially for web pages titles.

https://extensions.gnome.org/extension/723/pixel-saver/ is still not compatible with version 3.20

pixel-saver isn't working, and I see this message in syslog whenever I try to start the extension . Am on Ubuntu Gnome 15.10 beta.

guessWindowXID() can return null, but the return value is not always safe-guarded which can potentially lead to errors as some code expects it to be non-null.

Pixel Saver is such a saver ;) . But I encountered one issue - when I use Zukitwo theme and window decoration close/minize icons are being replaced by white dots (which ain't pretty). Is there a way to set "fixed" set of icons?

I tried installing like this:

git clone https://github.com/deadalnix/pixel-saver.git
cd pixel-saver
git checkout 1.6
cp -r [email protected] ~/.local/share/gnome-shell/extensions
gnome-shell-extension-tool -e [email protected]

When I maximize a window, the behavior is the same as before. Tried logging out and back in, but it still didn't work. I'm in Gnome 3.18.2. Does it need to be updated for the latest Gnome?

Whenever I issue this command the buttons keep showing (even though all windows are minimized). Clicking on close, maximize or minimize in this case does absolutely nothing