Doesn't work properly on Gnome 3.12 about pixel-saver HOT 28 CLOSED

I have Archlinux with Gnome 3.12.1 and i cant install

from pixel-saver.

I have the same issue as geecko86.

rkmax, how are you trying to install? I have arch and 3.12, and intallation went fine.

from pixel-saver.

@silentboatman maybe is the version i have installed 3.12.1. on gnome-extension page when i switch to ON and click on INSTALL, if i refresh the page the extension is OFF again and I cant find it in the list of installed extensions

from pixel-saver.

You probably need to download the code from GitHub.

from pixel-saver.

I tried, but dont work :(

from pixel-saver.

Yes, that would be the problem. You can the git version fron the aur at https://aur.archlinux.org/packages/gnome-shell-extension-pixel-saver-git/

from pixel-saver.

Oh didn't see your comment. Sorry. But have you tried AUR?

from pixel-saver.

weird the aur package works fine 😄 thx!

from pixel-saver.

np :)

from pixel-saver.

I also have geecko86 problem where I don't get the buttons till i un-maximise and the re-maximise. Once I have done that though the buttons work great. I am on ubuntu 14.04 with gnome 3.12 from staging ppa.

from pixel-saver.

Down it, the extension have been packaged into arch. Nice.

Back to the topic, I'm no arch user, and I'm still running on 3.8 . It look like something has changed in gnome that broke pixel saver. That is a bit annoying.

I'll need one of you guys to edit your local copy of https://github.com/deadalnix/pixel-saver/blob/master/pixel-saver%40deadalnix.me/decoration.js and enable the LOG (uncomment line 7). Then tell me if the function onWindowAdded is called when you open the maximized window.

Sorry for taking that long to answer that thread.

from pixel-saver.

Where do I find the log file?
On 19/05/2014 2:06 PM, "deadalnix" [email protected] wrote:

Down it, the extension have been packaged into arch. Nice.

Back to the topic, I'm no arch user, and I'm still running on 3.8 . It
look like something has changed in gnome that broke pixel saver. That is a
bit annoying.

I'll need one of you guys to edit your local copy of
https://github.com/deadalnix/pixel-saver/blob/master/pixel-saver%40deadalnix.me/decoration.jsand enable the LOG (uncomment line 7). Then tell me if the function
onWindowAdded is called when you open the maximized window.

Sorry for taking that long to answer that thread.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-43464656
.

from pixel-saver.

I found it

tail -f /home/jason/.cache/upstart/gnome-session-GNOME.log

On Mon, May 19, 2014 at 8:00 PM, Jason Pell [email protected] wrote:

Where do I find the log file?
On 19/05/2014 2:06 PM, "deadalnix" [email protected] wrote:

Down it, the extension have been packaged into arch. Nice.

Back to the topic, I'm no arch user, and I'm still running on 3.8 . It
look like something has changed in gnome that broke pixel saver. That is a
bit annoying.

I'll need one of you guys to edit your local copy of
https://github.com/deadalnix/pixel-saver/blob/master/pixel-saver%40deadalnix.me/decoration.jsand enable the LOG (uncomment line 7). Then tell me if the function
onWindowAdded is called when you open the maximized window.

Sorry for taking that long to answer that thread.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-43464656
.

from pixel-saver.

Window manager warning: Log level 8: Source ID 1678 was not found when attempting to remove it

(process:29499): GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed

(gnome-shell:6746): Gjs-WARNING **: JS ERROR: TypeError: Shell.StageInputMode is undefined
onFocusChange@/home/jason/.local/share/gnome-shell/extensions/[email protected]/app_menu.js:74

Gjs-Message: JS LOG: [pixel-saver]: Override title Mozilla Firefox
Gjs-Message: JS LOG: [pixel-saver]: onWindowAdded: Mozilla Firefox initially hide title ? false
Gjs-Message: JS LOG: [pixel-saver]: setHideTitlebar: Mozilla Firefox: true
Gjs-Message: JS LOG: [pixel-saver]: xprop -id 0x280007f -f _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED 32c -set _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED 0x1
Gjs-Message: JS LOG: [pixel-saver]: Override title Mozilla Firefox Start Page - Mozilla Firefox
Window manager warning: Log level 8: Source ID 1685 was not found when attempting to remove it
Gjs-Message: JS LOG: [pixel-saver]: Override title Terminal

from pixel-saver.

Yeah, I'm getting the same error as well:

gnome-session[2376]: (gnome-shell:2530): Gjs-WARNING **: JS ERROR: TypeError: Shell.StageInputMode is undefined
gnome-session[2376]: onFocusChange@/home/lmacken/.local/share/gnome-shell/extensions/[email protected]/app_menu.js:74

from pixel-saver.

Thenk you guys. Now I have something to work on 👍

from pixel-saver.

Hey things don't really seem to be moving. Do you need some help?

from pixel-saver.

Hi all,

It's been a long time, but I updated to 3.12 and tackled this issue. As you don't break with old habit, gnome changed some obscure API and the change is not documented, so I have no idea how good is the fix.

If some of you want to play the lab rats, you can simply update your version of pixel saver and tell me how it goes.

from pixel-saver.

Seems to work fine so far. Thank you so much! :) I love pixel-saver.

from pixel-saver.

Ok It look like it is making things better but I can still trigger the problem in some cases.

from pixel-saver.

That's correct. Sorry.
It's actually kind of random. I can close chromium and open it again a bunch of times and the results will vary.

from pixel-saver.

I'm also still seeing the problem of new maximized windows not being handled. The error about StageInputMode is gone, as can be expected from the code. FWIW, I'm maximizing the windows through a devilspie2 script, so they might not technically be maximized on window creation yet (not sure about timing).

from pixel-saver.

As far as I can tell, the problem is mostly gone, but tend to reappear in some situation like when you unlock the screen. Can you repro consistently ? that would help to pinpoint what is the actual cause of the issue.

from pixel-saver.

Yeah, it's occuring all the time here - both on chromium that gets maximized by itself (probably does some "remember window position" thing itself) and on xterms that are maximized on startup using a devilspie2 script.

However, digging in further shows that the xprop is correctly set on these windows. Furthermore, when I switch to another window or desktop and then back to the offending window, the titlebar is removed as expected. It seems there is some kind of race condition here (which would suggest a bug in mutter, though looking at the mutter source, it does actually schedule a redraw when the xprop is changed).

As a workaround, I added win.move(false, 0, 0) after setting the xprop. I was hoping this would do a relative move which is essentially a noop, but would trigger a redraw, removing the titlebar. However, looking more closely, it turns out this actually moves the window to the top left corner of my desktop for an instant (which I can tell since it is on a different monitor), and then it is moved back to where it spawned. I'm not yet sure what is doing the moving back part - it also occurs when I try to move windows through the looking glass long after they're spawned. Might be another extension, I'll have to take a closer look.

Anyway, no more time today, but I'll probably dive into this a bit deeper soon.

from pixel-saver.

I just created a PR with a fix (rather, workaround) that seems to work for me.

from pixel-saver.

Ok I implemented something similar to what @matthijskooijman proposed as I somehow missed the notification for his PR :(

@matthijskooijman I like your solution better, and if you are willing to rebase, I'll merge it.

We still have one blind spot, when we unlock/get out of sleep mode or whatever, we get the same issue. But the wack a mole game is doing good, we will eventually get rid of this !

from pixel-saver.

I rebased the PR.

What is the unlock problem you're talking about? I use sleeping all the time and just tried lock/unlock and all windows were still properly displayed.

As for the cause of such a problem - I think that extensions are disabled when locking, sleeping or on screen blank and re-enabled when resuming, so I suspect that something goes wrong there (but since the code in the PR should run on enable I think, you'd expect that it should just work. Perhaps the timing is different when resuming for you, which exposes the race condition with xprop completion (which my PR solves properly)?

from pixel-saver.

I think we can close that one.

from pixel-saver.