photo / mobile-android Goto Github PK

The credentials and url is not refreshed during different users sessions. Let's get the value all the time from:

 PreferenceManager.getDefaultSharedPreferences(...)

The network time is extremely slow compared with this request.

Reproduce.

1. Latest version of app
2. Enable auto upload
3. Use the OpenPhoto app to take a photo
4. Notice immediately that the photo begins to upload (before hitting upload)
5. Press upload and notice it start to upload again (i left it private)

The last two photos say the upload failed on my phone in the notification bar but when I check the website it shows 3 duplicates of both photos.

http://test.openphoto.me/photos/list

When auto upload is enabled and a photo is taken with the native camera app it processes the upload. However, there's an error on the backend and dumping out the $_FILES array shows that the file isn't being sent properly. I believe this is a problem with the app since uploading from within the app works okay.

array (\n  'photo' => \n  array (\n    'name' => 'IMAG0345.jpg',\n    'type' => '',\n    'tmp_name' => '',\n    'error' => 3,\n    'size' => 0,\n  )

Per the PHP documentation error no. 3 is a partial file upload.

http://php.net/manual/en/features.file-upload.errors.php
UPLOAD_ERR_PARTIAL
Value: 3; The uploaded file was only partially uploaded.

Add sharing button to the screen.
It should have:

• email
• twitter
• facebook

We can postpone the aviary integration till later.

The CameraActivity is current just a place holder - get it to use the camera and take a photo

If a duplicate photo is posted to the upload API it will return a 409 conflict response.

Eventually we may want to include messaging to differentiate this from other errors.

openphoto/frontend#43

If not authenticated (not logged in), do not allow upload of a picture

If enabled in settings, automatically upload pictures taken with the android phone to the openphoto server. It will add a tag "autoupload" or whatever tag specified in settings.

pboos already has implemented that with flickr and will copy that code into this project.

the date and location information are not on this photo...

http://photos.jaisenmathai.com/p/5au

Tags are displayed as buttons like that:

I already did this using xml. See file list_item_newest_photos.xml.

See what is in the master:

Now we need to dynamically create this inside the Activity HomeActivity

We'll want to include recent activity on the home tab. These APIs are being tracked in openphoto/frontend#498.

iOS equivalent at openphoto/mobile-ios#88

When uploading a picture through the app, do not show a blocking progress dialog. Instead use the UploadService. But for that the progress and error handling there needs to be implemented already (see #7 and #8 )!

So it will look the following to the user:

1. User fills out everything for the upload
2. Click on Upload
3. Upload window closes immediately with message, that it is uploading in background
4. UploadService is called to upload
5. UploadService shows a notification which shows the progress of the upload(s) (if many they are queued).
6. UploadService shows a done notification when success

• Or if it failed it shows a error notification which will bring the user back to the activity if clicked

The logo/icon gets slightly cut off at the bottom of the circle. This happens everywhere I've seen it such as the home screen and the icon when present in the notification bar while uploading.

So far we have the CameraActivity, PreviewHelper and CameraUtils that are all require unit tests

Steps to reproduce:

1. Launch OpenPhoto app
2. Click settings button
3. Click "log in"
4. In the web view, click Log In button
5. See attached

This is being tracked on the BrowserID side here: mozilla/persona#428

Using an HTC G2 with the physical keyboard, if the keyboard opened when entering meta information the menu to take a photo pops up, interrupting the original photo upload.

A name parameter of OpenPhoto Android App should be passed to the authorize flow. See openphoto/frontend#294

When changing the server in the app, it should log out the user because the stored authentication does not apply to the new server.

On the photo detail view "null" is displayed when there is no title or description.

When i first open the app the thumbnails load up ok but if I exit the app and then open it again they fail to load. I have to force stop in my apps management and then they will reload again.

There are random issues with BrowserID on mobile applications. Below is a proposal to resolve it.

1. Require the user to log into their OpenPhoto account (ideally from a non mobile device).
2. Under their settings page they can generate a 6 character "mobile passphrase" which lasts 15 minutes. After 15 minutes the passphrase is invalidated.
3. From the mobile application the user is redirected to the same oauth page with an additional mobile=1 parameter.
4. Instead of seeing the "sign in" link the user will be prompted to input their mobile passphrase.
5. Once entered the user will be authenticated and can complete the OAuth flow without invoking BrowserID.

I believe this is secure and resolves the issues we're seeing not only on Android but also on iOS.

CC @patricksan & @pboos for comments.

When I click the photos/tags/home tag it should refresh. Another option is to add refresh into the menu bar. Not sure which is more common on Android.

Hi I have an asus transformer and HTC One X.

Both run ICS 4.0.3 and on both I can't login using the app.

I downloaded the latest app from the repo and that did not solve my issue.

let me know how I can debug this for you.

Lance

Moving from email to this issue.

{
  "message":"oauth_problem=signature_invalid&debug_sbs=POST&http%3A%2F%2Fcurrent.openphoto.me%2Fphoto%2Fupload.json&description%3D%26oauth_consumer_key%3D487eee32b4dce22b0b78c217aa9326%26oauth_nonce%3D1276576652435996063%26oauth_signature_method%3DHMAC-SHA1%26oauth_timestamp%3D1318595671%26oauth_token%3Da8291920e569f6b7788a3924db3bb9%26oauth_version%3D1.0%26permission%3D0%26tags%3D%26title%3D",
  "code":403,
  "result":null
}

Enable private and public icon in the photo:

NOTE: if photo is public, just hide the icon

In the image detail view where the photo is displayed the user should be able to zoom into the photo. This with the normal touch zoom gestures.

Screenshots: http://theopenphotoproject.org/screenshots

You can find the assets for the iOS app here, https://github.com/openphoto/mobile-ios/tree/master/OpenPhoto/images.

If you need anything additional or designs for Android specific elements we can get those as well.

A few of my photos when uploaded ended up with a "MIME-encoded tag" from their EXIF keywords, eg
http://ajft.openphoto.me/photo/29/ is tagged with "Y2F0AA==" which is the MIME/Base64 encoding for "cat"

Write tests for auto upload functionality

To test:

• provider
• broadcast receiver
• upload service

would be nice if there was newer test builds, so we can test it and give feedback
the one here on github is an ancient alpha build

clicking on a photo can it be fit to the screen (not extend past the edges)

After I take a picture auto upload of the image to openphoto starts. I then get a message stating it has failed. The app then continually keeps trying to upload the image but failing. When I then check my open photo account it has been uploaded multiple times and I have multiple copies of the image in my dropbox account.

When the user is not logged in to any openphoto server, show this screen:
http://theopenphotoproject.org/img/screenshots/mobile-login.png

@jmathai Is it correct, that we want to only allow to use the app if the user logs in to the server? And what should happen if the user clicks on "Create an openphoto account"? Just open http://openphoto.me/ ?

the button does not work on my asus transformer prime runing ics

http://www.bugsense.com

Allow the user to start uploading a photo and continue using the app. Should also be able to take another photo and upload it simultaneously.

Unsure what amount of effort this requires...

See openphoto/mobile-ios#40 for the iOS version of this bug.

write tests for upload activity

I recently was stuck in an upload loop where the app thought the upload failed (when it succeeded) so it kept trying and duplicating the photo. Is this because the return code for uploads changed?

Maybe related to #29 but I don't believe it's a dup.

Hi,

I tried to login using my Open-Photo id: "mudit.openphoto.me" but when i press "Login" button on the app it redirects me to a new page [URL: http://mudit.openphoto.me/v1/oauth/authorize?mobile=1&name=OpenPhoto Android App&oauth_callback=openphoto://callback].

The Page says "You need to sign in to create an app." and when i presses the sign in link below - nothing happens.

I checked the code of Android app:

when clicking on "Sign in" link, the code control is not going inside "shouldOverrideUrlLoading" function of WebViewClient.

When setting up and logged into the app on a honeycomb tablet, the text is small and hard to read and all to the left.

It should probably be made flexible and set center instead of left. Can the font size be set to a relative size so it adjusts based on screen size?

https://twitpic.com/7ciavj

When an upload through the UploadService fails, than show a notification that it failed. When user clicks on it, it should bring the user to the UploadActivity where everything is filled out like it was for that upload.

I have uploaded loads of photos to my hosted openphoto account and all is working well.

When I open the newer version of the android app thumbnails fail to upload until i get to photos that were taken on the 11th Feb. I just get black thumbnails on the photos that I have uploaded since then. If i click on the black thumbnail it says loading but nothing loads up. Not sure why this happening, the only thing I can think of that has changed is that I have installed the openphoto dropbox app on my hosted account. I have tried deleting the photos I had uploaded via that method and then uploaded them via the hosted account site but that still didnt work.

Also when i click on the home tab no image loads up, I just get a white page with the openphoto logo at the top and the three tabs at the bottom.

As I say all is working well on the beta PC version and the images appear on there fine, just not on the android app.

HTC Desire S, Android version 2.3.5

When geoposition is in the picture, enable a button to open Google Maps.

• Disabled
  
• Enabled