- ๐ญ Iโm always working on MassTransit
phatboyg / greenpipes Goto Github PK
View Code? Open in Web Editor NEWAn asynchronous pipe implementation for the Task Parallel Library
License: Apache License 2.0
An asynchronous pipe implementation for the Task Parallel Library
License: Apache License 2.0
See MassTransit/MassTransit#1334 for full description.
Issue is present in GreenPipes code through the BaseRetryPolicyContext
and RetryFilter
implementation
Hi,
I was investigating some issue and i've found that update callback in BasePipeContext.AddOrUpdatePayload
always adds new element to context instead of updating it. Basically it does exactly the same as add. if (_collection.TryGetPayload(out T existingValue))
{
if (context == null || previousValue != existingValue)
context = new PayloadValue<T>(updateFactory(existingValue));
previousValue = existingValue;
currentCollection = Volatile.Read(ref _collection);
Interlocked.CompareExchange(ref _collection, currentCollection.Add(context), currentCollection);
}
Is there any way to update existing value in context? Or is it maybe guaranteed that only newest added element is returned? So even though there is old object and new produced by update factory in context it will always return new one?
Please add ability to specify per-item expiration timeout.
The constructor of ExponentialRetryPolicy
materializes the IEnumerable<TimeSpan>
returned from GetIntervals()
. This seems directly opposed to its nature:
Int32.MaxValue
as unlimited.When using retryLimit: Int32.MaxValue
, which GetIntervals()
explicitly special-cases, the loop is infinite (until ToArray()
tries to allocate an array that is too large).
Even when avoiding Int32.MaxValue
, when trying to accommodate a very large number of attempts, the materialized array can take a lot of memory, when the intervals could just be calculated on-the-fly. Materialization also incurs a lot of calls to Random.Next()
that would otherwise have been amortized over the lifetime of the policy instance.
A good alternative property type to TimeSpan[]
might be IEnumerator<TimeSpan>
, since it enforces forward-only behavior. It is a public property, unfortunately, so I'm not sure how far the impact reaches.
I ran into this issue when I was trying to use exponential message retries in MassTransit 7.0.7.
OutOfMemoryException in ExponentialRetryPolicy when retryLimit=int.MaxValue
Is it made intentionally, to pass the whole TextWriter object to use only one its method. What if my log implementation is not inherited from TextWriter?
A missing return will lead to infinity, and beyond.
I used the Greenpipes v 3.0.0 with the
automatonymous v 4.2.0
masstransit as 5.5.6
masstransit.automatonymous as v 5.5.5
i received following error
Could not load type 'GreenPipes.Payloads.PayloadCache' from assembly 'GreenPipes, Version=3.0.0.0, Culture=neutral, PublicKeyToken=b800c4cfcdeea87b'.
Could you please let us know how to resolve this one?
Can you please provide nuget with support for 4.5.1 framework.
.Net Standard support
found develop-netcore branch but no nuget package
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.