Hi Pedro,

I have a list items sorted and grouped by type. Is possible render this list with separators between groups of items?

I've done many tests but I've not achieved :_(
I tried to return in the method inflate() two different views depending on some PanelItemViewModel parameter but when I call getContent() method always return null.

CurrentDistributionPanelItemViewModel

public class CurrentDistributionPanelItemViewModel {

    private final WorkOrderLineViewModel workOrderLine;
    private final CurrentDistributionPanelSeparatorViewModel separator;

    public CurrentDistributionPanelItemViewModel(WorkOrderLineViewModel workOrderLine,
                                                 CurrentDistributionPanelSeparatorViewModel separator) {
        this.workOrderLine = workOrderLine;
        this.separator = separator;
    }

    public boolean isSeparator() {
        if(separator != null) {
            return true;
        }
        return false;
    }

    public WorkOrderLineViewModel getWorkOrderLine() {
        return workOrderLine;
    }

    public CurrentDistributionPanelSeparatorViewModel getSeparator() {
        return separator;
    }
}

CurrentDistributionPanelItemRenderer.java

...

@Override
    protected View inflate(LayoutInflater inflater, ViewGroup parent) {
        View v = null;
        if(getContent().getWorkOrderLine() == null) {
        }
        else {
            v = inflater.inflate(R.layout.work_order_line, parent, false);
            resource = (TextView) v.findViewById(R.id.resource);
            costGroup = (TextView) v.findViewById(R.id.cost_group);
            unitsLabel = (TextView) v.findViewById(R.id.units_label);
            unitsValue = (TextView) v.findViewById(R.id.units_value);
        }
        return v;
    }

How can I achieve it?

Thanks

We are going to update all the project documentation and add a new module supporting Kotlin properly. We will make the library more idiomatic and kotlin friendly so our Android users can enjoy it 😃

Puedes subir algún ejemplo un poco más sencillo y directo?

Me está costando un poco implementar la librería en mi proyecto. Me he liado un poco con el ejemplo que tienes subido.

Sobre todo a la hora de iniciar el adaptador:

RendererAdapter adapter = new RendererAdapter(inflater,B, C);

En B que incluyo? y en C?

Gracias.

Buenas Pedro, no consigo entender como implementar la gestion del click a un elemento de la lista sin hacer uso de inyeccion de dependencias..¿Tienes algun ejemplo?
Gracias por la libreria, creo que me va a ahorrar años de dolores de cabeza xD

After the latest Architecture Components release made by Google during December 2017 we've noticed they have released a new adapter named PagedListAdapter we should support. As the architecture component is a new module we should provide this as a new renderers module so we don't add the architecture components to the main artifact. More information can be found in this video

Following the instructions on the libary's readme file the app wont compile due to the following errors:

• Class 'VideRenderer' must either be declared abstract or implement abstract method setupView(View) in Renderer
• Class 'VideRenderer' must either be declared abstract or implement abstract method hookListeners(View) in Renderer

So it looks like the library have been changed but the example has not been updated we the new needed code

It's time to review our build.gradle configuration and update some dependencies 😃

Method Renderer::hookListeners declared abstract, but there could be instances that do not require registering any callbacks at all.

As it turns out, Kotlin synthetic properties cache works by default on Activities, Fragments, and Views, but it does not do so for ViewHolder. They fixed this as of Kotlin 1.1.4 via LayoutContainer.

Consumers of this libraries have to make sure they make their Renderers implement LayoutContainer if they are using synthetic properties inside of them. If they do not, their ViewHolders are going to call findViewById() on every call to render() making their ViewHolders obsolete. It would be nice if the library itself did this maybe by adding a Kotlin specific artifact that implements this interface (implementation should be trivial). Thoughts?

Hi,

I'd like to be able to get the adapter position of a View from within a Renderer. Is this possible?

One use case is passing the position to between Activities to keep the user's selection synchronized when they click a View

Thanks

I would like to use the renderers library to fill a viewpager instead of a listview, what could be the best aproach?

I am trying to use it for the first time and I am following your sample implementation. My implementation varies where you have a concrete Video class, I have an abstract class. I had no problem implementing the various Renderer classes to handle my different content types but when I went to implement my RendererBuilder, I am unable to add my concrete Renderer classes to the list. This may be something stupid I am doing with my generic typing but beating my head on my desk is getting me nowhere. Thought I'd ask if you could shed some light on it. Thanks for sharing your library. I am really looking forward to using it.

Hello thx you for good project but i have manny questions.. First sorry about my English but i hope you understand me ) I try write simple project with Renderes lib, for server loading imitation i use handler .. Some think like this

new Handler().postDelayed(new Runnable() {
            @Override
            public void run() {
                RandomVideoCollectionGenerator randomVideoCollectionGenerator =
                        new RandomVideoCollectionGenerator();
                adapter.addAll(randomVideoCollectionGenerator.generate(4));
            }
        }, 5000);

But lib don't add this items to recyclerView.. i don't understand why... can you say me?

In my production code i use ItemAnimator.. is it ok for Renderes lib? how i can write custom method like this -

public void updateItems(List<String> data, boolean animated) {
        feedItems.clear();
        feedItems.addAll(data);
        if (animated) {
            notifyItemRangeInserted(0, feedItems.size());
        } else {
            notifyDataSetChanged();
        }
    }

i think i can override RVRendererAdapter and write what i need but i don't shore ..

Thx for your time!

Hello:

  With listview i can do multiselect and start Action Mode easy.

  With recyclerView it is more complicated, maybe you can include an extension to recyclerView that include multiselect and works with this library or my best chance will be still using ListView?

Thanks,

RendererBuilder classes responsibility is related to map objects to render with Renderer instances. We should improve how RendererBuilder is used and a good approach could be offer a map(ClassToRender.class,Renderer) method to avoid use RendererBuilder by extension. The goal: simplify how RendererBuilder is used.

Nice, how would you integrate the Observable pattern in your library?

Use Renderers when you need just one Renderer to draw your lists can be a little bit complicated. You have to create a RendererBuilder with just one Renderer instance as prototype and we can do it better. The goal: simplify how this library can be used for the simplest example.

Hi Pedro, thanks for sharing such a great library. Is there an IOS version of this library or any plan to make one?

In rendererBuilder there are 2 methods, that have wired signature.

public RendererBuilder<T> bind(Class<T> clazz, Renderer<T> prototype)
public RendererBuilder<T> bind(Class<T> clazz, Class<? extends Renderer> prototypeClass)

This signature doesn't allow to bind model classes that extends to T to some prototype.
For example in case when we have class A and class B, where B extends A, if we create RendererBuilder<A> we can only bind class A to some prototype. There is no way to bind class B, because Class<B> doesn't extends Class<A>.

I suggests to change signature of these methods to

public <G extends T> RendererBuilder<T> bind(Class<G> clazz, Renderer<G> prototype)
public <G extends T> RendererBuilder<T> bind(Class<G> clazz, Class<? extends Renderer> prototypeClass)

This would allow to bind deferent subclasses of T to renderers.

Hello,

I have started work on new sample, that binds different renderer classes to different model classes, was planing to make it on top of Video and VideoRenderer. But there are problems:
VideoRenderer sets layout that will use in subclasses,
Video model has too much fields.

What if I would make completely different example, not about videos?

Hi everyone!

I would like to know if we could change RVRendererAdapter and RVListRendererAdapter collection type to Collection<T> instead of AdapteeCollection<T>.

It causes me trouble in the following situation. I would like to update just one item from the list instead of performing a full diffUpdate. Since there is no set method in AdapteeCollection I can only do the following:

List<T> list = (List<T>) collection;
list.set(position, newElement);
notifyItemChanged(position);

The drawback of this approach is that it is performing a cast over collection assuming that the implementation inherits from List.

Another way of tackling this issue would be copying all elements into aList<T> and performing the set operation there. But that is even worse given the original collection is already a List<T> and we would be doing a useless copy.

Are there any arguments against using Collection instead of AdapteeCollection?

I detected this behaviour just after add your library.

android:uses-permission#android.permission.READ_PHONE_STATE
IMPLIED from AndroidManifest.xml:2:1 reason: com.pedrogomez.renderers has a targetSdkVersion < 4
android:uses-permission#android.permission.READ_EXTERNAL_STORAGE
IMPLIED from AndroidManifest.xml:2:1 reason: com.pedrogomez.renderers requested WRITE_EXTERNAL_STORAGE

Buenas pedro mi nombre es luis, he estado usando tu libreria y la verdad es que me parece muy buena por lo que te felicito, estudie informatica en la um igual que tu y te he visto por ai... bueno queria preguntarte como puedo eliminar un item de mi lista usando tu libreria porque una de las pegas que encuentro es que no tengo acceso al adaptador por lo que me resulta dificil hacer algunas cosas con mi lista...espero tu respuesta gracias y de nuevo enhorabuena por tu libreria esta muy bien hecha....

RVRendererAdapter addAll signature differs from the Collection one making it impossible to use it with collections of subtypes.
The fix is as easy as changing the method signature from

public void addAll(Collection<T> elements)

to

public void addAll(Collection<? extends T> elements)

It will be backwards compatible which is always nice.

Will the library be migrated to androidx ?

So what's the difference between "getItemViewType" and "getPrototypeIndex" in RendererBuilder..

You find the matched renderer class in getItemViewType, but loops prototypes again in getPrototypeIndex to get the index.. it really make me confused.

I'd like to get other content by its position in Renderer, If it possible?

I am thinking about adding methods isEnabled(int position) and areAllItemsEnabled() to the RendererAdapter, so it would be possible to disable some items.

However RendererAdapter doesn't know much about collection of items that it handles, so I feel like it should call method isEnabled(T content) in the mapped Renderer.

What do you think about this functionality?