Code Monkey home page Code Monkey logo

Comments (4)

pedrovgs avatar pedrovgs commented on August 27, 2024

@Serchinastico the library adapters should implement List<T>. If you send a PR can be awesome! :)

from renderers.

Serchinastico avatar Serchinastico commented on August 27, 2024

I don't see why they should, there are some List methods that doesn't make any sense in this context (subList and lastIndexOf comes to my mind). I'd personally make the adapters implement AdapteeCollection<T> which contains all the methods that can be delegated to the inner collection.
What do you think?

from renderers.

pedrovgs avatar pedrovgs commented on August 27, 2024

Most of the time, the adapter is being used as a list due to the last changes in the Android list widgets API and to avoid references to the collection inside the adapter. With RecyclerView now you can insert/remove one item given a position and that's needed to perform some optimizations related to the RecyclerView draw cycle. If you want we can fix just the issue you've noticed and create another issue to review the RVRendererAdapter interface later.

from renderers.

pedrovgs avatar pedrovgs commented on August 27, 2024

Fixed by @Serchinastico

from renderers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.